| Message ID | cover.1541193856.git.osandov@fb.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fstests: test Btrfs swapfile support | expand |
On Fri, Nov 02, 2018 at 02:29:35PM -0700, Omar Sandoval wrote: > From: Omar Sandoval <osandov@fb.com> > > This series fixes a couple of generic swapfile tests and adds some > Btrfs-specific swapfile tests. Btrfs swapfile support is scheduled for > 4.21 [1]. > > 1: https://www.spinics.net/lists/linux-btrfs/msg83454.html > > Thanks! Thanks for the fixes and new tests! > > Omar Sandoval (7): > generic/{472,496,497}: fix $seeqres typo > generic/{472,496}: fix swap file creation on Btrfs I've merged above two patches, they're two obvious bug fixes. > btrfs: test swap file activation restrictions > btrfs: test invalid operations on a swap file > btrfs: test swap files on multiple devices > btrfs: test device add/remove/replace with an active swap file > btrfs: test balance and resize with an active swap file These tests look fine to me, but it'd be really great if btrfs folks could help review above tests and provide Reviewed-by tags. And perhaps we could add test 17[56] to 'volume' group, as they do device operations. And similarly, add the last test to 'balance' group. Thanks, Eryu > > tests/btrfs/173 | 55 ++++++++++++++++++++++++++++++ > tests/btrfs/173.out | 5 +++ > tests/btrfs/174 | 66 ++++++++++++++++++++++++++++++++++++ > tests/btrfs/174.out | 10 ++++++ > tests/btrfs/175 | 73 ++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/175.out | 8 +++++ > tests/btrfs/176 | 82 +++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/176.out | 5 +++ > tests/btrfs/177 | 64 +++++++++++++++++++++++++++++++++++ > tests/btrfs/177.out | 6 ++++ > tests/btrfs/group | 5 +++ > tests/generic/472 | 16 ++++----- > tests/generic/496 | 8 ++--- > tests/generic/497 | 2 +- > 14 files changed, 391 insertions(+), 14 deletions(-) > create mode 100755 tests/btrfs/173 > create mode 100644 tests/btrfs/173.out > create mode 100755 tests/btrfs/174 > create mode 100644 tests/btrfs/174.out > create mode 100755 tests/btrfs/175 > create mode 100644 tests/btrfs/175.out > create mode 100755 tests/btrfs/176 > create mode 100644 tests/btrfs/176.out > create mode 100755 tests/btrfs/177 > create mode 100644 tests/btrfs/177.out > > -- > 2.19.1 >
On Mon, Nov 05, 2018 at 12:09:31AM +0800, Eryu Guan wrote: > On Fri, Nov 02, 2018 at 02:29:35PM -0700, Omar Sandoval wrote: > > From: Omar Sandoval <osandov@fb.com> > > > > This series fixes a couple of generic swapfile tests and adds some > > Btrfs-specific swapfile tests. Btrfs swapfile support is scheduled for > > 4.21 [1]. > > > > 1: https://www.spinics.net/lists/linux-btrfs/msg83454.html > > > > Thanks! > > Thanks for the fixes and new tests! > > > > > Omar Sandoval (7): > > generic/{472,496,497}: fix $seeqres typo > > generic/{472,496}: fix swap file creation on Btrfs > > I've merged above two patches, they're two obvious bug fixes. > > > btrfs: test swap file activation restrictions > > btrfs: test invalid operations on a swap file > > btrfs: test swap files on multiple devices > > btrfs: test device add/remove/replace with an active swap file > > btrfs: test balance and resize with an active swap file > > These tests look fine to me, but it'd be really great if btrfs folks > could help review above tests and provide Reviewed-by tags. All look good to me, Reviewed-by: David Sterba <dsterba@suse.com> A few nits I saw: - the command names should not be shortened, ie. 'btrfs subvolume snapshot' instead of 'btrfs subvol snap' - the test description (eg. 3/7 and 4/7) could mention which case is tested, eg. swapfile with compression or COW or snapshot - 4/7 has typo 'nowcow' in a comment
On Tue, Nov 06, 2018 at 02:06:30PM +0100, David Sterba wrote: > On Mon, Nov 05, 2018 at 12:09:31AM +0800, Eryu Guan wrote: > > On Fri, Nov 02, 2018 at 02:29:35PM -0700, Omar Sandoval wrote: > > > From: Omar Sandoval <osandov@fb.com> > > > > > > This series fixes a couple of generic swapfile tests and adds some > > > Btrfs-specific swapfile tests. Btrfs swapfile support is scheduled for > > > 4.21 [1]. > > > > > > 1: https://www.spinics.net/lists/linux-btrfs/msg83454.html > > > > > > Thanks! > > > > Thanks for the fixes and new tests! > > > > > > > > Omar Sandoval (7): > > > generic/{472,496,497}: fix $seeqres typo > > > generic/{472,496}: fix swap file creation on Btrfs > > > > I've merged above two patches, they're two obvious bug fixes. > > > > > btrfs: test swap file activation restrictions > > > btrfs: test invalid operations on a swap file > > > btrfs: test swap files on multiple devices > > > btrfs: test device add/remove/replace with an active swap file > > > btrfs: test balance and resize with an active swap file > > > > These tests look fine to me, but it'd be really great if btrfs folks > > could help review above tests and provide Reviewed-by tags. > > All look good to me, > > Reviewed-by: David Sterba <dsterba@suse.com> Thanks a lot for the review! > > A few nits I saw: > > - the command names should not be shortened, ie. 'btrfs subvolume > snapshot' instead of 'btrfs subvol snap' > - the test description (eg. 3/7 and 4/7) could mention which case is > tested, eg. swapfile with compression or COW or snapshot > - 4/7 has typo 'nowcow' in a comment I've addressed these nits on commit. Thanks, Eryu
From: Omar Sandoval <osandov@fb.com> This series fixes a couple of generic swapfile tests and adds some Btrfs-specific swapfile tests. Btrfs swapfile support is scheduled for 4.21 [1]. 1: https://www.spinics.net/lists/linux-btrfs/msg83454.html Thanks! Omar Sandoval (7): generic/{472,496,497}: fix $seeqres typo generic/{472,496}: fix swap file creation on Btrfs btrfs: test swap file activation restrictions btrfs: test invalid operations on a swap file btrfs: test swap files on multiple devices btrfs: test device add/remove/replace with an active swap file btrfs: test balance and resize with an active swap file tests/btrfs/173 | 55 ++++++++++++++++++++++++++++++ tests/btrfs/173.out | 5 +++ tests/btrfs/174 | 66 ++++++++++++++++++++++++++++++++++++ tests/btrfs/174.out | 10 ++++++ tests/btrfs/175 | 73 ++++++++++++++++++++++++++++++++++++++++ tests/btrfs/175.out | 8 +++++ tests/btrfs/176 | 82 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/176.out | 5 +++ tests/btrfs/177 | 64 +++++++++++++++++++++++++++++++++++ tests/btrfs/177.out | 6 ++++ tests/btrfs/group | 5 +++ tests/generic/472 | 16 ++++----- tests/generic/496 | 8 ++--- tests/generic/497 | 2 +- 14 files changed, 391 insertions(+), 14 deletions(-) create mode 100755 tests/btrfs/173 create mode 100644 tests/btrfs/173.out create mode 100755 tests/btrfs/174 create mode 100644 tests/btrfs/174.out create mode 100755 tests/btrfs/175 create mode 100644 tests/btrfs/175.out create mode 100755 tests/btrfs/176 create mode 100644 tests/btrfs/176.out create mode 100755 tests/btrfs/177 create mode 100644 tests/btrfs/177.out