[v2,0/5] Avoid confusing messages from new index extensions
mbox series

Message ID 20181120060920.GA144753@google.com
Headers show
  • Avoid confusing messages from new index extensions
Related show


Jonathan Nieder Nov. 20, 2018, 6:09 a.m. UTC
Junio C Hamano wrote:
> Ben Peart <peartben@gmail.com> writes:

>> Why introduce a new setting to disable writing the IEOT extension
>> instead of just using the existing index.threads setting?
> But index.threads is about what the reader does, not about the
> writer who does not even know who will be reading the resulting
> index, no?

It affects the writer, too, since it affects the number of blocks, but
from an end user's point of view, I agree.

Here's an updated version of the series.

Patches 1-3 are as before, except that they are rebased to avoid
conflicting with nd/config-split.

Patch 4 allows enabling the new index extensions with a single config
setting, to address the feedback above.

Patch 5 revives the noisiness when encountering an unknown index
extension, guarded with an advice setting.

Sorry for the delay in getting this out.  Thoughts of all kinds
welcome, as always.

Jonathan Nieder (5):
  eoie: default to not writing EOIE section
  ieot: default to not writing IEOT section
  index: do not warn about unrecognized extensions
  index: make index.threads=true enable ieot and eoie
  index: offer advice for unknown index extensions

 Documentation/config/index.txt | 16 ++++++++++
 advice.c                       |  2 ++
 advice.h                       |  1 +
 config.c                       | 17 ++++++-----
 config.h                       |  2 +-
 read-cache.c                   | 54 +++++++++++++++++++++++++++++-----
 t/t1700-split-index.sh         | 11 ++++---
 7 files changed, 84 insertions(+), 19 deletions(-)