| Message ID | pull.85.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | rebase: warn about the correct tree's OID | expand |
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes: > A quick fix for a recent topic. Not overly critical, but I would deem this > v2.20.0-rc1 material. > > Johannes Schindelin (1): > rebase: warn about the correct tree's OID > Yup, it is kind of embarrasing that nobody caught it, but at the same time, this typo is at so tiny level that I would not be surprised if it survived for many years. Will apply. > builtin/rebase.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > > base-commit: bb75be6cb916297f271c846f2f9caa3daaaec718 > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-85%2Fdscho%2Freset_head-typo-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-85/dscho/reset_head-typo-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/85
Hi Junio, On Wed, 21 Nov 2018, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > A quick fix for a recent topic. Not overly critical, but I would deem this > > v2.20.0-rc1 material. > > > > Johannes Schindelin (1): > > rebase: warn about the correct tree's OID > > > > Yup, it is kind of embarrasing that nobody caught it, but at the > same time, this typo is at so tiny level that I would not be > surprised if it survived for many years. TBH I am quite mortified that it slipped through *my* multiple pre-contribution reviews. > Will apply. Thanks. Ciao, Dscho