mbox series

[mmc-utils,0/5] Various fixes for mmc-utils

Message ID 20181218143601.24413-1-michael.heimpold@i2se.com (mailing list archive)
Headers show
Series Various fixes for mmc-utils | expand

Message

Michael Heimpold Dec. 18, 2018, 2:35 p.m. UTC 
This series bundles several small fixes and enhancements
I stumbled over during short testing today.

It can also be found in my Github tree:
https://github.com/mhei/mmc-utils/tree/fixes-enh

Michael Heimpold (5):
  Check calloc's return value before using the pointer
  Cleanup memory in error case
  Fix parsing of character in to_binstr()
  Optimize to_binstr() function
  Add eMMC vendor Micron to table

 lsmmc.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

Comments

Avri Altman Dec. 20, 2018, 10:58 a.m. UTC | #1 
Hi,
> 
> This series bundles several small fixes and enhancements
> I stumbled over during short testing today.
> 
> It can also be found in my Github tree:
> https://github.com/mhei/mmc-utils/tree/fixes-enh
> 
> Michael Heimpold (5):
>   Check calloc's return value before using the pointer
>   Cleanup memory in error case
>   Fix parsing of character in to_binstr()
>   Optimize to_binstr() function
>   Add eMMC vendor Micron to table
> 

Aside of the tad optimization of strcat which seems a bit excessive (After all, it's not as if we're in the data path),
This series looks good to me.

Reviewed-by: Avri Altman <avri.altman@wdc.com>