mbox series

[v6,00/11] Specify CONFIG_PCI dependency explicitly

Message ID 20190105100606.6673-1-okaya@kernel.org (mailing list archive)
Headers show
Series Specify CONFIG_PCI dependency explicitly | expand

Message

Sinan Kaya Jan. 5, 2019, 10:05 a.m. UTC
This patchset fixes fallout of commit 5d32a66541c4 ("PCI/ACPI: Allow
ACPI to be built without CONFIG_PCI set") which is part of Rafael's
acpi pull for v4.21.

After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.

Several drivers depend on PCI but do not call that out in their
Kconfig. This causes linker and compilation errors when CONFIG_ACPI
is set but CONFIG_PCI is unset.

Diff from v5:
Refactor platform/x86: intel_ips and  platform/x86: apple-gmux per
feedback from Andy.
Collect acked-by and reviewed-by from Andy.

Sinan Kaya (11):
  ACPI / LPSS: Make PCI dependency explicit
  ata: pata_acpi: Make PCI dependency explicit
  vga-switcheroo: make PCI dependency explicit
  platform/x86: intel_ips: make PCI dependency explicit
  platform/x86: intel_pmc: Make PCI dependency explicit
  platform/x86: apple-gmux: Make PCI dependency explicit
  drivers: thermal: int3406_thermal: Make PCI dependency explicit
  ASoC: Intel: atom: Make PCI dependency explicit
  mmc: sdhci-acpi: Make PCI dependency explicit
  x86/intel/lpss: Make PCI dependency explicit
  drivers: thermal: int340x_thermal: Make PCI dependency explicit

 arch/x86/Kconfig                              | 2 +-
 drivers/acpi/Makefile                         | 3 ++-
 drivers/acpi/internal.h                       | 4 ++++
 drivers/ata/Kconfig                           | 2 +-
 drivers/gpu/vga/Kconfig                       | 1 +
 drivers/mmc/host/Kconfig                      | 2 +-
 drivers/platform/x86/Kconfig                  | 6 +++---
 drivers/thermal/intel/int340x_thermal/Kconfig | 4 ++--
 sound/soc/intel/Kconfig                       | 2 +-
 9 files changed, 16 insertions(+), 10 deletions(-)

Comments

Randy Dunlap Jan. 10, 2019, 9:47 p.m. UTC | #1
On 1/5/19 2:05 AM, Sinan Kaya wrote:
> This patchset fixes fallout of commit 5d32a66541c4 ("PCI/ACPI: Allow
> ACPI to be built without CONFIG_PCI set") which is part of Rafael's
> acpi pull for v4.21.
> 
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
> 
> Several drivers depend on PCI but do not call that out in their
> Kconfig. This causes linker and compilation errors when CONFIG_ACPI
> is set but CONFIG_PCI is unset.
> 
> Diff from v5:
> Refactor platform/x86: intel_ips and  platform/x86: apple-gmux per
> feedback from Andy.
> Collect acked-by and reviewed-by from Andy.

Hi,

Is this series being applied anywhere, hopefully soon?

linux-next is still having lots of build errors related to missing
these patches.

> Sinan Kaya (11):
>   ACPI / LPSS: Make PCI dependency explicit
>   ata: pata_acpi: Make PCI dependency explicit
>   vga-switcheroo: make PCI dependency explicit
>   platform/x86: intel_ips: make PCI dependency explicit
>   platform/x86: intel_pmc: Make PCI dependency explicit
>   platform/x86: apple-gmux: Make PCI dependency explicit
>   drivers: thermal: int3406_thermal: Make PCI dependency explicit
>   ASoC: Intel: atom: Make PCI dependency explicit
>   mmc: sdhci-acpi: Make PCI dependency explicit
>   x86/intel/lpss: Make PCI dependency explicit
>   drivers: thermal: int340x_thermal: Make PCI dependency explicit
> 
>  arch/x86/Kconfig                              | 2 +-
>  drivers/acpi/Makefile                         | 3 ++-
>  drivers/acpi/internal.h                       | 4 ++++
>  drivers/ata/Kconfig                           | 2 +-
>  drivers/gpu/vga/Kconfig                       | 1 +
>  drivers/mmc/host/Kconfig                      | 2 +-
>  drivers/platform/x86/Kconfig                  | 6 +++---
>  drivers/thermal/intel/int340x_thermal/Kconfig | 4 ++--
>  sound/soc/intel/Kconfig                       | 2 +-
>  9 files changed, 16 insertions(+), 10 deletions(-)
> 

thanks,
Rafael J. Wysocki Jan. 10, 2019, 9:52 p.m. UTC | #2
On Thu, Jan 10, 2019 at 10:47 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 1/5/19 2:05 AM, Sinan Kaya wrote:
> > This patchset fixes fallout of commit 5d32a66541c4 ("PCI/ACPI: Allow
> > ACPI to be built without CONFIG_PCI set") which is part of Rafael's
> > acpi pull for v4.21.
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly.
> >
> > Several drivers depend on PCI but do not call that out in their
> > Kconfig. This causes linker and compilation errors when CONFIG_ACPI
> > is set but CONFIG_PCI is unset.
> >
> > Diff from v5:
> > Refactor platform/x86: intel_ips and  platform/x86: apple-gmux per
> > feedback from Andy.
> > Collect acked-by and reviewed-by from Andy.
>
> Hi,
>
> Is this series being applied anywhere, hopefully soon?

Next week, if all goes well.
Rafael J. Wysocki Jan. 15, 2019, 6:42 p.m. UTC | #3
On Saturday, January 5, 2019 11:05:55 AM CET Sinan Kaya wrote:
> This patchset fixes fallout of commit 5d32a66541c4 ("PCI/ACPI: Allow
> ACPI to be built without CONFIG_PCI set") which is part of Rafael's
> acpi pull for v4.21.
> 
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
> 
> Several drivers depend on PCI but do not call that out in their
> Kconfig. This causes linker and compilation errors when CONFIG_ACPI
> is set but CONFIG_PCI is unset.
> 
> Diff from v5:
> Refactor platform/x86: intel_ips and  platform/x86: apple-gmux per
> feedback from Andy.
> Collect acked-by and reviewed-by from Andy.
> 
> Sinan Kaya (11):
>   ACPI / LPSS: Make PCI dependency explicit
>   ata: pata_acpi: Make PCI dependency explicit
>   vga-switcheroo: make PCI dependency explicit
>   platform/x86: intel_ips: make PCI dependency explicit
>   platform/x86: intel_pmc: Make PCI dependency explicit
>   platform/x86: apple-gmux: Make PCI dependency explicit
>   drivers: thermal: int3406_thermal: Make PCI dependency explicit
>   ASoC: Intel: atom: Make PCI dependency explicit
>   mmc: sdhci-acpi: Make PCI dependency explicit
>   x86/intel/lpss: Make PCI dependency explicit
>   drivers: thermal: int340x_thermal: Make PCI dependency explicit
> 
>  arch/x86/Kconfig                              | 2 +-
>  drivers/acpi/Makefile                         | 3 ++-
>  drivers/acpi/internal.h                       | 4 ++++
>  drivers/ata/Kconfig                           | 2 +-
>  drivers/gpu/vga/Kconfig                       | 1 +
>  drivers/mmc/host/Kconfig                      | 2 +-
>  drivers/platform/x86/Kconfig                  | 6 +++---
>  drivers/thermal/intel/int340x_thermal/Kconfig | 4 ++--
>  sound/soc/intel/Kconfig                       | 2 +-
>  9 files changed, 16 insertions(+), 10 deletions(-)

I have applied the patches from this series that have not been picked
up by other maintainers yet, expect for patch [7/11] that should not
be necessary according to the feedback received.

Thanks!