| Message ID | 20190119205121.9621-1-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: meson8b: fix typo "ABP" -> "APB" | expand |
On 19/01/2019 21:51, Martin Blumenstingl wrote: > It turns out that I'm not good at spelling "APB". Unfortunately an ABP > (instead of APB) typo snug into two clocks in v5.0. > > Currently there are no users of that clock yet, so fix it now > before it's too late (meaning before it's used by <something>). > > I decided to go the "normal" route where we can have separate > branches for the dt-bindings and the drivers in the clk-meson > repo. This means: > - new (typo-free) clock #define > - change the clock controller to use the new #define > - (next development cycle) drop the old #define > > > Changes since v1 at [0]: > - split into a dt-bindings and clock controller driver patch > > > [0] https://patchwork.kernel.org/cover/10742001/ > > > Martin Blumenstingl (2): > dt-bindings: clock: meson8b: add APB clock definition > clk: meson: meson8b: fix the naming of the APB clocks > > drivers/clk/meson/meson8b.c | 26 ++++++++++++------------ > drivers/clk/meson/meson8b.h | 2 +- > include/dt-bindings/clock/meson8b-clkc.h | 1 + > 3 files changed, 15 insertions(+), 14 deletions(-) > Once rob acks it, I'll apply both to next/drivers since it's not used (yet ?) and not a critical fix. Neil
Hi Neil, On Mon, Jan 21, 2019 at 11:40 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > On 19/01/2019 21:51, Martin Blumenstingl wrote: > > It turns out that I'm not good at spelling "APB". Unfortunately an ABP > > (instead of APB) typo snug into two clocks in v5.0. > > > > Currently there are no users of that clock yet, so fix it now > > before it's too late (meaning before it's used by <something>). > > > > I decided to go the "normal" route where we can have separate > > branches for the dt-bindings and the drivers in the clk-meson > > repo. This means: > > - new (typo-free) clock #define > > - change the clock controller to use the new #define > > - (next development cycle) drop the old #define > > > > > > Changes since v1 at [0]: > > - split into a dt-bindings and clock controller driver patch > > > > > > [0] https://patchwork.kernel.org/cover/10742001/ > > > > > > Martin Blumenstingl (2): > > dt-bindings: clock: meson8b: add APB clock definition > > clk: meson: meson8b: fix the naming of the APB clocks > > > > drivers/clk/meson/meson8b.c | 26 ++++++++++++------------ > > drivers/clk/meson/meson8b.h | 2 +- > > include/dt-bindings/clock/meson8b-clkc.h | 1 + > > 3 files changed, 15 insertions(+), 14 deletions(-) > > > > Once rob acks it, I'll apply both to next/drivers since it's not used (yet ?) > and not a critical fix. I have just noticed that I forgot to CC Rob and devicetree@vger.kernel.org. do you want me to re-send this series? as you already noticed this is not critical, so taking this through next/drivers is fine for me. Regards Martin
Hi Martin, Le 09/02/2019 01:24, Martin Blumenstingl a écrit : > Hi Neil, > > On Mon, Jan 21, 2019 at 11:40 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> On 19/01/2019 21:51, Martin Blumenstingl wrote: >>> It turns out that I'm not good at spelling "APB". Unfortunately an ABP >>> (instead of APB) typo snug into two clocks in v5.0. >>> >>> Currently there are no users of that clock yet, so fix it now >>> before it's too late (meaning before it's used by <something>). >>> >>> I decided to go the "normal" route where we can have separate >>> branches for the dt-bindings and the drivers in the clk-meson >>> repo. This means: >>> - new (typo-free) clock #define >>> - change the clock controller to use the new #define >>> - (next development cycle) drop the old #define >>> >>> >>> Changes since v1 at [0]: >>> - split into a dt-bindings and clock controller driver patch >>> >>> >>> [0] https://patchwork.kernel.org/cover/10742001/ >>> >>> >>> Martin Blumenstingl (2): >>> dt-bindings: clock: meson8b: add APB clock definition >>> clk: meson: meson8b: fix the naming of the APB clocks >>> >>> drivers/clk/meson/meson8b.c | 26 ++++++++++++------------ >>> drivers/clk/meson/meson8b.h | 2 +- >>> include/dt-bindings/clock/meson8b-clkc.h | 1 + >>> 3 files changed, 15 insertions(+), 14 deletions(-) >>> >> >> Once rob acks it, I'll apply both to next/drivers since it's not used (yet ?) >> and not a critical fix. > I have just noticed that I forgot to CC Rob and devicetree@vger.kernel.org. > do you want me to re-send this series? Yes please re-send ! Neil > > as you already noticed this is not critical, so taking this through > next/drivers is fine for me. > > > Regards > Martin >