mbox series

[0/5] ceph: proactively release used caps

Message ID 20190201142253.5478-1-zyan@redhat.com (mailing list archive)
Headers show
Series ceph: proactively release used caps | expand

Message

Yan, Zheng Feb. 1, 2019, 2:22 p.m. UTC 
This series makes cephfs kernel client proactively unused release caps.
The basic idea is trim stale dentries (have no valid leases). Trimming
dentries releases references to associated inodes, which may evict
inodes and release caps. For stale dentries, the cost of revalidating
is about the same as lookup. So trimming stale dentries should not have
big impact on performance.

Regards
Yan, Zheng

Comments

Jeff Layton Feb. 1, 2019, 3:09 p.m. UTC | #1 
On Fri, 2019-02-01 at 22:22 +0800, Yan, Zheng wrote:
> This series makes cephfs kernel client proactively unused release caps.
> The basic idea is trim stale dentries (have no valid leases). Trimming
> dentries releases references to associated inodes, which may evict
> inodes and release caps. For stale dentries, the cost of revalidating
> is about the same as lookup. So trimming stale dentries should not have
> big impact on performance.
> 
> Regards
> Yan, Zheng

Series looks good overall. There is one place where you're using RCU and
don't really need to. If you fix that up, you can add:

Reviewed-by: Jeff Layton <jlayton@redhat.com>