[00/21] nd/diff-parseopt part 2

Message

Duy Nguyen Feb. 7, 2019, 10:33 a.m. UTC

"What's cooking" mails seem to indicate that the series will be cooked
in full there then landed on master later. So here's the second part.
This continues to convert more diff options to parseopt.

Nguyễn Thái Ngọc Duy (21):
  diff.c: convert --patch-with-raw
  diff.c: convert --numstat and --shortstat
  diff.c: convert --dirstat and friends
  diff.c: convert --check
  diff.c: convert --summary
  diff.c: convert --patch-with-stat
  diff.c: convert --name-only
  diff.c: convert --name-status
  diff.c: convert -s|--no-patch
  diff.c: convert --stat*
  diff.c: convert --[no-]compact-summary
  diff.c: convert --output-*
  diff.c: convert -B|--break-rewrites
  diff.c: convert -M|--find-renames
  diff.c: convert -D|--irreversible-delete
  diff.c: convert -C|--find-copies
  diff.c: convert --find-copies-harder
  diff.c: convert --no-renames|--[no--rename-empty
  diff.c: convert --relative
  diff.c: convert --[no-]minimal
  diff.c: convert --ignore-some-changes

 Documentation/diff-options.txt |  20 ++
 diff.c                         | 510 +++++++++++++++++++--------------
 2 files changed, 319 insertions(+), 211 deletions(-)

Comments

SZEDER Gábor Feb. 7, 2019, 6:43 p.m. UTC | #1

On Thu, Feb 07, 2019 at 05:33:05PM +0700, Nguyễn Thái Ngọc Duy wrote:
> Nguyễn Thái Ngọc Duy (21):
>   diff.c: convert --patch-with-raw
>   diff.c: convert --numstat and --shortstat
>   diff.c: convert --dirstat and friends
>   diff.c: convert --check
>   diff.c: convert --summary
>   diff.c: convert --patch-with-stat
>   diff.c: convert --name-only
>   diff.c: convert --name-status
>   diff.c: convert -s|--no-patch
>   diff.c: convert --stat*
>   diff.c: convert --[no-]compact-summary
>   diff.c: convert --output-*
>   diff.c: convert -B|--break-rewrites
>   diff.c: convert -M|--find-renames
>   diff.c: convert -D|--irreversible-delete
>   diff.c: convert -C|--find-copies
>   diff.c: convert --find-copies-harder
>   diff.c: convert --no-renames|--[no--rename-empty
>   diff.c: convert --relative
>   diff.c: convert --[no-]minimal
>   diff.c: convert --ignore-some-changes

Nit: convert to what?  Perhaps a 's/$/ to parse-options/' would
improve the shortlog/oneline output.

Junio C Hamano Feb. 11, 2019, 5:12 p.m. UTC | #2

SZEDER Gábor <[e-mail]> writes:

> On Thu, Feb 07, 2019 at 05:33:05PM +0700, Nguyễn Thái Ngọc Duy wrote:
>> Nguyễn Thái Ngọc Duy (21):
>>   diff.c: convert --patch-with-raw
>>   diff.c: convert --numstat and --shortstat
>>   diff.c: convert --dirstat and friends
>>   diff.c: convert --check
>>   ...
>>   diff.c: convert --no-renames|--[no--rename-empty
>>   diff.c: convert --relative
>>   diff.c: convert --[no-]minimal
>>   diff.c: convert --ignore-some-changes
>
> Nit: convert to what?  Perhaps a 's/$/ to parse-options/' would
> improve the shortlog/oneline output.

But that would be hidden by getting pushed far to the right.

I am wondering if we can do something clever with the <area>: prefix.
For a series like this one, the shortlog output may be better off if
a short token that clearly identifies the topic is used there, e.g.

    diff-parseopt: convert --patch-with-raw
    diff-parseopt: convert --numstat and --shortstat
    ...

or even

    diff-parseopt: --patch-with-raw

perhaps.

Junio C Hamano Feb. 11, 2019, 6:35 p.m. UTC | #3

Nguyễn Thái Ngọc Duy  <[e-mail]> writes:

> "What's cooking" mails seem to indicate that the series will be cooked
> in full there then landed on master later. So here's the second part.

Ah, I should have responded to this part.

I think that the part 1 was reviewed and found reasonable, and we
could merge them to 'master'.  But because they themselves won't do
much good until completed, I'd rather refrain from including them in
a half-done form in the upcoming release.  In other words, do not be
surprised if you see these early part(s) land on 'master' before the
remainder after the upcoming release.

Thanks.