[0/10] dropping more unused function parameters
mbox series

Message ID 20190214054736.GA20091@sigill.intra.peff.net
Headers show
Series
  • dropping more unused function parameters
Related show

Message

Jeff King Feb. 14, 2019, 5:47 a.m. UTC
Here are ten more patches from my exploration of -Wunused-parameters.
Most of these are quite old and not urgent, but things seem relatively
quiet now, and they all merge cleanly with "pu".

In a sense they should all be trivial to review, as they only remove
unused parameters. But the thing to consider is whether that parameter's
lack of use is actually a bug, or if it's simply cruft (and I argue in
each case in favor of cruft).

  [01/10]: diff: drop options parameter from diffcore_fix_diff_index()
  [02/10]: diff: drop unused color reset parameters
  [03/10]: diff: drop unused emit data parameter from sane_truncate_line()
  [04/10]: diff: drop complete_rewrite parameter from run_external_diff()
  [05/10]: merge-recursive: drop several unused parameters
  [06/10]: pack-objects: drop unused parameter from oe_map_new_pack()
  [07/10]: files-backend: drop refs parameter from split_symref_update()
  [08/10]: ref-filter: drop unused buf/sz pairs
  [09/10]: ref-filter: drop unused "obj" parameters
  [10/10]: ref-filter: drop unused "sz" parameters

 diff-lib.c           |  2 +-
 diff.c               | 31 ++++++++++++-------------------
 diff.h               |  2 +-
 merge-recursive.c    | 19 +++++++------------
 pack-objects.c       |  3 +--
 pack-objects.h       |  6 +++---
 ref-filter.c         | 36 ++++++++++++++++++------------------
 refs/files-backend.c |  5 ++---
 8 files changed, 45 insertions(+), 59 deletions(-)

-Peff