[V2,0/8] nvme: misc cleanups
mbox series

Message ID 20190221044248.11096-1-chaitanya.kulkarni@wdc.com
Headers show
Series
  • nvme: misc cleanups
Related show

Message

Chaitanya Kulkarni Feb. 21, 2019, 4:42 a.m. UTC
Hi Omar,
This is a small patch series which follows the blktests coding
style format as pointed out by Bart. Also minimizes the overall
code for the review.

-Regards,
Chaitanya

Changes since V1:-
1. Add testcase specific error message on failure.

Chaitanya Kulkarni (8):
  nvme/021: use consistent coding style
  nvme/022: use consistent coding style
  nvme/023: use consistent coding style
  nvme/024: use consistent coding style
  nvme/025: use consistent coding style
  nvme/026: use consistent coding style
  nvme/027: use consistent coding style
  nvme/028: use consistent coding style

 tests/nvme/021     | 14 +++++---------
 tests/nvme/021.out |  1 -
 tests/nvme/022     | 14 +++++---------
 tests/nvme/022.out |  1 -
 tests/nvme/023     | 14 +++++---------
 tests/nvme/023.out |  1 -
 tests/nvme/024     | 15 +++++----------
 tests/nvme/024.out |  1 -
 tests/nvme/025     | 14 +++++---------
 tests/nvme/025.out |  1 -
 tests/nvme/026     | 14 +++++---------
 tests/nvme/026.out |  1 -
 tests/nvme/027     | 15 +++++----------
 tests/nvme/027.out |  1 -
 tests/nvme/028     | 15 +++++----------
 tests/nvme/028.out |  1 -
 16 files changed, 40 insertions(+), 83 deletions(-)

Comments

Omar Sandoval Feb. 27, 2019, 6:50 p.m. UTC | #1
On Wed, Feb 20, 2019 at 08:42:40PM -0800, Chaitanya Kulkarni wrote:
> Hi Omar,
> This is a small patch series which follows the blktests coding
> style format as pointed out by Bart. Also minimizes the overall
> code for the review.
> 
> -Regards,
> Chaitanya
> 
> Changes since V1:-
> 1. Add testcase specific error message on failure.

I also made these redirect to $FULL instead of /dev/null. The result is
pushed to https://github.com/osandov/blktests/commits/nvme-cleanups,
could you take a quick look?

Also, I assume I can add your signed-off-by to all of these commits?
Chaitanya Kulkarni March 1, 2019, 3:59 p.m. UTC | #2
Hi Omar,

Everything looks good. 

On 2/27/19, 1:50 PM, "Omar Sandoval" <osandov@osandov.com> wrote:

    On Wed, Feb 20, 2019 at 08:42:40PM -0800, Chaitanya Kulkarni wrote:
    > Hi Omar,
    > This is a small patch series which follows the blktests coding
    > style format as pointed out by Bart. Also minimizes the overall
    > code for the review.
    > 
    > -Regards,
    > Chaitanya
    > 
    > Changes since V1:-
    > 1. Add testcase specific error message on failure.
    
    I also made these redirect to $FULL instead of /dev/null. The result is
    pushed to https://github.com/osandov/blktests/commits/nvme-cleanups,
    could you take a quick look?
    
    Also, I assume I can add your signed-off-by to all of these commits?
Yes, feel free to add that.
Omar Sandoval March 4, 2019, 7:10 p.m. UTC | #3
On Fri, Mar 01, 2019 at 03:59:53PM +0000, Chaitanya Kulkarni wrote:
> Hi Omar,
> 
> Everything looks good. 
> 
> On 2/27/19, 1:50 PM, "Omar Sandoval" <osandov@osandov.com> wrote:
> 
>     On Wed, Feb 20, 2019 at 08:42:40PM -0800, Chaitanya Kulkarni wrote:
>     > Hi Omar,
>     > This is a small patch series which follows the blktests coding
>     > style format as pointed out by Bart. Also minimizes the overall
>     > code for the review.
>     > 
>     > -Regards,
>     > Chaitanya
>     > 
>     > Changes since V1:-
>     > 1. Add testcase specific error message on failure.
>     
>     I also made these redirect to $FULL instead of /dev/null. The result is
>     pushed to https://github.com/osandov/blktests/commits/nvme-cleanups,
>     could you take a quick look?
>     
>     Also, I assume I can add your signed-off-by to all of these commits?
> Yes, feel free to add that.

Thanks, merged.