[WIP,RFC,v2,0/5] clone: dir iterator refactoring with tests
mbox series

Message ID 20190226051804.10631-1-matheus.bernardino@usp.br
Headers show
Series
  • clone: dir iterator refactoring with tests
Related show

Message

Matheus Tavares Bernardino Feb. 26, 2019, 5:17 a.m. UTC
Ævar sent v1: https://public-inbox.org/git/20190226002625.13022-1-avarab@gmail.com/

Based on Ævar's work and comments, I refactored my previous series[1],
so that clone's original behaviour regarding symlinks is kept untouched.
So, keeping this behaviour, having tests for this, changing local clone
to use dir-iterator's API and modifing hidden paths behaviour (which we
agreed to seem like unintentional), I think this version addresses all
the comments and concerns raised in this thread:
https://public-inbox.org/git/CAP8UFD2xrfMHNxcmeYf8G+d53SL26N07FFAoDP+e0h3r-tvKQw@mail.gmail.com/
And also addresses the comments I made in WIP's v1.

[1]: https://public-inbox.org/git/20190223190309.6728-1-matheus.bernardino@usp.br/

Matheus Tavares (4):
  dir-iterator: add flags parameter to dir_iterator_begin
  clone: copy hidden paths at local clone
  clone: extract function from copy_or_link_directory
  clone: use dir-iterator to avoid explicit dir traversal

Ævar Arnfjörð Bjarmason (1):
  clone: test for our behavior on odd objects/* content

 builtin/clone.c            | 70 ++++++++++++++++++++++----------------
 dir-iterator.c             | 28 +++++++++++++--
 dir-iterator.h             | 40 +++++++++++++++++-----
 refs/files-backend.c       |  2 +-
 t/t5604-clone-reference.sh | 69 +++++++++++++++++++++++++++++++++++++
 5 files changed, 168 insertions(+), 41 deletions(-)

Comments

Ævar Arnfjörð Bjarmason Feb. 26, 2019, 11:36 a.m. UTC | #1
On Tue, Feb 26 2019, Matheus Tavares wrote:

> Ævar sent v1: https://public-inbox.org/git/20190226002625.13022-1-avarab@gmail.com/

Tip. Use --in-reply-to with git format-patch, then the whole discussion
goes in the same thread on the ML.
Duy Nguyen Feb. 26, 2019, 12:20 p.m. UTC | #2
On Tue, Feb 26, 2019 at 6:36 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
>
> On Tue, Feb 26 2019, Matheus Tavares wrote:
>
> > Ævar sent v1: https://public-inbox.org/git/20190226002625.13022-1-avarab@gmail.com/
>
> Tip. Use --in-reply-to with git format-patch, then the whole discussion
> goes in the same thread on the ML.

Better tip. Click on v1 link, look for the "reply" link, click it and
copy the whole format-patch command :D