mbox series

[00/10] drm/i915: Clean up intel_color_check()

Message ID 20190318161317.30918-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Clean up intel_color_check() | expand

Message

Ville Syrjälä March 18, 2019, 4:13 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

intel_color_check() is mess. Blow it up into clean platform sized
chunks. Also eliminate some redundant linear LUT loads as a result.

Ville Syrjälä (10):
  drm/i915: Extract check_luts()
  drm/i915: Turn intel_color_check() into a vfunc
  drm/i915: Extract i9xx_color_check()
  drm/i915: Extract chv_color_check()
  drm/i915: Extract icl_color_check()
  drm/i915: Extract glk_color_check()
  drm/i915: Extract bdw_color_check()
  drm/i915: Extract ilk_color_check()
  drm/i915: Drop the pointless linear legacy LUT load on CHV
  drm/i915: Skip the linear degamma LUT load on ICL+

 drivers/gpu/drm/i915/i915_drv.h    |   1 +
 drivers/gpu/drm/i915/intel_color.c | 384 +++++++++++++++++++++--------
 2 files changed, 286 insertions(+), 99 deletions(-)

Comments

Jani Nikula March 19, 2019, 4:26 p.m. UTC | #1 
On Mon, 18 Mar 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_color_check() is mess. Blow it up into clean platform sized
> chunks. Also eliminate some redundant linear LUT loads as a result.

How about a "load lut" -> "write lut" rename while at it? I think
"loading" is confusing.

BR,
Jani.


>
> Ville Syrjälä (10):
>   drm/i915: Extract check_luts()
>   drm/i915: Turn intel_color_check() into a vfunc
>   drm/i915: Extract i9xx_color_check()
>   drm/i915: Extract chv_color_check()
>   drm/i915: Extract icl_color_check()
>   drm/i915: Extract glk_color_check()
>   drm/i915: Extract bdw_color_check()
>   drm/i915: Extract ilk_color_check()
>   drm/i915: Drop the pointless linear legacy LUT load on CHV
>   drm/i915: Skip the linear degamma LUT load on ICL+
>
>  drivers/gpu/drm/i915/i915_drv.h    |   1 +
>  drivers/gpu/drm/i915/intel_color.c | 384 +++++++++++++++++++++--------
>  2 files changed, 286 insertions(+), 99 deletions(-)
Ville Syrjälä March 19, 2019, 4:31 p.m. UTC | #2 
On Tue, Mar 19, 2019 at 06:26:43PM +0200, Jani Nikula wrote:
> On Mon, 18 Mar 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > intel_color_check() is mess. Blow it up into clean platform sized
> > chunks. Also eliminate some redundant linear LUT loads as a result.
> 
> How about a "load lut" -> "write lut" rename while at it? I think
> "loading" is confusing.

Should probably rename it something a bit more generic since vlv/chv
load the csc there too. .color_update_postvbl() or something, though
I'm not sure that shade really makes me happy either.

> 
> BR,
> Jani.
> 
> 
> >
> > Ville Syrjälä (10):
> >   drm/i915: Extract check_luts()
> >   drm/i915: Turn intel_color_check() into a vfunc
> >   drm/i915: Extract i9xx_color_check()
> >   drm/i915: Extract chv_color_check()
> >   drm/i915: Extract icl_color_check()
> >   drm/i915: Extract glk_color_check()
> >   drm/i915: Extract bdw_color_check()
> >   drm/i915: Extract ilk_color_check()
> >   drm/i915: Drop the pointless linear legacy LUT load on CHV
> >   drm/i915: Skip the linear degamma LUT load on ICL+
> >
> >  drivers/gpu/drm/i915/i915_drv.h    |   1 +
> >  drivers/gpu/drm/i915/intel_color.c | 384 +++++++++++++++++++++--------
> >  2 files changed, 286 insertions(+), 99 deletions(-)
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center