[0/7] ceph: various cleanups in MDS requests

Message

Jeffrey Layton April 15, 2019, 6:33 p.m. UTC

This patchset is set of cleanups for the MDS request handling code.
These are mostly intended to allow us to do async MDS requests in the
future, but I think they make sense in their own right for v5.2.

There are also a couple of cleanups to the cap tracking code as well.

Jeff Layton (7):
  ceph: after an MDS request, do callback and completions
  ceph: have ceph_mdsc_do_request call ceph_mdsc_submit_request
  ceph: move wait for mds request into helper function
  ceph: hold extra reference to r_parent over life of request
  ceph: fix comment over ceph_drop_caps_for_unlink
  ceph: simplify arguments and return semantics of try_get_cap_refs
  ceph: register MDS request with dir inode from the get-go

 fs/ceph/caps.c       | 78 +++++++++++++++++-------------------------
 fs/ceph/mds_client.c | 81 +++++++++++++++++++++++---------------------
 fs/ceph/mds_client.h |  5 +--
 3 files changed, 76 insertions(+), 88 deletions(-)

Comments

Yan, Zheng April 16, 2019, 2:39 a.m. UTC | #1

On Tue, Apr 16, 2019 at 2:36 AM Jeff Layton <[e-mail]> wrote:
>
> This patchset is set of cleanups for the MDS request handling code.
> These are mostly intended to allow us to do async MDS requests in the
> future, but I think they make sense in their own right for v5.2.
>
> There are also a couple of cleanups to the cap tracking code as well.
>
> Jeff Layton (7):
>   ceph: after an MDS request, do callback and completions
>   ceph: have ceph_mdsc_do_request call ceph_mdsc_submit_request
>   ceph: move wait for mds request into helper function
>   ceph: hold extra reference to r_parent over life of request
>   ceph: fix comment over ceph_drop_caps_for_unlink
>   ceph: simplify arguments and return semantics of try_get_cap_refs
>   ceph: register MDS request with dir inode from the get-go
>
>  fs/ceph/caps.c       | 78 +++++++++++++++++-------------------------
>  fs/ceph/mds_client.c | 81 +++++++++++++++++++++++---------------------
>  fs/ceph/mds_client.h |  5 +--
>  3 files changed, 76 insertions(+), 88 deletions(-)
>

Patch 4 and patch 7 are for the buffered unlink/create work. how about
not pushing them to upstream for now. The rest patches look good.

Regards
Yan, Zheng

> --
> 2.20.1
>