[v3,0/5] ceph: add snapshot creation time vxattr
mbox series

Message ID 20190418121549.30128-1-ddiss@suse.de
Headers show
Series
  • ceph: add snapshot creation time vxattr
Related show

Message

David Disseldorp April 18, 2019, 12:15 p.m. UTC
This patchset adds a "ceph.snap.btime" vxattr to snapshot files and
directories, when run alongside an MDS that provides InodeStat v3
information as implemented in https://github.com/ceph/ceph/pull/27077 .

Changes since v2:
- fix ceph_vxattrcb_snap_btime_exists()

Changes since v1:
- add fix for listxattr vxattr buffer length calculations
  + this bug caused breakage for non-hidden exists_cb() vxattrs
- rebase against current mainline

----------------------------------------------------------------
David Disseldorp (5):
      ceph: clean up ceph.dir.pin vxattr name sizeof()
      ceph: carry snapshot creation time with inodes
      ceph: add ceph.snap.btime vxattr
      ceph: fix listxattr vxattr buffer length calculation
      ceph: remove unused vxattr length helpers

 fs/ceph/inode.c      |   1 +
 fs/ceph/mds_client.c |   8 +++
 fs/ceph/mds_client.h |   1 +
 fs/ceph/super.c      |   7 +--
 fs/ceph/super.h      |   3 +-
 fs/ceph/xattr.c      | 126 ++++++++++++++++++++-----------------------
 6 files changed, 71 insertions(+), 75 deletions(-)

Comments

Yan, Zheng April 23, 2019, 1:58 a.m. UTC | #1
On Thu, Apr 18, 2019 at 8:16 PM David Disseldorp <ddiss@suse.de> wrote:
>
> This patchset adds a "ceph.snap.btime" vxattr to snapshot files and
> directories, when run alongside an MDS that provides InodeStat v3
> information as implemented in https://github.com/ceph/ceph/pull/27077 .
>
> Changes since v2:
> - fix ceph_vxattrcb_snap_btime_exists()
>
> Changes since v1:
> - add fix for listxattr vxattr buffer length calculations
>   + this bug caused breakage for non-hidden exists_cb() vxattrs
> - rebase against current mainline
>
> ----------------------------------------------------------------
> David Disseldorp (5):
>       ceph: clean up ceph.dir.pin vxattr name sizeof()
>       ceph: carry snapshot creation time with inodes
>       ceph: add ceph.snap.btime vxattr
>       ceph: fix listxattr vxattr buffer length calculation
>       ceph: remove unused vxattr length helpers
>
>  fs/ceph/inode.c      |   1 +
>  fs/ceph/mds_client.c |   8 +++
>  fs/ceph/mds_client.h |   1 +
>  fs/ceph/super.c      |   7 +--
>  fs/ceph/super.h      |   3 +-
>  fs/ceph/xattr.c      | 126 ++++++++++++++++++++-----------------------
>  6 files changed, 71 insertions(+), 75 deletions(-)

Looks good. I will add it to testing branch once user space RP get merged.

Yan, Zheng