mbox series

[v2,0/2] thermal: rcar_gen3_thermal: fix IRQ issues

Message ID 20190423061218.29705-1-jiada_wang@mentor.com (mailing list archive)
Headers show
Series thermal: rcar_gen3_thermal: fix IRQ issues | expand

Message

Wang, Jiada April 23, 2019, 6:12 a.m. UTC 
There are issues with interrupt handling in rcar_gen3_thermal driver.

Currently IRQ is remain enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
triggered but not able to clear IRQ status, thus cause system to hang.

Since the irq line isn't shared between different devices,
so the proper interrupt type flag should be IRQF_ONESHOT.

This patch-set fix these interrupt handling retated issues. 

---
v2: use irq type IRQF_ONESHOT instead of IRQF_SHARED
    disable interrupt in .remove

v1: initial version

Jiada Wang (2):
  thermal: rcar_gen3_thermal: fix interrupt type
  thermal: rcar_gen3_thermal: disable interrupt in .remove

 drivers/thermal/rcar_gen3_thermal.c | 43 +++++++++--------------------
 1 file changed, 13 insertions(+), 30 deletions(-)