[v10,00/12] Add HDR Metadata Parsing and handling in DRM layer
mbox series

Message ID 1557855394-12214-1-git-send-email-uma.shankar@intel.com
Headers show
Series
  • Add HDR Metadata Parsing and handling in DRM layer
Related show

Message

Shankar, Uma May 14, 2019, 5:36 p.m. UTC
This patch series enables HDR support in drm. It basically defines
HDR metadata structures, property to pass content (after blending)
metadata from user space compositors to driver.

Dynamic Range and Mastering infoframe creation and sending.

ToDo:
1. We need to get the color framework in place for all planes
   which support HDR content in hardware. This is already in progres
   and patches are out for review in mailing list.
2. UserSpace/Compositors: Blending policies and metadata blob
   creation and passing to driver. Work is already in progress
   by Intel's middleware teams on wayland and the patches for
   the same are in review.

A POC has already been developed by Ville based on wayland. Please refer
below link to see the component interactions and usage:
https://lists.freedesktop.org/archives/wayland-devel/2017-December/036403.html

v2: Updated Ville's POC changes to the patch series.Incorporated cleanups
and fixes from Ville. Rebase on latest drm-tip.

v3: Fixed a warning causing builds to break on CI. No major change.

v4: Addressed Shashank's review comments.

v5: Rebase on top of Ville's infoframe refactoring changes. Fixed non modeset
case for HDR metadata update. Dropped a redundant patch.

v6: Addressed Shashank's review comments and added RB's received.

v7: Squashed 2 patches, dropped 1 change and addressed Brian Starkey's and
Shashank's review comments.

v8: Addressed Jonas Karlman review comments. Added Shashank's RB to the series,
fixed a WARN_ON on BYT/CHT.

v9: Addressed Ville and Jonas Karlman's review comments. Added the infoframe
state readout and metadata reference count.

v10: Addressed review comments from Jonas and Ville. Dropped one patch related
to i915 fastset handling as per Ville's feedback.

Note: v9 version is already tested with Kodi and a confirmation from team kodi has been
received. Branch details for the same as below:
https://github.com/xbmc/xbmc/tree/feature_drmprime-vaapi

v9 of this series is:
Tested-by: Jonas Karlman <jonas@kwiboo.se>

Jonas Karlman (1):
  drm: Add reference counting on HDR metadata blob

Uma Shankar (9):
  drm: Add HDR source metadata property
  drm: Parse HDR metadata info from EDID
  drm: Enable HDR infoframe support
  drm/i915: Attach HDR metadata property to connector
  drm/i915: Write HDR infoframe and send to panel
  drm/i915:Enabled Modeset when HDR Infoframe changes
  drm/i915: Added DRM Infoframe handling for BYT/CHT
  video/hdmi: Add Unpack function for DRM infoframe
  drm/i915: Add state readout for DRM infoframe

Ville Syrjälä (2):
  drm: Add HLG EOTF
  drm/i915: Enable infoframes on GLK+ for HDR

 drivers/gpu/drm/drm_atomic.c              |   2 +
 drivers/gpu/drm/drm_atomic_state_helper.c |   6 +
 drivers/gpu/drm/drm_atomic_uapi.c         |  13 ++
 drivers/gpu/drm/drm_connector.c           |   6 +
 drivers/gpu/drm/drm_edid.c                |  93 +++++++++++
 drivers/gpu/drm/i915/i915_reg.h           |   4 +
 drivers/gpu/drm/i915/intel_atomic.c       |  14 +-
 drivers/gpu/drm/i915/intel_ddi.c          |   4 +
 drivers/gpu/drm/i915/intel_display.c      |   1 +
 drivers/gpu/drm/i915/intel_drv.h          |   1 +
 drivers/gpu/drm/i915/intel_hdmi.c         |  83 +++++++++-
 drivers/video/hdmi.c                      | 257 ++++++++++++++++++++++++++++++
 include/drm/drm_connector.h               |  11 ++
 include/drm/drm_edid.h                    |   5 +
 include/drm/drm_mode_config.h             |   7 +
 include/linux/hdmi.h                      |  55 +++++++
 include/uapi/drm/drm_mode.h               |  23 +++
 17 files changed, 580 insertions(+), 5 deletions(-)

Comments

Shankar, Uma May 15, 2019, 8:59 a.m. UTC | #1
>-----Original Message-----
>From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>Sent: Wednesday, May 15, 2019 6:54 AM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: intel-gfx@lists.freedesktop.org
>Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer
>(rev10)
>
>== Series Details ==
>
>Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>URL   : https://patchwork.freedesktop.org/series/25091/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_13017_full absolutely need to be
>  verified manually.
>
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_13017_full, please notify your bug team to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in
>Patchwork_13017_full:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@gem_exec_suspend@basic-s3:
>    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@gem_exec_suspend@basic-s3.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@gem_exec_suspend@basic-s3.html
>
>  * igt@kms_prop_blob@invalid-set-prop-any:
>    - shard-iclb:         [PASS][3] -> [FAIL][4]
>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>

Hi Martin,
These issues are unrelated to the changes made in this series. Can you please have a look
and confirm.

Regards,
Uma Shankar

>#### Warnings ####
>
>  * igt@gem_mocs_settings@mocs-settings-ctx-dirty-render:
>    - shard-iclb:         [SKIP][5] ([fdo#110206]) -> [SKIP][6]
>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@gem_mocs_settings@mocs-settings-ctx-dirty-render.html
>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@gem_mocs_settings@mocs-settings-ctx-dirty-render.html
>
>  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
>    - shard-iclb:         [SKIP][7] ([fdo#109278]) -> [SKIP][8] +1 similar issue
>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html
>   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html
>
>  * igt@kms_chamelium@hdmi-crc-abgr8888:
>    - shard-iclb:         [SKIP][9] ([fdo#109284]) -> [SKIP][10]
>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_chamelium@hdmi-crc-abgr8888.html
>   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_chamelium@hdmi-crc-abgr8888.html
>
>  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
>    - shard-iclb:         [SKIP][11] ([fdo#109280]) -> [SKIP][12] +6 similar issues
>   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html
>   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html
>
>
>#### Suppressed ####
>
>  The following results come from untrusted machines, tests, or statuses.
>  They do not affect the overall result.
>
>  * {igt@gem_exec_schedule@semaphore-resolve}:
>    - shard-iclb:         [FAIL][13] ([fdo#110519]) -> [SKIP][14]
>   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@gem_exec_schedule@semaphore-resolve.html
>   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@gem_exec_schedule@semaphore-resolve.html
>
>  * {igt@kms_cursor_crc@pipe-b-cursor-64x21-random}:
>    - shard-iclb:         [PASS][15] -> [SKIP][16] +2 similar issues
>   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
>   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
>
>
>Known issues
>------------
>
>  Here are the changes found in Patchwork_13017_full that come from known issues:
>
>### IGT changes ###
>
>#### Issues hit ####
>
>  * igt@gem_eio@in-flight-suspend:
>    - shard-apl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +3 similar issues
>   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>apl5/igt@gem_eio@in-flight-suspend.html
>   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>apl3/igt@gem_eio@in-flight-suspend.html
>
>  * igt@kms_draw_crc@fill-fb:
>    - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#103184])
>   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl1/igt@kms_draw_crc@fill-fb.html
>   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl8/igt@kms_draw_crc@fill-fb.html
>
>  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>    - shard-glk:          [PASS][21] -> [FAIL][22] ([fdo#102887] / [fdo#105363])
>   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>
>  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
>    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +5 similar issues
>   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
>   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
>
>  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>    - shard-skl:          [PASS][25] -> [FAIL][26] ([fdo#108145])
>   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>
>  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
>    - shard-iclb:         [PASS][27] -> [FAIL][28] ([fdo#109052])
>   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
>   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
>
>  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>    - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#108145] / [fdo#110403])
>   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
>   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
>
>  * igt@kms_psr2_su@frontbuffer:
>    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109642])
>   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb2/igt@kms_psr2_su@frontbuffer.html
>   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb7/igt@kms_psr2_su@frontbuffer.html
>
>  * igt@kms_psr@psr2_cursor_plane_onoff:
>    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109441]) +4 similar issues
>   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
>   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
>
>  * igt@kms_setmode@basic:
>    - shard-kbl:          [PASS][35] -> [FAIL][36] ([fdo#99912])
>   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>kbl6/igt@kms_setmode@basic.html
>   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>kbl6/igt@kms_setmode@basic.html
>
>  * igt@kms_sysfs_edid_timing:
>    - shard-iclb:         [PASS][37] -> [FAIL][38] ([fdo#100047])
>   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb7/igt@kms_sysfs_edid_timing.html
>   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb2/igt@kms_sysfs_edid_timing.html
>
>
>#### Possible fixes ####
>
>  * igt@gem_mmap_gtt@forked-medium-copy-xy:
>    - shard-iclb:         [TIMEOUT][39] ([fdo#109673]) -> [PASS][40]
>   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@gem_mmap_gtt@forked-medium-copy-xy.html
>   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb6/igt@gem_mmap_gtt@forked-medium-copy-xy.html
>
>  * igt@gem_softpin@noreloc-s3:
>    - shard-skl:          [INCOMPLETE][41] ([fdo#104108] / [fdo#107773]) -> [PASS][42]
>   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl2/igt@gem_softpin@noreloc-s3.html
>   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl7/igt@gem_softpin@noreloc-s3.html
>
>  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
>    - shard-skl:          [INCOMPLETE][43] ([fdo#107807]) -> [PASS][44] +2 similar issues
>   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
>   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl9/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
>
>  * igt@kms_color@pipe-c-ctm-red-to-blue:
>    - shard-skl:          [FAIL][45] ([fdo#107201]) -> [PASS][46]
>   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl5/igt@kms_color@pipe-c-ctm-red-to-blue.html
>   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl2/igt@kms_color@pipe-c-ctm-red-to-blue.html
>
>  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
>    - shard-iclb:         [FAIL][47] ([fdo#103167]) -> [PASS][48] +6 similar issues
>   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
>   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
>
>  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
>    - shard-iclb:         [SKIP][49] -> [PASS][50] +40 similar issues
>   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-
>cpu.html
>   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-
>cpu.html
>
>  * igt@kms_frontbuffer_tracking@psr-suspend:
>    - shard-skl:          [INCOMPLETE][51] ([fdo#104108] / [fdo#106978]) -> [PASS][52]
>   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
>   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
>
>  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>    - shard-skl:          [FAIL][53] ([fdo#108145]) -> [PASS][54]
>   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>
>  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
>    - shard-iclb:         [SKIP][55] ([fdo#109278]) -> [PASS][56]
>   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
>   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
>
>  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
>    - shard-apl:          [DMESG-WARN][57] ([fdo#108566]) -> [PASS][58] +6 similar issues
>   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
>   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
>
>
>#### Warnings ####
>
>  * igt@gem_mmap_gtt@forked-big-copy-odd:
>    - shard-iclb:         [TIMEOUT][59] ([fdo#109673]) -> [INCOMPLETE][60]
>([fdo#107713] / [fdo#109100])
>   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb1/igt@gem_mmap_gtt@forked-big-copy-odd.html
>   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb8/igt@gem_mmap_gtt@forked-big-copy-odd.html
>
>  * igt@i915_pm_lpsp@edp-native:
>    - shard-iclb:         [SKIP][61] -> [SKIP][62] ([fdo#109301])
>   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@i915_pm_lpsp@edp-native.html
>   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@i915_pm_lpsp@edp-native.html
>
>  * igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
>    - shard-iclb:         [SKIP][63] -> [SKIP][64] ([fdo#109278]) +1 similar issue
>   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing.html
>   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing.html
>
>  * igt@kms_chamelium@hdmi-hpd-storm-disable:
>    - shard-iclb:         [SKIP][65] -> [SKIP][66] ([fdo#109284])
>   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_chamelium@hdmi-hpd-storm-disable.html
>   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_chamelium@hdmi-hpd-storm-disable.html
>
>  * igt@kms_flip@2x-dpms-vs-vblank-race:
>    - shard-iclb:         [SKIP][67] -> [SKIP][68] ([fdo#109274]) +1 similar issue
>   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_flip@2x-dpms-vs-vblank-race.html
>   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_flip@2x-dpms-vs-vblank-race.html
>
>  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt:
>    - shard-iclb:         [SKIP][69] -> [SKIP][70] ([fdo#109280]) +5 similar issues
>   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html
>   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html
>
>  * igt@kms_psr@psr2_sprite_blt:
>    - shard-iclb:         [SKIP][71] -> [SKIP][72] ([fdo#109441]) +1 similar issue
>   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>iclb8/igt@kms_psr@psr2_sprite_blt.html
>   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>iclb5/igt@kms_psr@psr2_sprite_blt.html
>
>
>  {name}: This element is suppressed. This means it is ignored when computing
>          the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
>  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
>  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
>  [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201
>  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>  [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
>  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
>  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>  [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
>  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
>  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
>  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
>  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
>  [fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
>  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
>  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
>  [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
>  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>  [fdo#110519]: https://bugs.freedesktop.org/show_bug.cgi?id=110519
>  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
>Participating hosts (10 -> 10)
>------------------------------
>
>  No changes in participating hosts
>
>
>Build changes
>-------------
>
>  * Linux: CI_DRM_6081 -> Patchwork_13017
>
>  CI_DRM_6081: 871d8bc4020bef25e14ea242cf5e73d3372f1f49 @
>git://anongit.freedesktop.org/gfx-ci/linux
>  IGT_4988: 2f6303d13e09b2457762540383c7f36cecd02bbf @
>git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>  Patchwork_13017: 419f1f1aa013ca1e5da1c5cc97dfb97fe9860d82 @
>git://anongit.freedesktop.org/gfx-ci/linux
>  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
>git://anongit.freedesktop.org/piglit
>
>== Logs ==
>
>For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/
Saarinen, Jani May 15, 2019, 10:34 a.m. UTC | #2
+ Martin for real. 

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
> Shankar, Uma
> Sent: keskiviikko 15. toukokuuta 2019 12.00
> To: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
> handling in DRM layer (rev10)
> 
> 
> 
> >-----Original Message-----
> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> >Sent: Wednesday, May 15, 2019 6:54 AM
> >To: Shankar, Uma <uma.shankar@intel.com>
> >Cc: intel-gfx@lists.freedesktop.org
> >Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling
> >in DRM layer
> >(rev10)
> >
> >== Series Details ==
> >
> >Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
> >URL   : https://patchwork.freedesktop.org/series/25091/
> >State : failure
> >
> >== Summary ==
> >
> >CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
> >====================================================
> >
> >Summary
> >-------
> >
> >  **FAILURE**
> >
> >  Serious unknown changes coming with Patchwork_13017_full absolutely
> > need to be  verified manually.
> >
> >  If you think the reported changes have nothing to do with the changes
> > introduced in Patchwork_13017_full, please notify your bug team to
> > allow them  to document this new failure mode, which will reduce false positives in
> CI.
> >
> >
> >
> >Possible new issues
> >-------------------
> >
> >  Here are the unknown changes that may have been introduced in
> >Patchwork_13017_full:
> >
> >### IGT changes ###
> >
> >#### Possible regressions ####
> >
> >  * igt@gem_exec_suspend@basic-s3:
> >    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
> >   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@gem_exec_suspend@basic-s3.html
> >   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@gem_exec_suspend@basic-s3.html
> >
> >  * igt@kms_prop_blob@invalid-set-prop-any:
> >    - shard-iclb:         [PASS][3] -> [FAIL][4]
> >   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
> >   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
> >
> 
> Hi Martin,
> These issues are unrelated to the changes made in this series. Can you please have a
> look and confirm.
> 
> Regards,
> Uma Shankar
> 
> >#### Warnings ####
> >
> >  * igt@gem_mocs_settings@mocs-settings-ctx-dirty-render:
> >    - shard-iclb:         [SKIP][5] ([fdo#110206]) -> [SKIP][6]
> >   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@gem_mocs_settings@mocs-settings-ctx-dirty-render.html
> >   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@gem_mocs_settings@mocs-settings-ctx-dirty-render.html
> >
> >  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
> >    - shard-iclb:         [SKIP][7] ([fdo#109278]) -> [SKIP][8] +1 similar issue
> >   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html
> >   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html
> >
> >  * igt@kms_chamelium@hdmi-crc-abgr8888:
> >    - shard-iclb:         [SKIP][9] ([fdo#109284]) -> [SKIP][10]
> >   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_chamelium@hdmi-crc-abgr8888.html
> >   [10]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_chamelium@hdmi-crc-abgr8888.html
> >
> >  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
> >    - shard-iclb:         [SKIP][11] ([fdo#109280]) -> [SKIP][12] +6 similar issues
> >   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html
> >   [12]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.h
> >tml
> >
> >
> >#### Suppressed ####
> >
> >  The following results come from untrusted machines, tests, or statuses.
> >  They do not affect the overall result.
> >
> >  * {igt@gem_exec_schedule@semaphore-resolve}:
> >    - shard-iclb:         [FAIL][13] ([fdo#110519]) -> [SKIP][14]
> >   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@gem_exec_schedule@semaphore-resolve.html
> >   [14]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@gem_exec_schedule@semaphore-resolve.html
> >
> >  * {igt@kms_cursor_crc@pipe-b-cursor-64x21-random}:
> >    - shard-iclb:         [PASS][15] -> [SKIP][16] +2 similar issues
> >   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
> >   [16]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
> >
> >
> >Known issues
> >------------
> >
> >  Here are the changes found in Patchwork_13017_full that come from known
> issues:
> >
> >### IGT changes ###
> >
> >#### Issues hit ####
> >
> >  * igt@gem_eio@in-flight-suspend:
> >    - shard-apl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +3 similar
> issues
> >   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >apl5/igt@gem_eio@in-flight-suspend.html
> >   [18]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >apl3/igt@gem_eio@in-flight-suspend.html
> >
> >  * igt@kms_draw_crc@fill-fb:
> >    - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#103184])
> >   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl1/igt@kms_draw_crc@fill-fb.html
> >   [20]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl8/igt@kms_draw_crc@fill-fb.html
> >
> >  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >    - shard-glk:          [PASS][21] -> [FAIL][22] ([fdo#102887] / [fdo#105363])
> >   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >   [22]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >
> >  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
> >    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +5 similar issues
> >   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
> >   [24]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrit
> >e.html
> >
> >  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
> >    - shard-skl:          [PASS][25] -> [FAIL][26] ([fdo#108145])
> >   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> >   [26]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> >
> >  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
> >    - shard-iclb:         [PASS][27] -> [FAIL][28] ([fdo#109052])
> >   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
> >   [28]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
> >
> >  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> >    - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#108145] / [fdo#110403])
> >   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >   [30]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >
> >  * igt@kms_psr2_su@frontbuffer:
> >    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109642])
> >   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb2/igt@kms_psr2_su@frontbuffer.html
> >   [32]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb7/igt@kms_psr2_su@frontbuffer.html
> >
> >  * igt@kms_psr@psr2_cursor_plane_onoff:
> >    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109441]) +4 similar issues
> >   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
> >   [34]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
> >
> >  * igt@kms_setmode@basic:
> >    - shard-kbl:          [PASS][35] -> [FAIL][36] ([fdo#99912])
> >   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >kbl6/igt@kms_setmode@basic.html
> >   [36]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >kbl6/igt@kms_setmode@basic.html
> >
> >  * igt@kms_sysfs_edid_timing:
> >    - shard-iclb:         [PASS][37] -> [FAIL][38] ([fdo#100047])
> >   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb7/igt@kms_sysfs_edid_timing.html
> >   [38]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb2/igt@kms_sysfs_edid_timing.html
> >
> >
> >#### Possible fixes ####
> >
> >  * igt@gem_mmap_gtt@forked-medium-copy-xy:
> >    - shard-iclb:         [TIMEOUT][39] ([fdo#109673]) -> [PASS][40]
> >   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@gem_mmap_gtt@forked-medium-copy-xy.html
> >   [40]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb6/igt@gem_mmap_gtt@forked-medium-copy-xy.html
> >
> >  * igt@gem_softpin@noreloc-s3:
> >    - shard-skl:          [INCOMPLETE][41] ([fdo#104108] / [fdo#107773]) -> [PASS][42]
> >   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl2/igt@gem_softpin@noreloc-s3.html
> >   [42]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl7/igt@gem_softpin@noreloc-s3.html
> >
> >  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
> >    - shard-skl:          [INCOMPLETE][43] ([fdo#107807]) -> [PASS][44] +2 similar
> issues
> >   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
> >   [44]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl9/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
> >
> >  * igt@kms_color@pipe-c-ctm-red-to-blue:
> >    - shard-skl:          [FAIL][45] ([fdo#107201]) -> [PASS][46]
> >   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl5/igt@kms_color@pipe-c-ctm-red-to-blue.html
> >   [46]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl2/igt@kms_color@pipe-c-ctm-red-to-blue.html
> >
> >  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
> >    - shard-iclb:         [FAIL][47] ([fdo#103167]) -> [PASS][48] +6 similar issues
> >   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-
> pwrite.html
> >   [48]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pw
> >rite.html
> >
> >  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
> >    - shard-iclb:         [SKIP][49] -> [PASS][50] +40 similar issues
> >   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-
> >cpu.html
> >   [50]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-
> >cpu.html
> >
> >  * igt@kms_frontbuffer_tracking@psr-suspend:
> >    - shard-skl:          [INCOMPLETE][51] ([fdo#104108] / [fdo#106978]) -> [PASS][52]
> >   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
> >   [52]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
> >
> >  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> >    - shard-skl:          [FAIL][53] ([fdo#108145]) -> [PASS][54]
> >   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> >   [54]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> >
> >  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
> >    - shard-iclb:         [SKIP][55] ([fdo#109278]) -> [PASS][56]
> >   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
> >   [56]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
> >
> >  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
> >    - shard-apl:          [DMESG-WARN][57] ([fdo#108566]) -> [PASS][58] +6 similar
> issues
> >   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
> >   [58]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
> >
> >
> >#### Warnings ####
> >
> >  * igt@gem_mmap_gtt@forked-big-copy-odd:
> >    - shard-iclb:         [TIMEOUT][59] ([fdo#109673]) -> [INCOMPLETE][60]
> >([fdo#107713] / [fdo#109100])
> >   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb1/igt@gem_mmap_gtt@forked-big-copy-odd.html
> >   [60]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb8/igt@gem_mmap_gtt@forked-big-copy-odd.html
> >
> >  * igt@i915_pm_lpsp@edp-native:
> >    - shard-iclb:         [SKIP][61] -> [SKIP][62] ([fdo#109301])
> >   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@i915_pm_lpsp@edp-native.html
> >   [62]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@i915_pm_lpsp@edp-native.html
> >
> >  * igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
> >    - shard-iclb:         [SKIP][63] -> [SKIP][64] ([fdo#109278]) +1 similar issue
> >   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-
> fencing.html
> >   [64]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fenc
> >ing.html
> >
> >  * igt@kms_chamelium@hdmi-hpd-storm-disable:
> >    - shard-iclb:         [SKIP][65] -> [SKIP][66] ([fdo#109284])
> >   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_chamelium@hdmi-hpd-storm-disable.html
> >   [66]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_chamelium@hdmi-hpd-storm-disable.html
> >
> >  * igt@kms_flip@2x-dpms-vs-vblank-race:
> >    - shard-iclb:         [SKIP][67] -> [SKIP][68] ([fdo#109274]) +1 similar issue
> >   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_flip@2x-dpms-vs-vblank-race.html
> >   [68]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_flip@2x-dpms-vs-vblank-race.html
> >
> >  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt:
> >    - shard-iclb:         [SKIP][69] -> [SKIP][70] ([fdo#109280]) +5 similar issues
> >   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html
> >   [70]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.htm
> >l
> >
> >  * igt@kms_psr@psr2_sprite_blt:
> >    - shard-iclb:         [SKIP][71] -> [SKIP][72] ([fdo#109441]) +1 similar issue
> >   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb8/igt@kms_psr@psr2_sprite_blt.html
> >   [72]:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_psr@psr2_sprite_blt.html
> >
> >
> >  {name}: This element is suppressed. This means it is ignored when computing
> >          the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> >  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> >  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
> >  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
> >  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> >  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> >  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
> >  [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201
> >  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
> >  [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
> >  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
> >  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> >  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> >  [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> >  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
> >  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
> >  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> >  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
> >  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
> >  [fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
> >  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> >  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
> >  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
> >  [fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
> >  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
> >  [fdo#110519]: https://bugs.freedesktop.org/show_bug.cgi?id=110519
> >  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> >
> >
> >Participating hosts (10 -> 10)
> >------------------------------
> >
> >  No changes in participating hosts
> >
> >
> >Build changes
> >-------------
> >
> >  * Linux: CI_DRM_6081 -> Patchwork_13017
> >
> >  CI_DRM_6081: 871d8bc4020bef25e14ea242cf5e73d3372f1f49 @
> >git://anongit.freedesktop.org/gfx-ci/linux
> >  IGT_4988: 2f6303d13e09b2457762540383c7f36cecd02bbf @
> >git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >  Patchwork_13017: 419f1f1aa013ca1e5da1c5cc97dfb97fe9860d82 @
> >git://anongit.freedesktop.org/gfx-ci/linux
> >  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> >git://anongit.freedesktop.org/piglit
> >
> >== Logs ==
> >
> >For more details see:
> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Ville Syrjälä May 15, 2019, 7:32 p.m. UTC | #3
On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> >Sent: Wednesday, May 15, 2019 6:54 AM
> >To: Shankar, Uma <uma.shankar@intel.com>
> >Cc: intel-gfx@lists.freedesktop.org
> >Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer
> >(rev10)
> >
> >== Series Details ==
> >
> >Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
> >URL   : https://patchwork.freedesktop.org/series/25091/
> >State : failure
> >
> >== Summary ==
> >
> >CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
> >====================================================
> >
> >Summary
> >-------
> >
> >  **FAILURE**
> >
> >  Serious unknown changes coming with Patchwork_13017_full absolutely need to be
> >  verified manually.
> >
> >  If you think the reported changes have nothing to do with the changes
> >  introduced in Patchwork_13017_full, please notify your bug team to allow them
> >  to document this new failure mode, which will reduce false positives in CI.
> >
> >
> >
> >Possible new issues
> >-------------------
> >
> >  Here are the unknown changes that may have been introduced in
> >Patchwork_13017_full:
> >
> >### IGT changes ###
> >
> >#### Possible regressions ####
> >
> >  * igt@gem_exec_suspend@basic-s3:
> >    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
> >   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@gem_exec_suspend@basic-s3.html
> >   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@gem_exec_suspend@basic-s3.html
> >
> >  * igt@kms_prop_blob@invalid-set-prop-any:
> >    - shard-iclb:         [PASS][3] -> [FAIL][4]
> >   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
> >   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
> >
> 
> Hi Martin,
> These issues are unrelated to the changes made in this series. Can you please have a look
> and confirm.

The kms_prop fails at least are real. Probably due to the bogus
function arguements to the replace_blob() thing I pointed out.
Shankar, Uma May 16, 2019, 7:28 a.m. UTC | #4
>-----Original Message-----
>From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>Sent: Thursday, May 16, 2019 1:02 AM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: intel-gfx@lists.freedesktop.org
>Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling
>in DRM layer (rev10)
>
>On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
>>
>>
>> >-----Original Message-----
>> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>> >Sent: Wednesday, May 15, 2019 6:54 AM
>> >To: Shankar, Uma <uma.shankar@intel.com>
>> >Cc: intel-gfx@lists.freedesktop.org
>> >Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
>> >handling in DRM layer
>> >(rev10)
>> >
>> >== Series Details ==
>> >
>> >Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>> >URL   : https://patchwork.freedesktop.org/series/25091/
>> >State : failure
>> >
>> >== Summary ==
>> >
>> >CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
>> >====================================================
>> >
>> >Summary
>> >-------
>> >
>> >  **FAILURE**
>> >
>> >  Serious unknown changes coming with Patchwork_13017_full absolutely
>> > need to be  verified manually.
>> >
>> >  If you think the reported changes have nothing to do with the
>> > changes  introduced in Patchwork_13017_full, please notify your bug
>> > team to allow them  to document this new failure mode, which will reduce false
>positives in CI.
>> >
>> >
>> >
>> >Possible new issues
>> >-------------------
>> >
>> >  Here are the unknown changes that may have been introduced in
>> >Patchwork_13017_full:
>> >
>> >### IGT changes ###
>> >
>> >#### Possible regressions ####
>> >
>> >  * igt@gem_exec_suspend@basic-s3:
>> >    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>> >   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>> >iclb6/igt@gem_exec_suspend@basic-s3.html
>> >   [2]:
>> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>> >iclb5/igt@gem_exec_suspend@basic-s3.html
>> >
>> >  * igt@kms_prop_blob@invalid-set-prop-any:
>> >    - shard-iclb:         [PASS][3] -> [FAIL][4]
>> >   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>> >iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>> >   [4]:
>> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>> >iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>> >
>>
>> Hi Martin,
>> These issues are unrelated to the changes made in this series. Can you
>> please have a look and confirm.
>
>The kms_prop fails at least are real. Probably due to the bogus function arguements
>to the replace_blob() thing I pointed out.

The CI IGT have a clean PASS now. Will anyways update the function arguments and make
it consistent.

Regards,
Uma Shankar

>--
>Ville Syrjälä
>Intel
Ville Syrjälä May 16, 2019, 1:15 p.m. UTC | #5
On Thu, May 16, 2019 at 07:28:43AM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >Sent: Thursday, May 16, 2019 1:02 AM
> >To: Shankar, Uma <uma.shankar@intel.com>
> >Cc: intel-gfx@lists.freedesktop.org
> >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling
> >in DRM layer (rev10)
> >
> >On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
> >>
> >>
> >> >-----Original Message-----
> >> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> >> >Sent: Wednesday, May 15, 2019 6:54 AM
> >> >To: Shankar, Uma <uma.shankar@intel.com>
> >> >Cc: intel-gfx@lists.freedesktop.org
> >> >Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
> >> >handling in DRM layer
> >> >(rev10)
> >> >
> >> >== Series Details ==
> >> >
> >> >Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
> >> >URL   : https://patchwork.freedesktop.org/series/25091/
> >> >State : failure
> >> >
> >> >== Summary ==
> >> >
> >> >CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
> >> >====================================================
> >> >
> >> >Summary
> >> >-------
> >> >
> >> >  **FAILURE**
> >> >
> >> >  Serious unknown changes coming with Patchwork_13017_full absolutely
> >> > need to be  verified manually.
> >> >
> >> >  If you think the reported changes have nothing to do with the
> >> > changes  introduced in Patchwork_13017_full, please notify your bug
> >> > team to allow them  to document this new failure mode, which will reduce false
> >positives in CI.
> >> >
> >> >
> >> >
> >> >Possible new issues
> >> >-------------------
> >> >
> >> >  Here are the unknown changes that may have been introduced in
> >> >Patchwork_13017_full:
> >> >
> >> >### IGT changes ###
> >> >
> >> >#### Possible regressions ####
> >> >
> >> >  * igt@gem_exec_suspend@basic-s3:
> >> >    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
> >> >   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >> >iclb6/igt@gem_exec_suspend@basic-s3.html
> >> >   [2]:
> >> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >> >iclb5/igt@gem_exec_suspend@basic-s3.html
> >> >
> >> >  * igt@kms_prop_blob@invalid-set-prop-any:
> >> >    - shard-iclb:         [PASS][3] -> [FAIL][4]
> >> >   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >> >iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
> >> >   [4]:
> >> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >> >iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
> >> >
> >>
> >> Hi Martin,
> >> These issues are unrelated to the changes made in this series. Can you
> >> please have a look and confirm.
> >
> >The kms_prop fails at least are real. Probably due to the bogus function arguements
> >to the replace_blob() thing I pointed out.
> 
> The CI IGT have a clean PASS now.

You mean it went from FAIL to PASS on its own? Why did that happen?

> Will anyways update the function arguments and make
> it consistent.
> 
> Regards,
> Uma Shankar
> 
> >--
> >Ville Syrjälä
> >Intel
Shankar, Uma May 16, 2019, 1:18 p.m. UTC | #6
>>
>> >-----Original Message-----
>> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> >Sent: Thursday, May 16, 2019 1:02 AM
>> >To: Shankar, Uma <uma.shankar@intel.com>
>> >Cc: intel-gfx@lists.freedesktop.org
>> >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
>> >Parsing and handling in DRM layer (rev10)
>> >
>> >On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
>> >>
>> >>
>> >> >-----Original Message-----
>> >> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>> >> >Sent: Wednesday, May 15, 2019 6:54 AM
>> >> >To: Shankar, Uma <uma.shankar@intel.com>
>> >> >Cc: intel-gfx@lists.freedesktop.org
>> >> >Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
>> >> >handling in DRM layer
>> >> >(rev10)
>> >> >
>> >> >== Series Details ==
>> >> >
>> >> >Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>> >> >URL   : https://patchwork.freedesktop.org/series/25091/
>> >> >State : failure
>> >> >
>> >> >== Summary ==
>> >> >
>> >> >CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
>> >> >====================================================
>> >> >
>> >> >Summary
>> >> >-------
>> >> >
>> >> >  **FAILURE**
>> >> >
>> >> >  Serious unknown changes coming with Patchwork_13017_full
>> >> > absolutely need to be  verified manually.
>> >> >
>> >> >  If you think the reported changes have nothing to do with the
>> >> > changes  introduced in Patchwork_13017_full, please notify your
>> >> > bug team to allow them  to document this new failure mode, which
>> >> > will reduce false
>> >positives in CI.
>> >> >
>> >> >
>> >> >
>> >> >Possible new issues
>> >> >-------------------
>> >> >
>> >> >  Here are the unknown changes that may have been introduced in
>> >> >Patchwork_13017_full:
>> >> >
>> >> >### IGT changes ###
>> >> >
>> >> >#### Possible regressions ####
>> >> >
>> >> >  * igt@gem_exec_suspend@basic-s3:
>> >> >    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>> >> >   [1]:
>> >> >https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>> >> >iclb6/igt@gem_exec_suspend@basic-s3.html
>> >> >   [2]:
>> >> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>> >> >iclb5/igt@gem_exec_suspend@basic-s3.html
>> >> >
>> >> >  * igt@kms_prop_blob@invalid-set-prop-any:
>> >> >    - shard-iclb:         [PASS][3] -> [FAIL][4]
>> >> >   [3]:
>> >> >https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>> >> >iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>> >> >   [4]:
>> >> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>> >> >iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>> >> >
>> >>
>> >> Hi Martin,
>> >> These issues are unrelated to the changes made in this series. Can
>> >> you please have a look and confirm.
>> >
>> >The kms_prop fails at least are real. Probably due to the bogus
>> >function arguements to the replace_blob() thing I pointed out.
>>
>> The CI IGT have a clean PASS now.
>
>You mean it went from FAIL to PASS on its own? Why did that happen?

It was giving a PASS on earlier version v9 with same changes. But on v10 it gave
this error. I was thinking it was re-run, on checking with Jani N he clarified that it
was re-reported. 

>> Will anyways update the function arguments and make it consistent.
>>
>> Regards,
>> Uma Shankar
>>
>> >--
>> >Ville Syrjälä
>> >Intel
>
>--
>Ville Syrjälä
>Intel
Peres, Martin May 16, 2019, 2:08 p.m. UTC | #7
On 16/05/2019 16:18, Shankar, Uma wrote:
> 
> 
>>>
>>>> -----Original Message-----
>>>> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>>>> Sent: Thursday, May 16, 2019 1:02 AM
>>>> To: Shankar, Uma <uma.shankar@intel.com>
>>>> Cc: intel-gfx@lists.freedesktop.org
>>>> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
>>>> Parsing and handling in DRM layer (rev10)
>>>>
>>>> On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>>>>>> Sent: Wednesday, May 15, 2019 6:54 AM
>>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>>>>>> Cc: intel-gfx@lists.freedesktop.org
>>>>>> Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
>>>>>> handling in DRM layer
>>>>>> (rev10)
>>>>>>
>>>>>> == Series Details ==
>>>>>>
>>>>>> Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>>>>>> URL   : https://patchwork.freedesktop.org/series/25091/
>>>>>> State : failure
>>>>>>
>>>>>> == Summary ==
>>>>>>
>>>>>> CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
>>>>>> ====================================================
>>>>>>
>>>>>> Summary
>>>>>> -------
>>>>>>
>>>>>>  **FAILURE**
>>>>>>
>>>>>>  Serious unknown changes coming with Patchwork_13017_full
>>>>>> absolutely need to be  verified manually.
>>>>>>
>>>>>>  If you think the reported changes have nothing to do with the
>>>>>> changes  introduced in Patchwork_13017_full, please notify your
>>>>>> bug team to allow them  to document this new failure mode, which
>>>>>> will reduce false
>>>> positives in CI.
>>>>>>
>>>>>>
>>>>>>
>>>>>> Possible new issues
>>>>>> -------------------
>>>>>>
>>>>>>  Here are the unknown changes that may have been introduced in
>>>>>> Patchwork_13017_full:
>>>>>>
>>>>>> ### IGT changes ###
>>>>>>
>>>>>> #### Possible regressions ####
>>>>>>
>>>>>>  * igt@gem_exec_suspend@basic-s3:
>>>>>>    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>>>>>>   [1]:
>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>>>>>> iclb6/igt@gem_exec_suspend@basic-s3.html
>>>>>>   [2]:
>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>>>>>> iclb5/igt@gem_exec_suspend@basic-s3.html
>>>>>>
>>>>>>  * igt@kms_prop_blob@invalid-set-prop-any:
>>>>>>    - shard-iclb:         [PASS][3] -> [FAIL][4]
>>>>>>   [3]:
>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>>>>>> iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>>>>>>   [4]:
>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>>>>>> iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>>>>>>
>>>>>
>>>>> Hi Martin,
>>>>> These issues are unrelated to the changes made in this series. Can
>>>>> you please have a look and confirm.
>>>>
>>>> The kms_prop fails at least are real. Probably due to the bogus
>>>> function arguements to the replace_blob() thing I pointed out.
>>>
>>> The CI IGT have a clean PASS now.
>>
>> You mean it went from FAIL to PASS on its own? Why did that happen?
> 
> It was giving a PASS on earlier version v9 with same changes. But on v10 it gave
> this error. I was thinking it was re-run, on checking with Jani N he clarified that it
> was re-reported. 

Yeah, I re-report some runs after being told they contain noise :)

> 
>>> Will anyways update the function arguments and make it consistent.
>>>
>>> Regards,
>>> Uma Shankar
>>>
>>>> --
>>>> Ville Syrjälä
>>>> Intel
>>
>> --
>> Ville Syrjälä
>> Intel
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
Ville Syrjälä May 17, 2019, 1:04 p.m. UTC | #8
On Thu, May 16, 2019 at 01:18:15PM +0000, Shankar, Uma wrote:
> 
> 
> >>
> >> >-----Original Message-----
> >> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >> >Sent: Thursday, May 16, 2019 1:02 AM
> >> >To: Shankar, Uma <uma.shankar@intel.com>
> >> >Cc: intel-gfx@lists.freedesktop.org
> >> >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
> >> >Parsing and handling in DRM layer (rev10)
> >> >
> >> >On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
> >> >>
> >> >>
> >> >> >-----Original Message-----
> >> >> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> >> >> >Sent: Wednesday, May 15, 2019 6:54 AM
> >> >> >To: Shankar, Uma <uma.shankar@intel.com>
> >> >> >Cc: intel-gfx@lists.freedesktop.org
> >> >> >Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
> >> >> >handling in DRM layer
> >> >> >(rev10)
> >> >> >
> >> >> >== Series Details ==
> >> >> >
> >> >> >Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
> >> >> >URL   : https://patchwork.freedesktop.org/series/25091/
> >> >> >State : failure
> >> >> >
> >> >> >== Summary ==
> >> >> >
> >> >> >CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
> >> >> >====================================================
> >> >> >
> >> >> >Summary
> >> >> >-------
> >> >> >
> >> >> >  **FAILURE**
> >> >> >
> >> >> >  Serious unknown changes coming with Patchwork_13017_full
> >> >> > absolutely need to be  verified manually.
> >> >> >
> >> >> >  If you think the reported changes have nothing to do with the
> >> >> > changes  introduced in Patchwork_13017_full, please notify your
> >> >> > bug team to allow them  to document this new failure mode, which
> >> >> > will reduce false
> >> >positives in CI.
> >> >> >
> >> >> >
> >> >> >
> >> >> >Possible new issues
> >> >> >-------------------
> >> >> >
> >> >> >  Here are the unknown changes that may have been introduced in
> >> >> >Patchwork_13017_full:
> >> >> >
> >> >> >### IGT changes ###
> >> >> >
> >> >> >#### Possible regressions ####
> >> >> >
> >> >> >  * igt@gem_exec_suspend@basic-s3:
> >> >> >    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
> >> >> >   [1]:
> >> >> >https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >> >> >iclb6/igt@gem_exec_suspend@basic-s3.html
> >> >> >   [2]:
> >> >> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >> >> >iclb5/igt@gem_exec_suspend@basic-s3.html
> >> >> >
> >> >> >  * igt@kms_prop_blob@invalid-set-prop-any:
> >> >> >    - shard-iclb:         [PASS][3] -> [FAIL][4]
> >> >> >   [3]:
> >> >> >https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >> >> >iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
> >> >> >   [4]:
> >> >> >https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >> >> >iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
> >> >> >
> >> >>
> >> >> Hi Martin,
> >> >> These issues are unrelated to the changes made in this series. Can
> >> >> you please have a look and confirm.
> >> >
> >> >The kms_prop fails at least are real. Probably due to the bogus
> >> >function arguements to the replace_blob() thing I pointed out.
> >>
> >> The CI IGT have a clean PASS now.
> >
> >You mean it went from FAIL to PASS on its own? Why did that happen?
> 
> It was giving a PASS on earlier version v9 with same changes. But on v10 it gave
> this error. I was thinking it was re-run, on checking with Jani N he clarified that it
> was re-reported. 

Did you even try to analyse the failures at all or just assumed
they were bogus and asked for a rerun?

I'm still in the dark as to why these failures were deemed
to not be relevant.
Peres, Martin May 17, 2019, 1:09 p.m. UTC | #9
On 17/05/2019 16:04, Ville Syrjälä wrote:
> On Thu, May 16, 2019 at 01:18:15PM +0000, Shankar, Uma wrote:
>>
>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>>>>> Sent: Thursday, May 16, 2019 1:02 AM
>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>>>>> Cc: intel-gfx@lists.freedesktop.org
>>>>> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
>>>>> Parsing and handling in DRM layer (rev10)
>>>>>
>>>>> On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
>>>>>>
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>>>>>>> Sent: Wednesday, May 15, 2019 6:54 AM
>>>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>>>>>>> Cc: intel-gfx@lists.freedesktop.org
>>>>>>> Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
>>>>>>> handling in DRM layer
>>>>>>> (rev10)
>>>>>>>
>>>>>>> == Series Details ==
>>>>>>>
>>>>>>> Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>>>>>>> URL   : https://patchwork.freedesktop.org/series/25091/
>>>>>>> State : failure
>>>>>>>
>>>>>>> == Summary ==
>>>>>>>
>>>>>>> CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full
>>>>>>> ====================================================
>>>>>>>
>>>>>>> Summary
>>>>>>> -------
>>>>>>>
>>>>>>>  **FAILURE**
>>>>>>>
>>>>>>>  Serious unknown changes coming with Patchwork_13017_full
>>>>>>> absolutely need to be  verified manually.
>>>>>>>
>>>>>>>  If you think the reported changes have nothing to do with the
>>>>>>> changes  introduced in Patchwork_13017_full, please notify your
>>>>>>> bug team to allow them  to document this new failure mode, which
>>>>>>> will reduce false
>>>>> positives in CI.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Possible new issues
>>>>>>> -------------------
>>>>>>>
>>>>>>>  Here are the unknown changes that may have been introduced in
>>>>>>> Patchwork_13017_full:
>>>>>>>
>>>>>>> ### IGT changes ###
>>>>>>>
>>>>>>> #### Possible regressions ####
>>>>>>>
>>>>>>>  * igt@gem_exec_suspend@basic-s3:
>>>>>>>    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>>>>>>>   [1]:
>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>>>>>>> iclb6/igt@gem_exec_suspend@basic-s3.html
>>>>>>>   [2]:
>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>>>>>>> iclb5/igt@gem_exec_suspend@basic-s3.html
>>>>>>>
>>>>>>>  * igt@kms_prop_blob@invalid-set-prop-any:
>>>>>>>    - shard-iclb:         [PASS][3] -> [FAIL][4]
>>>>>>>   [3]:
>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>>>>>>> iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>>>>>>>   [4]:
>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>>>>>>> iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>>>>>>>
>>>>>>
>>>>>> Hi Martin,
>>>>>> These issues are unrelated to the changes made in this series. Can
>>>>>> you please have a look and confirm.
>>>>>
>>>>> The kms_prop fails at least are real. Probably due to the bogus
>>>>> function arguements to the replace_blob() thing I pointed out.
>>>>
>>>> The CI IGT have a clean PASS now.
>>>
>>> You mean it went from FAIL to PASS on its own? Why did that happen?
>>
>> It was giving a PASS on earlier version v9 with same changes. But on v10 it gave
>> this error. I was thinking it was re-run, on checking with Jani N he clarified that it
>> was re-reported. 
> 
> Did you even try to analyse the failures at all or just assumed
> they were bogus and asked for a rerun?
> 
> I'm still in the dark as to why these failures were deemed
> to not be relevant.
> 

This is completely unrelated to this series. We have a bug for this
issue already, so no worries there.

However, thanks for caring so much about this. I should have clarified
what I was doing...
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
Shankar, Uma May 17, 2019, 1:17 p.m. UTC | #10
>-----Original Message-----
>From: Peres, Martin
>Sent: Friday, May 17, 2019 6:39 PM
>To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Shankar, Uma
><uma.shankar@intel.com>
>Cc: intel-gfx@lists.freedesktop.org
>Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling
>in DRM layer (rev10)
>
>On 17/05/2019 16:04, Ville Syrjälä wrote:
>> On Thu, May 16, 2019 at 01:18:15PM +0000, Shankar, Uma wrote:
>>>
>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>>>>>> Sent: Thursday, May 16, 2019 1:02 AM
>>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>>>>>> Cc: intel-gfx@lists.freedesktop.org
>>>>>> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
>>>>>> Parsing and handling in DRM layer (rev10)
>>>>>>
>>>>>> On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
>>>>>>>
>>>>>>>
>>>>>>>> -----Original Message-----
>>>>>>>> From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>>>>>>>> Sent: Wednesday, May 15, 2019 6:54 AM
>>>>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>>>>>>>> Cc: intel-gfx@lists.freedesktop.org
>>>>>>>> Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
>>>>>>>> handling in DRM layer
>>>>>>>> (rev10)
>>>>>>>>
>>>>>>>> == Series Details ==
>>>>>>>>
>>>>>>>> Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>>>>>>>> URL   : https://patchwork.freedesktop.org/series/25091/
>>>>>>>> State : failure
>>>>>>>>
>>>>>>>> == Summary ==
>>>>>>>>
>>>>>>>> CI Bug Log - changes from CI_DRM_6081_full ->
>>>>>>>> Patchwork_13017_full
>>>>>>>> ====================================================
>>>>>>>>
>>>>>>>> Summary
>>>>>>>> -------
>>>>>>>>
>>>>>>>>  **FAILURE**
>>>>>>>>
>>>>>>>>  Serious unknown changes coming with Patchwork_13017_full
>>>>>>>> absolutely need to be  verified manually.
>>>>>>>>
>>>>>>>>  If you think the reported changes have nothing to do with the
>>>>>>>> changes  introduced in Patchwork_13017_full, please notify your
>>>>>>>> bug team to allow them  to document this new failure mode, which
>>>>>>>> will reduce false
>>>>>> positives in CI.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Possible new issues
>>>>>>>> -------------------
>>>>>>>>
>>>>>>>>  Here are the unknown changes that may have been introduced in
>>>>>>>> Patchwork_13017_full:
>>>>>>>>
>>>>>>>> ### IGT changes ###
>>>>>>>>
>>>>>>>> #### Possible regressions ####
>>>>>>>>
>>>>>>>>  * igt@gem_exec_suspend@basic-s3:
>>>>>>>>    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>>>>>>>>   [1]:
>>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>>>>>>>> iclb6/igt@gem_exec_suspend@basic-s3.html
>>>>>>>>   [2]:
>>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>>>>>>>> iclb5/igt@gem_exec_suspend@basic-s3.html
>>>>>>>>
>>>>>>>>  * igt@kms_prop_blob@invalid-set-prop-any:
>>>>>>>>    - shard-iclb:         [PASS][3] -> [FAIL][4]
>>>>>>>>   [3]:
>>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>>>>>>>> iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>>>>>>>>   [4]:
>>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
>>>>>>>> iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>>>>>>>>
>>>>>>>
>>>>>>> Hi Martin,
>>>>>>> These issues are unrelated to the changes made in this series.
>>>>>>> Can you please have a look and confirm.
>>>>>>
>>>>>> The kms_prop fails at least are real. Probably due to the bogus
>>>>>> function arguements to the replace_blob() thing I pointed out.
>>>>>
>>>>> The CI IGT have a clean PASS now.
>>>>
>>>> You mean it went from FAIL to PASS on its own? Why did that happen?
>>>
>>> It was giving a PASS on earlier version v9 with same changes. But on
>>> v10 it gave this error. I was thinking it was re-run, on checking
>>> with Jani N he clarified that it was re-reported.
>>
>> Did you even try to analyse the failures at all or just assumed they
>> were bogus and asked for a rerun?
>>
>> I'm still in the dark as to why these failures were deemed to not be
>> relevant.
>>
>
>This is completely unrelated to this series. We have a bug for this issue already, so no
>worries there.
>
>However, thanks for caring so much about this. I should have clarified what I was
>doing...

Hi Ville,
We had a PASS on earlier versions of the series with same change and even locally
./tests/kms_prop_blob gave SUCCESS for all subtests. So I reported this to Martin and
Jani, and Martin helped to fix this, wrt getting reported correctly.

Regards,
Uma Shankar
Ville Syrjälä May 17, 2019, 1:24 p.m. UTC | #11
On Fri, May 17, 2019 at 01:17:05PM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Peres, Martin
> >Sent: Friday, May 17, 2019 6:39 PM
> >To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Shankar, Uma
> ><uma.shankar@intel.com>
> >Cc: intel-gfx@lists.freedesktop.org
> >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling
> >in DRM layer (rev10)
> >
> >On 17/05/2019 16:04, Ville Syrjälä wrote:
> >> On Thu, May 16, 2019 at 01:18:15PM +0000, Shankar, Uma wrote:
> >>>
> >>>
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >>>>>> Sent: Thursday, May 16, 2019 1:02 AM
> >>>>>> To: Shankar, Uma <uma.shankar@intel.com>
> >>>>>> Cc: intel-gfx@lists.freedesktop.org
> >>>>>> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
> >>>>>> Parsing and handling in DRM layer (rev10)
> >>>>>>
> >>>>>> On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>> -----Original Message-----
> >>>>>>>> From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> >>>>>>>> Sent: Wednesday, May 15, 2019 6:54 AM
> >>>>>>>> To: Shankar, Uma <uma.shankar@intel.com>
> >>>>>>>> Cc: intel-gfx@lists.freedesktop.org
> >>>>>>>> Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and
> >>>>>>>> handling in DRM layer
> >>>>>>>> (rev10)
> >>>>>>>>
> >>>>>>>> == Series Details ==
> >>>>>>>>
> >>>>>>>> Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
> >>>>>>>> URL   : https://patchwork.freedesktop.org/series/25091/
> >>>>>>>> State : failure
> >>>>>>>>
> >>>>>>>> == Summary ==
> >>>>>>>>
> >>>>>>>> CI Bug Log - changes from CI_DRM_6081_full ->
> >>>>>>>> Patchwork_13017_full
> >>>>>>>> ====================================================
> >>>>>>>>
> >>>>>>>> Summary
> >>>>>>>> -------
> >>>>>>>>
> >>>>>>>>  **FAILURE**
> >>>>>>>>
> >>>>>>>>  Serious unknown changes coming with Patchwork_13017_full
> >>>>>>>> absolutely need to be  verified manually.
> >>>>>>>>
> >>>>>>>>  If you think the reported changes have nothing to do with the
> >>>>>>>> changes  introduced in Patchwork_13017_full, please notify your
> >>>>>>>> bug team to allow them  to document this new failure mode, which
> >>>>>>>> will reduce false
> >>>>>> positives in CI.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Possible new issues
> >>>>>>>> -------------------
> >>>>>>>>
> >>>>>>>>  Here are the unknown changes that may have been introduced in
> >>>>>>>> Patchwork_13017_full:
> >>>>>>>>
> >>>>>>>> ### IGT changes ###
> >>>>>>>>
> >>>>>>>> #### Possible regressions ####
> >>>>>>>>
> >>>>>>>>  * igt@gem_exec_suspend@basic-s3:
> >>>>>>>>    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
> >>>>>>>>   [1]:
> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >>>>>>>> iclb6/igt@gem_exec_suspend@basic-s3.html
> >>>>>>>>   [2]:
> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >>>>>>>> iclb5/igt@gem_exec_suspend@basic-s3.html
> >>>>>>>>
> >>>>>>>>  * igt@kms_prop_blob@invalid-set-prop-any:
> >>>>>>>>    - shard-iclb:         [PASS][3] -> [FAIL][4]
> >>>>>>>>   [3]:
> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
> >>>>>>>> iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
> >>>>>>>>   [4]:
> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shard-
> >>>>>>>> iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
> >>>>>>>>
> >>>>>>>
> >>>>>>> Hi Martin,
> >>>>>>> These issues are unrelated to the changes made in this series.
> >>>>>>> Can you please have a look and confirm.
> >>>>>>
> >>>>>> The kms_prop fails at least are real. Probably due to the bogus
> >>>>>> function arguements to the replace_blob() thing I pointed out.
> >>>>>
> >>>>> The CI IGT have a clean PASS now.
> >>>>
> >>>> You mean it went from FAIL to PASS on its own? Why did that happen?
> >>>
> >>> It was giving a PASS on earlier version v9 with same changes. But on
> >>> v10 it gave this error. I was thinking it was re-run, on checking
> >>> with Jani N he clarified that it was re-reported.
> >>
> >> Did you even try to analyse the failures at all or just assumed they
> >> were bogus and asked for a rerun?
> >>
> >> I'm still in the dark as to why these failures were deemed to not be
> >> relevant.
> >>
> >
> >This is completely unrelated to this series. We have a bug for this issue already, so no
> >worries there.
> >
> >However, thanks for caring so much about this. I should have clarified what I was
> >doing...
> 
> Hi Ville,
> We had a PASS on earlier versions of the series with same change and even locally
> ./tests/kms_prop_blob gave SUCCESS for all subtests.

I don't care. There was a failure in a test that is actually relevant
for the code being changed, so it should have been analyzed and the
results of that analysis shared on the list. Without that I'm just
going to assume there is a potential bug in the new code and not
merge the thing.
Shankar, Uma May 17, 2019, 1:38 p.m. UTC | #12
>-----Original Message-----
>From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>Sent: Friday, May 17, 2019 6:54 PM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: Peres, Martin <martin.peres@intel.com>; intel-gfx@lists.freedesktop.org
>Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling
>in DRM layer (rev10)
>
>On Fri, May 17, 2019 at 01:17:05PM +0000, Shankar, Uma wrote:
>>
>>
>> >-----Original Message-----
>> >From: Peres, Martin
>> >Sent: Friday, May 17, 2019 6:39 PM
>> >To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Shankar, Uma
>> ><uma.shankar@intel.com>
>> >Cc: intel-gfx@lists.freedesktop.org
>> >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata
>> >Parsing and handling in DRM layer (rev10)
>> >
>> >On 17/05/2019 16:04, Ville Syrjälä wrote:
>> >> On Thu, May 16, 2019 at 01:18:15PM +0000, Shankar, Uma wrote:
>> >>>
>> >>>
>> >>>>>
>> >>>>>> -----Original Message-----
>> >>>>>> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> >>>>>> Sent: Thursday, May 16, 2019 1:02 AM
>> >>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>> >>>>>> Cc: intel-gfx@lists.freedesktop.org
>> >>>>>> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR
>> >>>>>> Metadata Parsing and handling in DRM layer (rev10)
>> >>>>>>
>> >>>>>> On Wed, May 15, 2019 at 08:59:37AM +0000, Shankar, Uma wrote:
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>> -----Original Message-----
>> >>>>>>>> From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
>> >>>>>>>> Sent: Wednesday, May 15, 2019 6:54 AM
>> >>>>>>>> To: Shankar, Uma <uma.shankar@intel.com>
>> >>>>>>>> Cc: intel-gfx@lists.freedesktop.org
>> >>>>>>>> Subject: ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing
>> >>>>>>>> and handling in DRM layer
>> >>>>>>>> (rev10)
>> >>>>>>>>
>> >>>>>>>> == Series Details ==
>> >>>>>>>>
>> >>>>>>>> Series: Add HDR Metadata Parsing and handling in DRM layer (rev10)
>> >>>>>>>> URL   : https://patchwork.freedesktop.org/series/25091/
>> >>>>>>>> State : failure
>> >>>>>>>>
>> >>>>>>>> == Summary ==
>> >>>>>>>>
>> >>>>>>>> CI Bug Log - changes from CI_DRM_6081_full ->
>> >>>>>>>> Patchwork_13017_full
>> >>>>>>>> ====================================================
>> >>>>>>>>
>> >>>>>>>> Summary
>> >>>>>>>> -------
>> >>>>>>>>
>> >>>>>>>>  **FAILURE**
>> >>>>>>>>
>> >>>>>>>>  Serious unknown changes coming with Patchwork_13017_full
>> >>>>>>>> absolutely need to be  verified manually.
>> >>>>>>>>
>> >>>>>>>>  If you think the reported changes have nothing to do with
>> >>>>>>>> the changes  introduced in Patchwork_13017_full, please
>> >>>>>>>> notify your bug team to allow them  to document this new
>> >>>>>>>> failure mode, which will reduce false
>> >>>>>> positives in CI.
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> Possible new issues
>> >>>>>>>> -------------------
>> >>>>>>>>
>> >>>>>>>>  Here are the unknown changes that may have been introduced
>> >>>>>>>> in
>> >>>>>>>> Patchwork_13017_full:
>> >>>>>>>>
>> >>>>>>>> ### IGT changes ###
>> >>>>>>>>
>> >>>>>>>> #### Possible regressions ####
>> >>>>>>>>
>> >>>>>>>>  * igt@gem_exec_suspend@basic-s3:
>> >>>>>>>>    - shard-iclb:         [PASS][1] -> [SKIP][2] +43 similar issues
>> >>>>>>>>   [1]:
>> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>> >>>>>>>> iclb6/igt@gem_exec_suspend@basic-s3.html
>> >>>>>>>>   [2]:
>> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shar
>> >>>>>>>> d- iclb5/igt@gem_exec_suspend@basic-s3.html
>> >>>>>>>>
>> >>>>>>>>  * igt@kms_prop_blob@invalid-set-prop-any:
>> >>>>>>>>    - shard-iclb:         [PASS][3] -> [FAIL][4]
>> >>>>>>>>   [3]:
>> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-
>> >>>>>>>> iclb6/igt@kms_prop_blob@invalid-set-prop-any.html
>> >>>>>>>>   [4]:
>> >>>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13017/shar
>> >>>>>>>> d- iclb5/igt@kms_prop_blob@invalid-set-prop-any.html
>> >>>>>>>>
>> >>>>>>>
>> >>>>>>> Hi Martin,
>> >>>>>>> These issues are unrelated to the changes made in this series.
>> >>>>>>> Can you please have a look and confirm.
>> >>>>>>
>> >>>>>> The kms_prop fails at least are real. Probably due to the bogus
>> >>>>>> function arguements to the replace_blob() thing I pointed out.
>> >>>>>
>> >>>>> The CI IGT have a clean PASS now.
>> >>>>
>> >>>> You mean it went from FAIL to PASS on its own? Why did that happen?
>> >>>
>> >>> It was giving a PASS on earlier version v9 with same changes. But
>> >>> on
>> >>> v10 it gave this error. I was thinking it was re-run, on checking
>> >>> with Jani N he clarified that it was re-reported.
>> >>
>> >> Did you even try to analyse the failures at all or just assumed
>> >> they were bogus and asked for a rerun?
>> >>
>> >> I'm still in the dark as to why these failures were deemed to not
>> >> be relevant.
>> >>
>> >
>> >This is completely unrelated to this series. We have a bug for this
>> >issue already, so no worries there.
>> >
>> >However, thanks for caring so much about this. I should have
>> >clarified what I was doing...
>>
>> Hi Ville,
>> We had a PASS on earlier versions of the series with same change and
>> even locally ./tests/kms_prop_blob gave SUCCESS for all subtests.
>
>I don't care. There was a failure in a test that is actually relevant for the code being
>changed, so it should have been analyzed and the results of that analysis shared on
>the list. Without that I'm just going to assume there is a potential bug in the new code
>and not merge the thing.

Since this came as an issue which didn't reproduced locally and also older versions of the
series also worked, I asked for a re-run to be sure (or if it's already known issue happening due to
something which people are already aware of). Also I never doubted that something is wrong in
blob handing since it was done like that from the beginning of this series. I will be more
careful going forward to add these details and explanations while asking for a re-run. 

Regards,
Uma Shankar

>--
>Ville Syrjälä
>Intel