[000/145] ASoC: modern dai_link style support
mbox series

Message ID 87sgt7p3zo.wl-kuninori.morimoto.gx@renesas.com
Headers show
Series
  • ASoC: modern dai_link style support
Related show

Message

Kuninori Morimoto May 22, 2019, 3:37 a.m. UTC
Hi Mark

These are for modern dai_link style support patches.
[001/145] adds missing modern dai_link style for CPU.
and others are switch to modern style from legacy style.
Last patch removes legacy style.

These are based on mark/for-5.3 + v5.2-rc1

I hope these work well for all sound card, but I can't test for all.
Please test these at each sound cards.

Kuninori Morimoto (145):
  ASoC: soc-core: use snd_soc_dai_link_component for CPU
  ASoC: simple-card: support snd_soc_dai_link_component style for cpu
  ASoC: soc.h: add sound dai_link connection macro
  ASoC: mediatek: mt6797-mt6351: use modern dai_link style
  ASoC: mediatek: mt2701-wm8960: use modern dai_link style
  ASoC: mediatek: mt2701-cs42448: use modern dai_link style
  ASoC: mediatek: mt8173-max98090: use modern dai_link style
  ASoC: mediatek: mt8173-rt5650: use modern dai_link style
  ASoC: mediatek: mt8173-rt5650-rt5676: use modern dai_link style
  ASoC: mediatek: mt8173-rt5650-rt5514: use modern dai_link style
  ASoC: mediatek: mt8183-da7219-max98357: use modern dai_link style
  ASoC: mediatek: mt8183-mt6358-ts3a227-max98357: use modern dai_link style
  ASoC: samsung: bells: use modern dai_link style
  ASoC: samsung: smdk_wm8580: use modern dai_link style
  ASoC: samsung: smdk_wm8994: use modern dai_link style
  ASoC: samsung: smdk_wm8994pcm: use modern dai_link style
  ASoC: samsung: smdk_spdif: use modern dai_link style
  ASoC: samsung: h1940_uda1380: use modern dai_link style
  ASoC: samsung: arndale_rt5631: use modern dai_link style
  ASoC: samsung: tobermory: use modern dai_link style
  ASoC: samsung: tm2_wm5110: use modern dai_link style
  ASoC: samsung: speyside: use modern dai_link style
  ASoC: samsung: snow: use modern dai_link style
  ASoC: samsung: smartq_wm8987: use modern dai_link style
  ASoC: samsung: s3c24xx_uda134x: use modern dai_link style
  ASoC: samsung: s3c24xx_simtec_tlv320aic23: use modern dai_link style
  ASoC: samsung: s3c24xx_simtec_hermes: use modern dai_link style
  ASoC: samsung: rx1950_uda1380: use modern dai_link style
  ASoC: samsung: odroid: use modern dai_link style
  ASoC: samsung: neo1973_wm8753: use modern dai_link style
  ASoC: samsung: lowland: use modern dai_link style
  ASoC: samsung: littlemill: use modern dai_link style
  ASoC: samsung: jive_wm8750: use modern dai_link style
  ASoC: pxa: brownstone: use modern dai_link style
  ASoC: pxa: corgi: use modern dai_link style
  ASoC: pxa: e740_wm9705: use modern dai_link style
  ASoC: pxa: e750_wm9705: use modern dai_link style
  ASoC: pxa: e800_wm9712: use modern dai_link style
  ASoC: pxa: em-x270: use modern dai_link style
  ASoC: pxa: hx4700: use modern dai_link style
  ASoC: pxa: imote2: use modern dai_link style
  ASoC: pxa: magician: use modern dai_link style
  ASoC: pxa: mioa701_wm9713: use modern dai_link style
  ASoC: pxa: palm27x: use modern dai_link style
  ASoC: pxa: zylonite: use modern dai_link style
  ASoC: pxa: z2: use modern dai_link style
  ASoC: pxa: ttc-dkb: use modern dai_link style
  ASoC: pxa: tosa: use modern dai_link style
  ASoC: pxa: spitz: use modern dai_link style
  ASoC: pxa: poodle: use modern dai_link style
  ASoC: kirkwood: armada-370-db: use modern dai_link style
  ASoC: ti: n810: use modern dai_link style
  ASoC: ti: osk5912: use modern dai_link style
  ASoC: ti: ams-delta: use modern dai_link style
  ASoC: ti: omap3pandora: use modern dai_link style
  ASoC: ti: davinci-evm: use modern dai_link style
  ASoC: ti: omap-hdmi: use modern dai_link style
  ASoC: ti: omap-abe-twl6040: use modern dai_link style
  ASoC: ti: omap-twl4030: use modern dai_link style
  ASoC: ti: rx51: use modern dai_link style
  ASoC: sh: migor: use modern dai_link style
  ASoC: sh: sh7760-ac97: use modern dai_link style
  ASoC: amd: acp-da7219-max98357a: use modern dai_link style
  ASoC: amd: acp-rt5645: use modern dai_link style
  ASoC: atmel: mikroe-proto: use modern dai_link style
  ASoC: atmel: sam9x5_wm8731: use modern dai_link style
  ASoC: atmel: sam9g20_wm8731: use modern dai_link style
  ASoC: atmel: tse850-pcm5142: use modern dai_link style
  ASoC: atmel: atmel-wm8904: use modern dai_link style
  ASoC: atmel: atmel-pdmic: use modern dai_link style
  ASoC: atmel: atmel-classd: use modern dai_link style
  ASoC: au1x: db1000: use modern dai_link style
  ASoC: au1x: db1200: use modern dai_link style
  ASoC: cirrus: edb93xx: use modern dai_link style
  ASoC: cirrus: simone: use modern dai_link style
  ASoC: cirrus: snappercl15: use modern dai_link style
  ASoC: fsl: efika-audio-fabric: use modern dai_link style
  ASoC: fsl: imx-spdif: use modern dai_link style
  ASoC: fsl: mx27vis-aic32x4: use modern dai_link style
  ASoC: fsl: phycore-ac97: use modern dai_link style
  ASoC: fsl: wm1133-ev1: use modern dai_link style
  ASoC: fsl: fsl-asoc-card: use modern dai_link style
  ASoC: fsl: mpc8610_hpcd/p1022_ds/p1022_rdk: use modern dai_link style
  ASoC: fsl: imx-es8328: use modern dai_link style
  ASoC: fsl: eukrea-tlv320: use modern dai_link style
  ASoC: fsl: imx-sgtl5000: use modern dai_link style
  ASoC: fsl: imx-mc13783: use modern dai_link style
  ASoC: fsl: pcm030-audio-fabric: use modern dai_link style
  ASoC: fsl: imx-audmix: use modern dai_link style
  ASoC: jz4740: qi_lb60: use modern dai_link style
  ASoC: meson: axg-card: use modern dai_link style
  ASoC: mxs: mxs-sgtl5000: use modern dai_link style
  ASoC: nuc900: nuc900-audio: use modern dai_link style
  ASoC: qcom: storm: use modern dai_link style
  ASoC: qcom: common: use modern dai_link style
  ASoC: qcom: apq8016_sbc: use modern dai_link style
  ASoC: rockchip: rk3399_gru_sound: use modern dai_link style
  ASoC: rockchip: rk3288_hdmi_analog: use modern dai_link style
  ASoC: rockchip: rockchip_rt5645: use modern dai_link style
  ASoC: rockchip: rockchip_max98090: use modern dai_link style
  ASoC: sirf: sirf-audio: use modern dai_link style
  ASoC: ux500: mop500: use modern dai_link style
  ASoC: sunxi: sun4i-codec: use modern dai_link style
  ASoC: txx9: txx9aclc-generic: use modern dai_link style
  ASoC: tegra: tegra_rt5677: use modern dai_link style
  ASoC: tegra: tegra_wm8753: use modern dai_link style
  ASoC: tegra: trimslice: use modern dai_link style
  ASoC: tegra: tegra_alc5632: use modern dai_link style
  ASoC: tegra: tegra_sgtl5000: use modern dai_link style
  ASoC: tegra: tegra_rt5640: use modern dai_link style
  ASoC: tegra: tegra_wm8903: use modern dai_link style
  ASoC: tegra: tegra_wm9712: use modern dai_link style
  ASoC: tegra: tegra_max98090: use modern dai_link style
  ASoC: soc-topology: use modern dai_link style
  ASoC: vc4: vc4_htmi: use modern dai_link style
  ASoC: sof: use modern dai_link style
  ASoC: Intel: bdw-rt5677: use modern dai_link style
  ASoC: Intel: haswell: use modern dai_link style
  ASoC: Intel: broadwell: use modern dai_link style
  ASoC: Intel: bxt_da7219_max98357a: use modern dai_link style
  ASoC: Intel: bxt_rt298: use modern dai_link style
  ASoC: Intel: byt-rt5640: use modern dai_link style
  ASoC: Intel: byt-max98090: use modern dai_link style
  ASoC: Intel: bytcht_es8316: use modern dai_link style
  ASoC: Intel: bytcht_nocodec: use modern dai_link style
  ASoC: Intel: bytcht_da7213: use modern dai_link style
  ASoC: Intel: bytcr_rt5651: use modern dai_link style
  ASoC: Intel: bytcr_rt5640: use modern dai_link style
  ASoC: Intel: cht_bsw_rt5645: use modern dai_link style
  ASoC: Intel: cht_bsw_max98090_ti: use modern dai_link style
  ASoC: Intel: cht_bsw_rt5672: use modern dai_link style
  ASoC: Intel: cht_bsw_nau8824: use modern dai_link style
  ASoC: Intel: kbl_rt5660: use modern dai_link style
  ASoC: Intel: kbl_rt5663_max98927: use modern dai_link style
  ASoC: Intel: kbl_rt5663_rt5514_max98927: use modern dai_link style
  ASoC: Intel: kbl_da7219_max98927: use modern dai_link style
  ASoC: Intel: kbl_da7219_max98357a: use modern dai_link style
  ASoC: Intel: skl_nau88l25_ssm4567: use modern dai_link style
  ASoC: Intel: skl_rt286: use modern dai_link style
  ASoC: Intel: skl_nau88l25_max98357a: use modern dai_link style
  ASoC: Intel: skl-pcm: use modern dai_link style
  ASoC: Intel: skl_hda_dsp_common: use modern dai_link style
  ASoC: Intel: glk_rt5682_max98357a: use modern dai_link style
  ASoC: Intel: sof_rt5682: use modern dai_link style
  ASoC: soc-core: remove legacy style dai_link

 drivers/gpu/drm/vc4/vc4_hdmi.c                     |  19 +-
 include/sound/simple_card_utils.h                  |  20 +-
 include/sound/soc.h                                | 153 +++++++++------
 sound/soc/amd/acp-da7219-max98357a.c               |  42 ++--
 sound/soc/amd/acp-rt5645.c                         |  21 +-
 sound/soc/atmel/atmel-classd.c                     |  21 +-
 sound/soc/atmel/atmel-pdmic.c                      |  21 +-
 sound/soc/atmel/atmel_wm8904.c                     |  17 +-
 sound/soc/atmel/mikroe-proto.c                     |  21 +-
 sound/soc/atmel/sam9g20_wm8731.c                   |  22 ++-
 sound/soc/atmel/sam9x5_wm8731.c                    |  20 +-
 sound/soc/atmel/tse850-pcm5142.c                   |  13 +-
 sound/soc/au1x/db1000.c                            |  10 +-
 sound/soc/au1x/db1200.c                            |  50 +++--
 sound/soc/cirrus/edb93xx.c                         |  10 +-
 sound/soc/cirrus/simone.c                          |  10 +-
 sound/soc/cirrus/snappercl15.c                     |  11 +-
 sound/soc/fsl/efika-audio-fabric.c                 |  22 ++-
 sound/soc/fsl/eukrea-tlv320.c                      |  19 +-
 sound/soc/fsl/fsl-asoc-card.c                      |  47 +++--
 sound/soc/fsl/fsl_utils.c                          |   2 +-
 sound/soc/fsl/imx-audmix.c                         |  45 ++++-
 sound/soc/fsl/imx-es8328.c                         |  23 ++-
 sound/soc/fsl/imx-mc13783.c                        |  10 +-
 sound/soc/fsl/imx-sgtl5000.c                       |  23 ++-
 sound/soc/fsl/imx-spdif.c                          |  20 +-
 sound/soc/fsl/mpc8610_hpcd.c                       |  33 +++-
 sound/soc/fsl/mx27vis-aic32x4.c                    |  11 +-
 sound/soc/fsl/p1022_ds.c                           |  36 +++-
 sound/soc/fsl/p1022_rdk.c                          |  35 +++-
 sound/soc/fsl/pcm030-audio-fabric.c                |  20 +-
 sound/soc/fsl/phycore-ac97.c                       |  10 +-
 sound/soc/fsl/wm1133-ev1.c                         |  10 +-
 sound/soc/generic/audio-graph-card.c               |  30 +--
 sound/soc/generic/simple-card-utils.c              |  21 +-
 sound/soc/generic/simple-card.c                    |  39 ++--
 sound/soc/intel/boards/bdw-rt5677.c                |  22 ++-
 sound/soc/intel/boards/broadwell.c                 |  46 +++--
 sound/soc/intel/boards/bxt_da7219_max98357a.c      | 140 ++++++++------
 sound/soc/intel/boards/bxt_rt298.c                 | 129 +++++++------
 sound/soc/intel/boards/byt-max98090.c              |  10 +-
 sound/soc/intel/boards/byt-rt5640.c                |  10 +-
 sound/soc/intel/boards/bytcht_da7213.c             |  37 ++--
 sound/soc/intel/boards/bytcht_es8316.c             |  38 ++--
 sound/soc/intel/boards/bytcht_nocodec.c            |  30 +--
 sound/soc/intel/boards/bytcr_rt5640.c              |  43 +++--
 sound/soc/intel/boards/bytcr_rt5651.c              |  40 ++--
 sound/soc/intel/boards/cht_bsw_max98090_ti.c       |  32 ++--
 sound/soc/intel/boards/cht_bsw_nau8824.c           |  41 ++--
 sound/soc/intel/boards/cht_bsw_rt5645.c            |  42 ++--
 sound/soc/intel/boards/cht_bsw_rt5672.c            |  37 ++--
 sound/soc/intel/boards/glk_rt5682_max98357a.c      | 137 +++++++------
 sound/soc/intel/boards/haswell.c                   |  46 +++--
 sound/soc/intel/boards/kbl_da7219_max98357a.c      | 114 ++++++-----
 sound/soc/intel/boards/kbl_da7219_max98927.c       | 212 +++++++++------------
 sound/soc/intel/boards/kbl_rt5660.c                |  83 ++++----
 sound/soc/intel/boards/kbl_rt5663_max98927.c       | 185 +++++++++---------
 .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c  | 126 ++++++------
 sound/soc/intel/boards/skl_hda_dsp_common.c        |  66 ++++---
 sound/soc/intel/boards/skl_hda_dsp_generic.c       |   4 +-
 sound/soc/intel/boards/skl_nau88l25_max98357a.c    | 120 +++++++-----
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c      | 132 +++++++------
 sound/soc/intel/boards/skl_rt286.c                 | 118 ++++++------
 sound/soc/intel/boards/sof_rt5682.c                |  37 ++--
 sound/soc/intel/skylake/skl-pcm.c                  |   2 +-
 sound/soc/jz4740/qi_lb60.c                         |  10 +-
 sound/soc/kirkwood/armada-370-db.c                 |  42 ++--
 sound/soc/mediatek/mt2701/mt2701-cs42448.c         |  95 ++++++---
 sound/soc/mediatek/mt2701/mt2701-wm8960.c          |  34 ++--
 sound/soc/mediatek/mt6797/mt6797-mt6351.c          | 115 +++++++----
 sound/soc/mediatek/mt8173/mt8173-max98090.c        |  34 ++--
 sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c   |  51 ++---
 sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c   |  85 +++++----
 sound/soc/mediatek/mt8173/mt8173-rt5650.c          |  74 +++----
 sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 182 ++++++++++--------
 .../mt8183/mt8183-mt6358-ts3a227-max98357.c        | 168 ++++++++++------
 sound/soc/meson/axg-card.c                         |  57 ++++--
 sound/soc/mxs/mxs-sgtl5000.c                       |  27 ++-
 sound/soc/nuc900/nuc900-audio.c                    |  10 +-
 sound/soc/pxa/brownstone.c                         |  10 +-
 sound/soc/pxa/corgi.c                              |  10 +-
 sound/soc/pxa/e740_wm9705.c                        |  20 +-
 sound/soc/pxa/e750_wm9705.c                        |  20 +-
 sound/soc/pxa/e800_wm9712.c                        |  21 +-
 sound/soc/pxa/em-x270.c                            |  20 +-
 sound/soc/pxa/hx4700.c                             |  10 +-
 sound/soc/pxa/imote2.c                             |  11 +-
 sound/soc/pxa/magician.c                           |  22 ++-
 sound/soc/pxa/mioa701_wm9713.c                     |  20 +-
 sound/soc/pxa/palm27x.c                            |  20 +-
 sound/soc/pxa/poodle.c                             |  10 +-
 sound/soc/pxa/spitz.c                              |  10 +-
 sound/soc/pxa/tosa.c                               |  20 +-
 sound/soc/pxa/ttc-dkb.c                            |  10 +-
 sound/soc/pxa/z2.c                                 |  10 +-
 sound/soc/pxa/zylonite.c                           |  30 +--
 sound/soc/qcom/apq8016_sbc.c                       |  19 +-
 sound/soc/qcom/common.c                            |  33 +++-
 sound/soc/qcom/storm.c                             |  17 +-
 sound/soc/rockchip/rk3288_hdmi_analog.c            |  21 +-
 sound/soc/rockchip/rk3399_gru_sound.c              |  51 +++--
 sound/soc/rockchip/rockchip_max98090.c             |  17 +-
 sound/soc/rockchip/rockchip_rt5645.c               |  33 ++--
 sound/soc/samsung/arndale_rt5631.c                 |  25 ++-
 sound/soc/samsung/bells.c                          |  87 +++++----
 sound/soc/samsung/h1940_uda1380.c                  |  10 +-
 sound/soc/samsung/jive_wm8750.c                    |  10 +-
 sound/soc/samsung/littlemill.c                     |  19 +-
 sound/soc/samsung/lowland.c                        |  26 ++-
 sound/soc/samsung/neo1973_wm8753.c                 |  18 +-
 sound/soc/samsung/odroid.c                         |  29 ++-
 sound/soc/samsung/rx1950_uda1380.c                 |  11 +-
 sound/soc/samsung/s3c24xx_simtec_hermes.c          |  11 +-
 sound/soc/samsung/s3c24xx_simtec_tlv320aic23.c     |  11 +-
 sound/soc/samsung/s3c24xx_uda134x.c                |  10 +-
 sound/soc/samsung/smartq_wm8987.c                  |  10 +-
 sound/soc/samsung/smdk_spdif.c                     |  10 +-
 sound/soc/samsung/smdk_wm8580.c                    |  20 +-
 sound/soc/samsung/smdk_wm8994.c                    |  30 +--
 sound/soc/samsung/smdk_wm8994pcm.c                 |  10 +-
 sound/soc/samsung/snow.c                           |  40 ++--
 sound/soc/samsung/speyside.c                       |  26 ++-
 sound/soc/samsung/tm2_wm5110.c                     |  42 ++--
 sound/soc/samsung/tobermory.c                      |  10 +-
 sound/soc/sh/migor.c                               |  10 +-
 sound/soc/sh/sh7760-ac97.c                         |  11 +-
 sound/soc/sirf/sirf-audio.c                        |  13 +-
 sound/soc/soc-core.c                               | 149 +++------------
 sound/soc/soc-topology.c                           |  22 ++-
 sound/soc/sof/nocodec.c                            |  21 +-
 sound/soc/sof/topology.c                           |  20 +-
 sound/soc/sunxi/sun4i-codec.c                      |  20 +-
 sound/soc/tegra/tegra_alc5632.c                    |  37 ++--
 sound/soc/tegra/tegra_max98090.c                   |  17 +-
 sound/soc/tegra/tegra_rt5640.c                     |  17 +-
 sound/soc/tegra/tegra_rt5677.c                     |  37 ++--
 sound/soc/tegra/tegra_sgtl5000.c                   |  37 ++--
 sound/soc/tegra/tegra_wm8753.c                     |  17 +-
 sound/soc/tegra/tegra_wm8903.c                     |  17 +-
 sound/soc/tegra/tegra_wm9712.c                     |  14 +-
 sound/soc/tegra/trimslice.c                        |  19 +-
 sound/soc/ti/ams-delta.c                           |  10 +-
 sound/soc/ti/davinci-evm.c                         | 105 ++++++----
 sound/soc/ti/n810.c                                |  11 +-
 sound/soc/ti/omap-abe-twl6040.c                    |  36 +++-
 sound/soc/ti/omap-hdmi.c                           |  20 +-
 sound/soc/ti/omap-twl4030.c                        |  36 ++--
 sound/soc/ti/omap3pandora.c                        |  20 +-
 sound/soc/ti/osk5912.c                             |  11 +-
 sound/soc/ti/rx51.c                                |  23 ++-
 sound/soc/txx9/txx9aclc-generic.c                  |  10 +-
 sound/soc/ux500/mop500.c                           |  36 ++--
 152 files changed, 3382 insertions(+), 2344 deletions(-)

Comments

Pierre-Louis Bossart May 24, 2019, 3:58 p.m. UTC | #1
Hi Morimoto-san,

> These are for modern dai_link style support patches.
> [001/145] adds missing modern dai_link style for CPU.
> and others are switch to modern style from legacy style.
> Last patch removes legacy style.
> 
> These are based on mark/for-5.3 + v5.2-rc1
> 
> I hope these work well for all sound card, but I can't test for all.
> Please test these at each sound cards.

We're testing for Intel stuff w/ SOF.

One question: I try to enforce the use of checkpatch --strict to avoid 
different styles in the Intel contributions, and your series generates a 
ton of alignment warnings, e.g.

CHECK: Alignment should match open parenthesis
#45: FILE: sound/soc/intel/boards/sof_rt5682.c:373:
+		links[id].cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
  							"ssp%d-port",

CHECK: Alignment should match open parenthesis
#81: FILE: sound/soc/intel/boards/glk_rt5682_max98357a.c:378:
+SND_SOC_DAILINK_DEF(idisp3_codec,
+	DAILINK_COMP_ARRAY(COMP_CODEC("ehdaudio0D2", "intel-hdmi-hifi3")));

I am not too religious on style as long as there is a style.
I'd be fine if the expectation is that all the dailink definitions use a 
tab for readability (and it's a one-time change), but would like the 
functional code changes to be aligned to avoid future warnings.
Would that work for you? I can send you the Intel changes if that helps.

Thanks
-Pierre
Kuninori Morimoto May 27, 2019, 1:48 a.m. UTC | #2
Hi Pierre-Louis

Thank you for your feedback and test !

> > [001/145] adds missing modern dai_link style for CPU.
> > and others are switch to modern style from legacy style.
> > Last patch removes legacy style.
> > 
> > These are based on mark/for-5.3 + v5.2-rc1
> > 
> > I hope these work well for all sound card, but I can't test for all.
> > Please test these at each sound cards.
> 
> We're testing for Intel stuff w/ SOF.

Thanks !
I hope it works well

> One question: I try to enforce the use of checkpatch --strict to avoid
> different styles in the Intel contributions, and your series generates
> a ton of alignment warnings, e.g.
> 
> CHECK: Alignment should match open parenthesis
> #45: FILE: sound/soc/intel/boards/sof_rt5682.c:373:
> +		links[id].cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
>  							"ssp%d-port",
> 
> CHECK: Alignment should match open parenthesis
> #81: FILE: sound/soc/intel/boards/glk_rt5682_max98357a.c:378:
> +SND_SOC_DAILINK_DEF(idisp3_codec,
> +	DAILINK_COMP_ARRAY(COMP_CODEC("ehdaudio0D2", "intel-hdmi-hifi3")));
> 
> I am not too religious on style as long as there is a style.
> I'd be fine if the expectation is that all the dailink definitions use
> a tab for readability (and it's a one-time change), but would like the
> functional code changes to be aligned to avoid future warnings.
> Would that work for you? I can send you the Intel changes if that helps.

Ahh, yes, it is using 1 tag only and not aligned to open parenthesis.
But, if it aligned to open parenthesis, then, it will be 80 char over
warning instead.
# ?? or does your "functional code changes" means "fixup checkpatch.pl" ?

But, yes, can you send me the changes ?

Thank you for your help !!
Best regards
---
Kuninori Morimoto
Pierre-Louis Bossart May 28, 2019, 3:34 p.m. UTC | #3
> Ahh, yes, it is using 1 tag only and not aligned to open parenthesis.
> But, if it aligned to open parenthesis, then, it will be 80 char over
> warning instead.
> # ?? or does your "functional code changes" means "fixup checkpatch.pl" ?
> 
> But, yes, can you send me the changes ?

I'll send you suggested changes, I saw other cases where we want to use 
dmic_codec instead of dmic01_codec.
Small potatoes really, this is a really nice work you've been doing!