mbox series

[0/2] To be included in KS 1.0

Message ID 20190530131330.21701-1-ykaradzhov@vmware.com (mailing list archive)
Headers show
Series To be included in KS 1.0 | expand

Message

Yordan Karadzhov May 30, 2019, 1:13 p.m. UTC
The patch-set contains modifications motivated by the attempt to
implement a standalone version of the NumPy data interface. Those
changes do improve the code but strictly speaking are not compulsory
for KS 1.0. Nevertheless, I would prefer to get those patches upstream
a.s.a.p. Versions of the two patches have been send already several
times as part of different other patch-sets.

Yordan Karadzhov (2):
  kernel-shark: Add new dataloading method to be used by the NumPu
    interface
  kernel-shark: Use full paths for non-standard library headers

 include/trace-cmd/trace-cmd.h         |   2 +-
 include/traceevent/event-parse.h      |   2 +-
 kernel-shark/CMakeLists.txt           |   3 +-
 kernel-shark/build/FindTraceCmd.cmake |  44 ++++----
 kernel-shark/src/libkshark-plugin.h   |   2 +-
 kernel-shark/src/libkshark.c          | 139 ++++++++++++++++++++++++++
 kernel-shark/src/libkshark.h          |  16 ++-
 7 files changed, 172 insertions(+), 36 deletions(-)

Comments

Steven Rostedt June 5, 2019, 1:14 p.m. UTC | #1
On Thu, 30 May 2019 16:13:28 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> The patch-set contains modifications motivated by the attempt to
> implement a standalone version of the NumPy data interface. Those
> changes do improve the code but strictly speaking are not compulsory
> for KS 1.0. Nevertheless, I would prefer to get those patches upstream
> a.s.a.p. Versions of the two patches have been send already several
> times as part of different other patch-sets.
> 
> Yordan Karadzhov (2):
>   kernel-shark: Add new dataloading method to be used by the NumPu
>     interface
>   kernel-shark: Use full paths for non-standard library headers

Looks good!

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> 
>  include/trace-cmd/trace-cmd.h         |   2 +-
>  include/traceevent/event-parse.h      |   2 +-
>  kernel-shark/CMakeLists.txt           |   3 +-
>  kernel-shark/build/FindTraceCmd.cmake |  44 ++++----
>  kernel-shark/src/libkshark-plugin.h   |   2 +-
>  kernel-shark/src/libkshark.c          | 139 ++++++++++++++++++++++++++
>  kernel-shark/src/libkshark.h          |  16 ++-
>  7 files changed, 172 insertions(+), 36 deletions(-)
>