| Message ID | 20190612181927.608151291@goodmis.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | trace-cmd: Fix some bugs that include issues with --max-graph-depth | expand |
On Wed, Jun 12, 2019 at 9:21 PM Steven Rostedt <rostedt@goodmis.org> wrote: > > > Some last minute bugs that were found and fixed. > > Steven Rostedt (VMware) (3): > trace-cmd: Fix typo in Makefile bidr to bdir > trace-cmd: Have --max-graph-depth only be part of instance > trace-cmd: Check the return of get_file_content() before calling add_reset_file() > > ---- > tracecmd/Makefile | 2 +- > tracecmd/include/trace-local.h | 2 ++ > tracecmd/trace-record.c | 33 +++++++++++++++++++-------------- > 3 files changed, 22 insertions(+), 15 deletions(-) Looks good to me. Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com> Cheers, --Slavi
On Thu, 13 Jun 2019 14:51:48 +0000 Slavomir Kaslev <kaslevs@vmware.com> wrote: > On Wed, Jun 12, 2019 at 9:21 PM Steven Rostedt <rostedt@goodmis.org> wrote: > > > > > > Some last minute bugs that were found and fixed. > > > > Steven Rostedt (VMware) (3): > > trace-cmd: Fix typo in Makefile bidr to bdir > > trace-cmd: Have --max-graph-depth only be part of instance > > trace-cmd: Check the return of get_file_content() before calling add_reset_file() > > > > ---- > > tracecmd/Makefile | 2 +- > > tracecmd/include/trace-local.h | 2 ++ > > tracecmd/trace-record.c | 33 +++++++++++++++++++-------------- > > 3 files changed, 22 insertions(+), 15 deletions(-) > > Looks good to me. > > Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com> > Thanks Slavomir and Tzvetomir. I'll add these patches now with both of your reviewed-bys. -- Steve
Some last minute bugs that were found and fixed. Steven Rostedt (VMware) (3): trace-cmd: Fix typo in Makefile bidr to bdir trace-cmd: Have --max-graph-depth only be part of instance trace-cmd: Check the return of get_file_content() before calling add_reset_file() ---- tracecmd/Makefile | 2 +- tracecmd/include/trace-local.h | 2 ++ tracecmd/trace-record.c | 33 +++++++++++++++++++-------------- 3 files changed, 22 insertions(+), 15 deletions(-)