mbox series

[V3,0/2] selinux: Remove legacy local boolean and user code

Message ID 20190624180229.9573-1-richard_c_haines@btinternet.com (mailing list archive)
Headers show
Series selinux: Remove legacy local boolean and user code | expand

Message

Richard Haines June 24, 2019, 6:02 p.m. UTC
I've removed the legacy code as discussed and seems to work okay when
loading policy on Fedora 30 & Rawhide (they both boot as well).
Note: I cannot test any other releases.

Tested downgrading policy to 24 okay using load_policy(8).

V2 Changes:
Updated as requested in [1].
Add manpages.
V3 Change:
Fix deprecated_funcs.c WARN() messages in Patch 1.

[1] https://lore.kernel.org/selinux/18e772cde0ed8f4d83752a9957ad2a3a11ecad8c.camel@btinternet.com/

Richard Haines (2):
  selinux: Remove legacy local boolean and user code
  selinux: Update manpages after removing legacy boolean and user code

 libselinux/include/selinux/selinux.h          |  18 +-
 libselinux/man/man3/security_load_booleans.3  |  12 +-
 .../man/man3/selinux_binary_policy_path.3     |   7 +-
 libselinux/man/man3/selinux_booleans_path.3   |   1 -
 libselinux/man/man5/booleans.5                |  80 ----
 libselinux/man/man5/local.users.5             |  68 ----
 libselinux/man/ru/man5/booleans.5             |  83 -----
 libselinux/man/ru/man5/local.users.5          |  72 ----
 libselinux/src/booleans.c                     | 225 +-----------
 libselinux/src/file_path_suffixes.h           |   2 +
 libselinux/src/load_policy.c                  | 100 +----
 libselinux/src/selinux_config.c               |   9 +-
 libselinux/src/selinux_internal.h             |   1 -
 libsepol/include/sepol/booleans.h             |  15 +-
 libsepol/include/sepol/policydb/services.h    |   6 -
 libsepol/include/sepol/users.h                |  13 +-
 libsepol/man/man3/sepol_genbools.3            |  30 --
 libsepol/man/man3/sepol_genusers.3            |  54 ---
 libsepol/src/deprecated_funcs.c               |  50 +++
 libsepol/src/genbools.c                       | 279 --------------
 libsepol/src/genusers.c                       | 343 ------------------
 policycoreutils/load_policy/load_policy.c     |   2 +-
 policycoreutils/man/man5/selinux_config.5     |  15 +-
 policycoreutils/man/ru/man5/selinux_config.5  |  11 +-
 24 files changed, 86 insertions(+), 1410 deletions(-)
 delete mode 100644 libselinux/man/man3/selinux_booleans_path.3
 delete mode 100644 libselinux/man/man5/booleans.5
 delete mode 100644 libselinux/man/man5/local.users.5
 delete mode 100644 libselinux/man/ru/man5/booleans.5
 delete mode 100644 libselinux/man/ru/man5/local.users.5
 delete mode 100644 libsepol/man/man3/sepol_genbools.3
 delete mode 100644 libsepol/man/man3/sepol_genusers.3
 create mode 100644 libsepol/src/deprecated_funcs.c
 delete mode 100644 libsepol/src/genbools.c
 delete mode 100644 libsepol/src/genusers.c

Comments

Nicolas Iooss July 29, 2019, 10:21 p.m. UTC | #1
On Mon, Jun 24, 2019 at 8:25 PM Richard Haines
<richard_c_haines@btinternet.com> wrote:
>
> I've removed the legacy code as discussed and seems to work okay when
> loading policy on Fedora 30 & Rawhide (they both boot as well).
> Note: I cannot test any other releases.
>
> Tested downgrading policy to 24 okay using load_policy(8).
>
> V2 Changes:
> Updated as requested in [1].
> Add manpages.
> V3 Change:
> Fix deprecated_funcs.c WARN() messages in Patch 1.
>
> [1] https://lore.kernel.org/selinux/18e772cde0ed8f4d83752a9957ad2a3a11ecad8c.camel@btinternet.com/

Hello,
As these patches have been around for more than a month without any
complain and they looked good to me, I merged them.

Thanks,
Nicolas

> Richard Haines (2):
>   selinux: Remove legacy local boolean and user code
>   selinux: Update manpages after removing legacy boolean and user code
>
>  libselinux/include/selinux/selinux.h          |  18 +-
>  libselinux/man/man3/security_load_booleans.3  |  12 +-
>  .../man/man3/selinux_binary_policy_path.3     |   7 +-
>  libselinux/man/man3/selinux_booleans_path.3   |   1 -
>  libselinux/man/man5/booleans.5                |  80 ----
>  libselinux/man/man5/local.users.5             |  68 ----
>  libselinux/man/ru/man5/booleans.5             |  83 -----
>  libselinux/man/ru/man5/local.users.5          |  72 ----
>  libselinux/src/booleans.c                     | 225 +-----------
>  libselinux/src/file_path_suffixes.h           |   2 +
>  libselinux/src/load_policy.c                  | 100 +----
>  libselinux/src/selinux_config.c               |   9 +-
>  libselinux/src/selinux_internal.h             |   1 -
>  libsepol/include/sepol/booleans.h             |  15 +-
>  libsepol/include/sepol/policydb/services.h    |   6 -
>  libsepol/include/sepol/users.h                |  13 +-
>  libsepol/man/man3/sepol_genbools.3            |  30 --
>  libsepol/man/man3/sepol_genusers.3            |  54 ---
>  libsepol/src/deprecated_funcs.c               |  50 +++
>  libsepol/src/genbools.c                       | 279 --------------
>  libsepol/src/genusers.c                       | 343 ------------------
>  policycoreutils/load_policy/load_policy.c     |   2 +-
>  policycoreutils/man/man5/selinux_config.5     |  15 +-
>  policycoreutils/man/ru/man5/selinux_config.5  |  11 +-
>  24 files changed, 86 insertions(+), 1410 deletions(-)
>  delete mode 100644 libselinux/man/man3/selinux_booleans_path.3
>  delete mode 100644 libselinux/man/man5/booleans.5
>  delete mode 100644 libselinux/man/man5/local.users.5
>  delete mode 100644 libselinux/man/ru/man5/booleans.5
>  delete mode 100644 libselinux/man/ru/man5/local.users.5
>  delete mode 100644 libsepol/man/man3/sepol_genbools.3
>  delete mode 100644 libsepol/man/man3/sepol_genusers.3
>  create mode 100644 libsepol/src/deprecated_funcs.c
>  delete mode 100644 libsepol/src/genbools.c
>  delete mode 100644 libsepol/src/genusers.c
>
> --
> 2.21.0
>