[RFC,v2,00/13] example implementation of revwalk tutorial
mbox series

Message ID 20190626235032.177551-1-emilyshaffer@google.com
Headers show
Series
  • example implementation of revwalk tutorial
Related show

Message

Emily Shaffer June 26, 2019, 11:50 p.m. UTC
Since r1, made some significant changes.

 - Added a commit for counting the 'omitted' list, to match the new
   section added to the tutorial.
 - Added significant comments to allow the sample to better stand on its
   own.
 - Fixed style issues (die() formatting, etc)
 - Distinguished between human- and machine-readable output with
   trace_printf() and printf(), to turn the command into plumbing.
 - More changes as mentioned in the tutorial patch.

Thanks.
 - Emily

Emily Shaffer (13):
  walken: add infrastructure for revwalk demo
  walken: add usage to enable -h
  walken: add placeholder to initialize defaults
  walken: add handler to git_config
  walken: configure rev_info and prepare for walk
  walken: perform our basic revision walk
  walken: filter for authors from gmail address
  walken: demonstrate various topographical sorts
  walken: demonstrate reversing a revision walk list
  walken: add unfiltered object walk from HEAD
  walken: add filtered object walk
  walken: count omitted objects
  walken: reverse the object walk order

 Makefile         |   1 +
 builtin.h        |   1 +
 builtin/walken.c | 290 +++++++++++++++++++++++++++++++++++++++++++++++
 git.c            |   1 +
 4 files changed, 293 insertions(+)
 create mode 100644 builtin/walken.c

Comments

Emily Shaffer June 27, 2019, 10:56 p.m. UTC | #1
On Wed, Jun 26, 2019 at 04:50:19PM -0700, Emily Shaffer wrote:
> Since r1, made some significant changes.
> 
>  - Added a commit for counting the 'omitted' list, to match the new
>    section added to the tutorial.
>  - Added significant comments to allow the sample to better stand on its
>    own.
>  - Fixed style issues (die() formatting, etc)
>  - Distinguished between human- and machine-readable output with
>    trace_printf() and printf(), to turn the command into plumbing.
>  - More changes as mentioned in the tutorial patch.
> 
> Thanks.
>  - Emily

I have a v3 ready with changes based on Eric's suggestions. However,
since they're almost all verbatim changes, I'm going to hold off on
sending it for a couple days to see if anybody else wants to peek
though. I'll likely be sending v3 on Monday.

 - Emily