[0/5] Btrfs: fixes for inode cache (-o inode_cache)
mbox series

Message ID 20190704152400.20614-1-fdmanana@kernel.org
Headers show
Series
  • Btrfs: fixes for inode cache (-o inode_cache)
Related show

Message

Filipe Manana July 4, 2019, 3:24 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Just a small set of fixes for the inode cache feature, mostly hangs due to
missing wakeups or incomplete error handling, as well as an inode block
reserve leak when hitting ENOSPC.

Filipe Manana (5):
  Btrfs: fix hang when loading existing inode cache off disk
  Btrfs: fix inode cache block reserve leak on failure to allocate data
    space
  Btrfs: fix inode cache waiters hanging on failure to start caching
    thread
  Btrfs: fix inode cache waiters hanging on path allocation failure
  Btrfs: wake up inode cache waiters sooner to reduce waiting time

 fs/btrfs/inode-map.c | 30 ++++++++++++++++++++++++------
 1 file changed, 24 insertions(+), 6 deletions(-)

Comments

David Sterba July 31, 2019, 5:39 p.m. UTC | #1
On Thu, Jul 04, 2019 at 04:24:00PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Just a small set of fixes for the inode cache feature, mostly hangs due to
> missing wakeups or incomplete error handling, as well as an inode block
> reserve leak when hitting ENOSPC.

Thanks for the fixes, all added to misc-next. The feature is rarely used
and the manual page discrourages that too, only in a very special case.
I personally would like to deprecate it and delete completely, for
several reasons, so I suggest you don't spend too much time on it.