| Message ID | 20190709210620.15805-1-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show
Return-Path: <intel-gfx-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7BB98138D for <patchwork-intel-gfx@patchwork.kernel.org>; Tue, 9 Jul 2019 21:06:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D4E528870 for <patchwork-intel-gfx@patchwork.kernel.org>; Tue, 9 Jul 2019 21:06:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EE7D28891; Tue, 9 Jul 2019 21:06:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,HK_RANDOM_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 08ABF28870 for <patchwork-intel-gfx@patchwork.kernel.org>; Tue, 9 Jul 2019 21:06:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03AD96E061; Tue, 9 Jul 2019 21:06:25 +0000 (UTC) X-Original-To: Intel-gfx@lists.freedesktop.org Delivered-To: Intel-gfx@lists.freedesktop.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 611E089E57 for <Intel-gfx@lists.freedesktop.org>; Tue, 9 Jul 2019 21:06:24 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 14:06:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,472,1557212400"; d="scan'208";a="364267283" Received: from dawalker-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.251.80.131]) by fmsmga005.fm.intel.com with ESMTP; 09 Jul 2019 14:06:23 -0700 From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Date: Tue, 9 Jul 2019 22:06:16 +0100 Message-Id: <20190709210620.15805-1-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 0/4] MCR fixes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
| Series | MCR fixes | expand |
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> A few bugs in programming the MCR register sneaked in past review. First of all fls() usage is wrong and suffers from off-by-one problem. Secondly the assert in WaProgramMgsrForL3BankSpecificMmioReads is also wrong due inverted logic. With MCR programming fixed we can stop ignoring the engine workarounds verification of GEN8_L3SQCREG4. Tvrtko Ursulin (4): drm/i915: Fix GEN8_MCR_SELECTOR programming drm/i915: Fix WaProgramMgsrForL3BankSpecificMmioReads drm/i915: Move intel_calculate_mcr_s_ss_select to intel_sseu.c drm/i915/icl: Verify engine workarounds in GEN8_L3SQCREG4 drivers/gpu/drm/i915/gt/intel_engine_cs.c | 19 -------- drivers/gpu/drm/i915/gt/intel_sseu.c | 24 ++++++++++ drivers/gpu/drm/i915/gt/intel_sseu.h | 2 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 53 ++++++++------------- drivers/gpu/drm/i915/i915_drv.h | 2 - 5 files changed, 45 insertions(+), 55 deletions(-)