From patchwork Thu Jul 11 09:05:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend Van Spriel X-Patchwork-Id: 11039455 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 66B9A6C5 for ; Thu, 11 Jul 2019 09:05:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57154288BC for ; Thu, 11 Jul 2019 09:05:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 485DE28A5B; Thu, 11 Jul 2019 09:05:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E0B44288BC for ; Thu, 11 Jul 2019 09:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbfGKJFX (ORCPT ); Thu, 11 Jul 2019 05:05:23 -0400 Received: from rnd-relay.smtp.broadcom.com ([192.19.229.170]:59742 "EHLO rnd-relay.smtp.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfGKJFW (ORCPT ); Thu, 11 Jul 2019 05:05:22 -0400 Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 25D6130C002; Thu, 11 Jul 2019 02:05:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 25D6130C002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1562835921; bh=g/LMgTPx7L1+ZSVVf/Oczyafq1NFh+aHznOCzuuukKI=; h=From:To:Cc:Subject:Date:From; b=DuWF8zM4IIHXvDvsbHhl6BybBzpHA+B7YLV1NLiHUVon4OblNrajkhu4waQlhLKQe +mD2saXtpvCejWLq+lqYPevJL2HevUkSDS4yt5y0exJ6nmu1ZeVUmg8MWD4rw5gBVz eqpsk+EOBNsIkUhHgJ/qThf0syOHIAFyqe2jjR80= Received: from bld-bun-01.bun.broadcom.com (bld-bun-01.bun.broadcom.com [10.176.128.83]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 1FD5760D22; Thu, 11 Jul 2019 02:05:21 -0700 (PDT) Received: by bld-bun-01.bun.broadcom.com (Postfix, from userid 25152) id BAAC7B03087; Thu, 11 Jul 2019 11:05:19 +0200 (CEST) From: Arend van Spriel To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Arend van Spriel Subject: [PATCH 0/7] brcmfmac: rework probe/attach sequence Date: Thu, 11 Jul 2019 11:05:05 +0200 Message-Id: <1562835912-1404-1-git-send-email-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 1.9.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The brcmfmac driver spews some error message upon unloading and Stefan Wahren was wondering whether it could be cleaned up. Related to this was a recent fix for NULL pointer deref. That fix introduced a construct that added to the itch to rework the probe sequence. So this series reverts commit 5cdb0ef6144f ("brcmfmac: fix NULL pointer derefence during USB disconnect"). The changes in this series are: * reorder brcmf_detach() code. * avoid firmware interaction when bus is down. * remove strlcpy() before issueing firmware version iovar. This series applies to the master branch of the wireless-drivers-next repository. Arend van Spriel (7): Revert "brcmfmac: fix NULL pointer derefence during USB disconnect" brcmfmac: change the order of things in brcmf_detach() brcmfmac: avoid firmware command in brcmf_netdev_open() when bus is down brcmfmac: clear events in brcmf_fweh_detach() will always fail brcmfmac: avoid firmware commands when bus is down brcmfmac: simply remove flowring if bus is down brcmfmac: remove unnecessary strlcpy() upon obtaining "ver" iovar .../wireless/broadcom/brcm80211/brcmfmac/bcdc.c | 11 ++------ .../wireless/broadcom/brcm80211/brcmfmac/bcdc.h | 6 ++--- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 23 +++++++++-------- .../wireless/broadcom/brcm80211/brcmfmac/common.c | 1 - .../wireless/broadcom/brcm80211/brcmfmac/core.c | 30 +++++++++++----------- .../wireless/broadcom/brcm80211/brcmfmac/fweh.c | 9 ------- .../broadcom/brcm80211/brcmfmac/fwsignal.c | 16 +++--------- .../broadcom/brcm80211/brcmfmac/fwsignal.h | 3 +-- .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 7 +++++ .../wireless/broadcom/brcm80211/brcmfmac/proto.c | 10 ++------ .../wireless/broadcom/brcm80211/brcmfmac/proto.h | 3 +-- 11 files changed, 47 insertions(+), 72 deletions(-) --- 1.9.1