From patchwork Thu Jul 18 23:57:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Iuliana Prodan X-Patchwork-Id: 11049679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 43F6A746 for ; Thu, 18 Jul 2019 23:58:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33001288C9 for ; Thu, 18 Jul 2019 23:58:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2639B288D0; Thu, 18 Jul 2019 23:58:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD229288C9 for ; Thu, 18 Jul 2019 23:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726391AbfGRX6S (ORCPT ); Thu, 18 Jul 2019 19:58:18 -0400 Received: from inva020.nxp.com ([92.121.34.13]:54474 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbfGRX6R (ORCPT ); Thu, 18 Jul 2019 19:58:17 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 420721A0244; Fri, 19 Jul 2019 01:58:12 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 34D141A0135; Fri, 19 Jul 2019 01:58:12 +0200 (CEST) Received: from lorenz.ea.freescale.net (lorenz.ea.freescale.net [10.171.71.5]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id CBF10205D1; Fri, 19 Jul 2019 01:58:11 +0200 (CEST) From: Iuliana Prodan To: Herbert Xu , Horia Geanta , Aymen Sghaier Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx Subject: [PATCH v2 00/14] crypto: caam - fixes for kernel v5.3 Date: Fri, 19 Jul 2019 02:57:42 +0300 Message-Id: <1563494276-3993-1-git-send-email-iuliana.prodan@nxp.com> X-Mailer: git-send-email 2.1.0 MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The series solves: - the failures found with fuzz testing; - resources clean-up on caampkc/caamrng exit path. The first 10 patches solve the issues found with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled. They modify the drivers to provide a valid error (and not the hardware error ID) to the user, via completion callbacks. They check key length, assoclen, authsize and input size to solve the fuzz tests that expect -EINVAL to be returned when these values are not valid. The next 4 patches check the algorithm registration for caampkc module and unregister it only if the registration was successful. Also, on caampkc/caamrng, the exit point function is executed only if the registration was successful to avoid double freeing of resources in case the initialization function failed. --- Changes since V1: - update commit description for ("crypto: caam - update IV only when crypto operation succeeds"). --- Horia Geantă (5): crypto: caam/qi - fix error handling in ERN handler crypto: caam - fix return code in completion callbacks crypto: caam - update IV only when crypto operation succeeds crypto: caam - keep both virtual and dma key addresses crypto: caam - fix DKP for certain key lengths Iuliana Prodan (9): crypto: caam - check key length crypto: caam - check authsize crypto: caam - check assoclen crypto: caam - check zero-length input crypto: caam - update rfc4106 sh desc to support zero length input crypto: caam - free resources in case caam_rng registration failed crypto: caam - execute module exit point only if necessary crypto: caam - unregister algorithm only if the registration succeeded crypto: caam - change return value in case CAAM has no MDHA drivers/crypto/caam/Makefile | 2 +- drivers/crypto/caam/caamalg.c | 226 ++++++++++++++++---------- drivers/crypto/caam/caamalg_desc.c | 46 ++++-- drivers/crypto/caam/caamalg_desc.h | 2 +- drivers/crypto/caam/caamalg_qi.c | 222 +++++++++++++++---------- drivers/crypto/caam/caamalg_qi2.c | 316 ++++++++++++++++++++++++------------ drivers/crypto/caam/caamhash.c | 113 ++++++++----- drivers/crypto/caam/caamhash_desc.c | 5 +- drivers/crypto/caam/caamhash_desc.h | 2 +- drivers/crypto/caam/caampkc.c | 80 ++++++--- drivers/crypto/caam/caamrng.c | 17 +- drivers/crypto/caam/common_if.c | 88 ++++++++++ drivers/crypto/caam/common_if.h | 19 +++ drivers/crypto/caam/desc_constr.h | 34 ++-- drivers/crypto/caam/error.c | 61 ++++--- drivers/crypto/caam/error.h | 2 +- drivers/crypto/caam/key_gen.c | 5 +- drivers/crypto/caam/qi.c | 10 +- drivers/crypto/caam/regs.h | 1 + 19 files changed, 851 insertions(+), 400 deletions(-) create mode 100644 drivers/crypto/caam/common_if.c create mode 100644 drivers/crypto/caam/common_if.h