[0/2] Revert GuC by default
mbox series

Message ID 20190719094845.6242-1-tvrtko.ursulin@linux.intel.com
Headers show
Series
  • Revert GuC by default
Related show

Message

Tvrtko Ursulin July 19, 2019, 9:48 a.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

It seems absence of GuC fimrware breaks the boot in a bad way:

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/?
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log

Tvrtko Ursulin (2):
  Revert "drm/i915/guc: Turn on GuC/HuC auto mode"
  Revert "drm/i915: Update description of i915.enable_guc modparam"

 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Joonas Lahtinen July 19, 2019, 9:52 a.m. UTC | #1
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas

Quoting Tvrtko Ursulin (2019-07-19 12:48:43)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> It seems absence of GuC fimrware breaks the boot in a bad way:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/?
> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log
> 
> Tvrtko Ursulin (2):
>   Revert "drm/i915/guc: Turn on GuC/HuC auto mode"
>   Revert "drm/i915: Update description of i915.enable_guc modparam"
> 
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Michal Wajdeczko July 19, 2019, 11:09 a.m. UTC | #2
On Fri, 19 Jul 2019 11:48:43 +0200, Tvrtko Ursulin  
<tvrtko.ursulin@linux.intel.com> wrote:

> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It seems absence of GuC fimrware breaks the boot in a bad way:
>
> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/?
> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log

Hmm, for me looks like boot is not prepared to driver probe failure.

I guess this needs to be fixed separately, as CI.BAT **SUCCESS** is
really misleading here https://patchwork.freedesktop.org/series/63931/

>
> Tvrtko Ursulin (2):
>   Revert "drm/i915/guc: Turn on GuC/HuC auto mode"
>   Revert "drm/i915: Update description of i915.enable_guc modparam"

Maybe instead of reverting above patches we can just apply two fixes:

1. Ignore HuC firmware fetch/load errors
User space is always relying on HUC_STATUS param so we should really
never treat HuC failures so seriously.

2. Ignore GuC firmware fetch/load errors if GuC submission was not enabled
If we use GuC just to authenticate the HuC, then we can ignore GuC errors,

Later on, once we are closer to re-enabling GuC submission feature, we can
add more patches to change current 'fail on GuC error' behavior:

3. Ignore GuC firmware errors if GuC submission was auto-enabled
We can still fallback to execlist at the cost of some resources lost
for GuC data (but maybe this can be reclaimed as well)

4. Keep driver loaded on GuC fw errors if GuC submission was explicitly  
enabled
There was already some approach for that:
	https://patchwork.freedesktop.org/series/58294/
just needs some refreshing

Michal

>
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
Tvrtko Ursulin July 19, 2019, 2:47 p.m. UTC | #3
On 19/07/2019 12:09, Patchwork wrote:
> == Series Details ==
> 
> Series: Revert GuC by default
> URL   : https://patchwork.freedesktop.org/series/63934/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6509 -> Patchwork_13700
> ====================================================
> 
> Summary
> -------
> 
>    **SUCCESS**
> 
>    No regressions found.
> 
>    External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/
> 
> Known issues
> ------------
> 
>    Here are the changes found in Patchwork_13700 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>    * igt@gem_ctx_create@basic-files:
>      - fi-icl-u3:          [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u3/igt@gem_ctx_create@basic-files.html
>     [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u3/igt@gem_ctx_create@basic-files.html
> 
>    * igt@i915_selftest@live_contexts:
>      - fi-skl-iommu:       [PASS][3] -> [INCOMPLETE][4] ([fdo#111050])
>     [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html
>     [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-skl-iommu/igt@i915_selftest@live_contexts.html
> 
>    * igt@kms_frontbuffer_tracking@basic:
>      - fi-icl-u2:          [PASS][5] -> [FAIL][6] ([fdo#103167])
>     [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
>     [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
> 
>    
> #### Possible fixes ####
> 
>    * igt@debugfs_test@read_all_entries:
>      - {fi-icl-u4}:        [DMESG-WARN][7] ([fdo#105602]) -> [PASS][8]
>     [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u4/igt@debugfs_test@read_all_entries.html
>     [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u4/igt@debugfs_test@read_all_entries.html
> 
>    * igt@i915_selftest@live_client:
>      - fi-icl-dsi:         [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
>     [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html
>     [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-dsi/igt@i915_selftest@live_client.html
> 
>    
> #### Warnings ####
> 
>    * igt@i915_pm_rpm@basic-pci-d3-state:
>      - fi-kbl-guc:         [SKIP][11] ([fdo#109271]) -> [FAIL][12] ([fdo#107707])
>     [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
>     [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
> 
>    
>    {name}: This element is suppressed. This means it is ignored when computing
>            the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>    [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>    [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
>    [fdo#107707]: https://bugs.freedesktop.org/show_bug.cgi?id=107707
>    [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>    [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
>    [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>    [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050
> 
> 
> Participating hosts (52 -> 46)
> ------------------------------
> 
>    Missing    (6): fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus
> 
> 
> Build changes
> -------------
> 
>    * Linux: CI_DRM_6509 -> Patchwork_13700
> 
>    CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_13700: 397611e1bc62a8496215128aec25d651b0830751 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Kernel 32bit build ==
> 
> Warning: Kernel 32bit buildtest failed:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/build_32bit.log
> 
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/atomic/check-atomics.sh
>    CHK     include/generated/compile.h
> Kernel: arch/x86/boot/bzImage is ready  (#1)
>    Building modules, stage 2.
>    MODPOST 112 modules
> ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
> Makefile:1287: recipe for target 'modules' failed
> make: *** [modules] Error 2
> 
> 
> == Linux commits ==
> 
> 397611e1bc62 Revert "drm/i915: Update description of i915.enable_guc modparam"
> 5e4d613993b4 Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

I've pushed this for now per agreement with Joonas and next week we can 
see what the proper fix is.

Regards,

Tvrtko

> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/
>