mbox series

[v6,00/14] Add support for io_uring

Message ID 20190719133530.28688-1-mehta.aaru20@gmail.com (mailing list archive)
Headers show
Series Add support for io_uring | expand

Message

Aarushi Mehta July 19, 2019, 1:35 p.m. UTC 
This patch series adds support for the newly developed io_uring Linux AIO
interface. Linux io_uring is faster than Linux's AIO asynchronous I/O code,
offers efficient buffered asynchronous I/O support, the ability to do I/O
without performing a system call via polled I/O, and other efficiency enhancements.

Testing it requires a host kernel (5.1+) and the liburing library.
Use the option -drive aio=io_uring to enable it.

Benchmarks for the system at https://github.com/rooshm/benchmarks
io_uring has similar performance as libaio but supports cache=writeback.
Further performance enhancement will be implemented

There is currently an -EIO output when guests are booted from io_uring
disks for the second time with clean shutdowns that is being investigated.

v6:
- add slow path for short-read
- hooks up fsync
- enables qemu-iotests with aio options
- adds bdrv_parse_aio

v5:
- Adds completion polling
- Extends qemu-io
- Adds qemu-iotest

v4:
- Add error handling
- Add trace events
- Remove aio submission based code

Aarushi Mehta (14):
  configure: permit use of io_uring
  qapi/block-core: add option for io_uring
  block/block: add BDRV flag for io_uring
  block/io_uring: implements interfaces for io_uring
  stubs: add stubs for io_uring interface
  util/async: add aio interfaces for io_uring
  blockdev: accept io_uring as option
  block/file-posix.c: extend to use io_uring
  block: add trace events for io_uring
  block/io_uring: adds userspace completion polling
  qemu-io: adds option to use aio engine
  qemu-img: adds option to use aio engine
  qemu-nbd: adds option for aio engines
  tests/qemu-iotest: enable testing with qemu-io aio options

 MAINTAINERS                  |   8 +
 block.c                      |  22 ++
 block/Makefile.objs          |   3 +
 block/file-posix.c           |  99 ++++++--
 block/io_uring.c             | 439 +++++++++++++++++++++++++++++++++++
 block/trace-events           |  12 +
 blockdev.c                   |  12 +-
 configure                    |  27 +++
 include/block/aio.h          |  16 +-
 include/block/block.h        |   2 +
 include/block/raw-aio.h      |  12 +
 qapi/block-core.json         |   4 +-
 qemu-img.c                   |  11 +-
 qemu-io.c                    |  25 +-
 qemu-nbd.c                   |  12 +-
 stubs/Makefile.objs          |   1 +
 stubs/io_uring.c             |  32 +++
 tests/qemu-iotests/check     |  14 +-
 tests/qemu-iotests/common.rc |  10 +
 util/async.c                 |  36 +++
 20 files changed, 746 insertions(+), 51 deletions(-)
 create mode 100644 block/io_uring.c
 create mode 100644 stubs/io_uring.c

Comments

no-reply@patchew.org July 19, 2019, 10:33 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190719133530.28688-1-mehta.aaru20@gmail.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      hw/arm/trace.o
  CC      hw/audio/trace.o
In file included from block/trace.c:4:
/tmp/qemu-test/build/block/trace.h:1704:96: error: expected ')'
        qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
                                                                                               ^
/tmp/qemu-test/build/block/trace.h:1704:17: note: to match this '('
        qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
                ^
/tmp/qemu-test/build/block/trace.h:1704:98: error: missing terminating '"' character [-Werror,-Winvalid-pp-token]
        qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
                                                                                                 ^
  CC      hw/block/trace.o


The full log is available at
http://patchew.org/logs/20190719133530.28688-1-mehta.aaru20@gmail.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org July 19, 2019, 11:25 p.m. UTC | #2 
Patchew URL: https://patchew.org/QEMU/20190719133530.28688-1-mehta.aaru20@gmail.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

  CC      nbd/trace.o
In file included from block/trace.c:4:
block/trace.h: In function ‘_nocheck__trace_luring_resubmit_short_read’:
block/trace.h:1704:96: error: stray ‘\’ in program
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                                                                                                ^
block/trace.h:1704:60: error: expected ‘)’ before ‘n’
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                                                            ^                                    ~
      |                                                            )
block/trace.h:1704:98: error: missing terminating " character [-Werror]
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                                                                                                  ^
block/trace.h:1704:98: error: missing terminating " character
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                                                                                                  ^~
block/trace.h:1704:20: error: format ‘%d’ expects a matching ‘int’ argument [-Werror=format=]
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                   ~^
      |                    |
      |                    int
block/trace.h:1704:24: error: format ‘%zu’ expects a matching ‘size_t’ argument [-Werror=format=]
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                      ~~^
      |                        |
      |                        long unsigned int
block/trace.h:1704:30: error: format ‘%zu’ expects a matching ‘size_t’ argument [-Werror=format=]
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                          ~~~~^
      |                              |
      |                              long unsigned int
block/trace.h:1704:18: error: format ‘%p’ expects a matching ‘void *’ argument [-Werror=format=]
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
block/trace.h:1704:75: note: format string is defined here
---
      |                                                                          ~^
      |                                                                           |
      |                                                                           void *
block/trace.h:1704:18: error: format ‘%p’ expects a matching ‘void *’ argument [-Werror=format=]
 1704 |         qemu_log("%d@%zu.%06zu:luring_resubmit_short_read " "LuringState %p luringcb %p nread "\n",
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
block/trace.h:1704:87: note: format string is defined here


The full log is available at
http://patchew.org/logs/20190719133530.28688-1-mehta.aaru20@gmail.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com