[v2,0/4] btrfs-progs: fix clone from wrong subvolume
mbox series

Message ID cover.1563822638.git.osandov@fb.com
Headers show
Series
  • btrfs-progs: fix clone from wrong subvolume
Related show

Message

Omar Sandoval July 22, 2019, 7:15 p.m. UTC
From: Omar Sandoval <osandov@fb.com>

This is v2 of [1]. Changes from v1:

- Split out removing commented-out code to new patch 1 and removed a
  related comment block.
- Made subvol_path const char * in patch 2.
- Added test case as patch 4.
- Fixed wrong signed-off-by.

Thanks,
Omar

1: https://lore.kernel.org/linux-btrfs/cover.1563600688.git.osandov@fb.com/T/#u

Omar Sandoval (4):
  btrfs-progs: receive: remove commented out transid checks
  btrfs-progs: receive: get rid of unnecessary strdup()
  btrfs-progs: receive: don't lookup clone root for received subvolume
  btrfs-progs: tests: add test for receiving clone from duplicate
    subvolume

 cmds/receive.c                                | 50 ++++---------------
 .../test.sh                                   | 34 +++++++++++++
 2 files changed, 45 insertions(+), 39 deletions(-)
 create mode 100755 tests/misc-tests/038-receive-clone-from-current-subvolume/test.sh

Comments

Omar Sandoval Sept. 4, 2019, 8:35 p.m. UTC | #1
On Mon, Jul 22, 2019 at 12:15:01PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> This is v2 of [1]. Changes from v1:
> 
> - Split out removing commented-out code to new patch 1 and removed a
>   related comment block.
> - Made subvol_path const char * in patch 2.
> - Added test case as patch 4.
> - Fixed wrong signed-off-by.
> 
> Thanks,
> Omar
> 
> 1: https://lore.kernel.org/linux-btrfs/cover.1563600688.git.osandov@fb.com/T/#u
> 
> Omar Sandoval (4):
>   btrfs-progs: receive: remove commented out transid checks
>   btrfs-progs: receive: get rid of unnecessary strdup()
>   btrfs-progs: receive: don't lookup clone root for received subvolume
>   btrfs-progs: tests: add test for receiving clone from duplicate
>     subvolume
> 
>  cmds/receive.c                                | 50 ++++---------------
>  .../test.sh                                   | 34 +++++++++++++
>  2 files changed, 45 insertions(+), 39 deletions(-)
>  create mode 100755 tests/misc-tests/038-receive-clone-from-current-subvolume/test.sh

Ping. Looks like only patch 2 is in the devel branch.
Qu Wenruo Oct. 10, 2019, 7:06 a.m. UTC | #2
On 2019/9/5 上午4:35, Omar Sandoval wrote:
> On Mon, Jul 22, 2019 at 12:15:01PM -0700, Omar Sandoval wrote:
>> From: Omar Sandoval <osandov@fb.com>
>>
>> This is v2 of [1]. Changes from v1:
>>
>> - Split out removing commented-out code to new patch 1 and removed a
>>   related comment block.
>> - Made subvol_path const char * in patch 2.
>> - Added test case as patch 4.
>> - Fixed wrong signed-off-by.
>>
>> Thanks,
>> Omar
>>
>> 1: https://lore.kernel.org/linux-btrfs/cover.1563600688.git.osandov@fb.com/T/#u
>>
>> Omar Sandoval (4):
>>   btrfs-progs: receive: remove commented out transid checks
>>   btrfs-progs: receive: get rid of unnecessary strdup()
>>   btrfs-progs: receive: don't lookup clone root for received subvolume
>>   btrfs-progs: tests: add test for receiving clone from duplicate
>>     subvolume
>>
>>  cmds/receive.c                                | 50 ++++---------------
>>  .../test.sh                                   | 34 +++++++++++++
>>  2 files changed, 45 insertions(+), 39 deletions(-)
>>  create mode 100755 tests/misc-tests/038-receive-clone-from-current-subvolume/test.sh
> 
> Ping. Looks like only patch 2 is in the devel branch.
> 

Since it looks good to me, I'll include the remaining patches in my next
pull to David, and hopes he accepts them.

Thanks,
Qu