[0/9] uC fw path unification + misc clean-up
mbox series

Message ID 20190722232048.9970-1-daniele.ceraolospurio@intel.com
Headers show
Series
  • uC fw path unification + misc clean-up
Related show

Message

Daniele Ceraolo Spurio July 22, 2019, 11:20 p.m. UTC
The main aim of this patch series is unify the guc_fw and huc_fw
handling paths and improve the related state tracking. Ultimately, I'd
like to reach the point where we can kill the intel_guc_fw and
intel_huc_fw files and just keep the few differences in other files. Not
yet going that far in this series though.

Bundled in is some more gt-fication and minor clean-up.

Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>

Daniele Ceraolo Spurio (9):
  drm/i915/uc: Gt-fy uc reset
  drm/i915/uc: Unify uC platform check
  drm/i915/uc: Unify uC FW selection
  drm/i915/uc: Sanitize uC when GT is sanitized
  drm/i915/uc: Unify uc_fw status tracking
  drm/i915/uc: Move xfer rsa logic to common function
  drm/i915/huc: Copy huc rsa only once
  drm/i915/uc: Plumb the gt through fw_upload
  drm/i915/uc: Unify uC firmware upload

 drivers/gpu/drm/i915/gem/i915_gem_pm.c    |   1 -
 drivers/gpu/drm/i915/gt/intel_gt_pm.c     |   2 +
 drivers/gpu/drm/i915/gt/intel_reset.c     |   2 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 229 ++++++----------------
 drivers/gpu/drm/i915/gt/uc/intel_huc.c    |  25 ++-
 drivers/gpu/drm/i915/gt/uc/intel_huc.h    |   1 -
 drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 184 +++--------------
 drivers/gpu/drm/i915/gt/uc/intel_uc.c     |   8 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c  | 220 ++++++++++++++-------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h  |  84 +++++---
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c |   4 +-
 drivers/gpu/drm/i915/i915_debugfs.c       |   6 +-
 drivers/gpu/drm/i915/i915_drv.h           |  15 +-
 drivers/gpu/drm/i915/i915_gpu_error.c     |   4 +-
 drivers/gpu/drm/i915/i915_irq.c           |   2 +-
 drivers/gpu/drm/i915/i915_pci.c           |   4 +-
 drivers/gpu/drm/i915/intel_device_info.h  |   2 +-
 drivers/gpu/drm/i915/intel_pm.c           |   4 +-
 drivers/gpu/drm/i915/intel_wopcm.c        |   4 +-
 19 files changed, 330 insertions(+), 471 deletions(-)

Comments

Chris Wilson July 23, 2019, 8:01 a.m. UTC | #1
Quoting Daniele Ceraolo Spurio (2019-07-23 00:20:39)
> The main aim of this patch series is unify the guc_fw and huc_fw
> handling paths and improve the related state tracking. Ultimately, I'd
> like to reach the point where we can kill the intel_guc_fw and
> intel_huc_fw files and just keep the few differences in other files. Not
> yet going that far in this series though.
> 
> Bundled in is some more gt-fication and minor clean-up.

I was honestly hoping for more spam reduction. 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6535/fi-kbl-guc/igt@i915_selftest@live_hangcheck.html
is bordering on the ridiculous signal:noise.
-Chris