[0/9] Refactor to expand subslice mask (rev 2)
mbox series

Message ID 20190724171220.22986-1-stuart.summers@intel.com
Headers show
Series
  • Refactor to expand subslice mask (rev 2)
Related show

Message

Stuart Summers July 24, 2019, 5:12 p.m. UTC
Currently, the subslice_mask runtime parameter is stored as an
array of subslices per slice. Expand the subslice mask array to
better match what is presented to userspace through the
I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is
then calculated:
  slice * subslice stride + subslice index / 8

Note this is the second iteration of an original patch to implement
the same. There are a couple of minor code changes based on changes
since the first series was posted. Additionally, the original patch
has been split into several smaller patches with more isolated
changes based on review feedback in that first series.

Link to the original series:
https://patchwork.freedesktop.org/series/59742/

v2: Fix 32-bit build

Stuart Summers (9):
  drm/i915: Use variable for debugfs device status
  drm/i915: Add function to set SSEU info per platform
  drm/i915: Add subslice stride runtime parameter
  drm/i915: Add EU stride runtime parameter
  drm/i915: Add function to set subslices
  drm/i915: Add function to determine if a slice has a subslice
  drm/i915: Refactor instdone loops on new subslice functions
  drm/i915: Add new function to copy subslices for a slice
  drm/i915: Expand subslice mask

 drivers/gpu/drm/i915/gt/intel_engine_cs.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  31 +++--
 drivers/gpu/drm/i915/gt/intel_hangcheck.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_sseu.c         |  48 +++++++-
 drivers/gpu/drm/i915/gt/intel_sseu.h         |  24 +++-
 drivers/gpu/drm/i915/gt/intel_workarounds.c  |   3 +-
 drivers/gpu/drm/i915/i915_debugfs.c          |  47 +++++---
 drivers/gpu/drm/i915/i915_gpu_error.c        |   5 +-
 drivers/gpu/drm/i915/i915_query.c            |  10 +-
 drivers/gpu/drm/i915/intel_device_info.c     | 118 +++++++++----------
 10 files changed, 185 insertions(+), 107 deletions(-)

Comments

Stuart Summers July 24, 2019, 9:08 p.m. UTC | #1
On Wed, 2019-07-24 at 21:01 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: Refactor to expand subslice mask (rev 2)
> URL   : https://patchwork.freedesktop.org/series/64188/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6545_full -> Patchwork_13739_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_13739_full absolutely
> need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the
> changes
>   introduced in Patchwork_13739_full, please notify your bug team to
> allow them
>   to document this new failure mode, which will reduce false
> positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_13739_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_query@query-topology-matches-eu-total:
>     - shard-hsw:          [PASS][1] -> [FAIL][2] +3 similar issues
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-hsw7/igt@i915_query@query-topology-matches-eu-total.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-hsw1/igt@i915_query@query-topology-matches-eu-total.html

Looks like this series is causing a regression on HSW. I'll fix this
issue before posting the next revision. For now, please hold off on
review.

Thanks,
Stuart

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_13739_full that come from
> known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_isolation@rcs0-s3:
>     - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566])
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-apl8/igt@gem_ctx_isolation@rcs0-s3.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html
> 
>   * igt@gem_tiled_swapping@non-threaded:
>     - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108686])
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-apl5/igt@gem_tiled_swapping@non-threaded.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-apl7/igt@gem_tiled_swapping@non-threaded.html
> 
>   * igt@i915_pm_rc6_residency@rc6-accuracy:
>     - shard-kbl:          [PASS][7] -> [SKIP][8] ([fdo#109271])
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html
> 
>   * igt@i915_query@query-topology-coherent-slice-mask:
>     - shard-hsw:          [PASS][9] -> [SKIP][10] ([fdo#109271])
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-hsw4/igt@i915_query@query-topology-coherent-slice-mask.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-hsw5/igt@i915_query@query-topology-coherent-slice-mask.html
> 
>   * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
>     - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#103355])
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-skl:          [PASS][13] -> [FAIL][14] ([fdo#105363])
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible:
>     - shard-kbl:          [PASS][15] -> [DMESG-WARN][16]
> ([fdo#108566]) +2 similar issues
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
> 
>   * igt@kms_flip_tiling@flip-to-x-tiled:
>     - shard-skl:          [PASS][17] -> [FAIL][18] ([fdo#108134])
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-skl10/igt@kms_flip_tiling@flip-to-x-tiled.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-skl3/igt@kms_flip_tiling@flip-to-x-tiled.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
>     - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167]) +7
> similar issues
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-skl:          [PASS][21] -> [INCOMPLETE][22]
> ([fdo#104108])
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-skl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-skl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>     - shard-kbl:          [PASS][23] -> [INCOMPLETE][24]
> ([fdo#103665])
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> 
>   * igt@kms_psr2_su@page_flip:
>     - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109642] /
> [fdo#111068])
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb2/igt@kms_psr2_su@page_flip.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb4/igt@kms_psr2_su@page_flip.html
> 
>   * igt@perf_pmu@init-busy-vcs2:
>     - shard-iclb:         [PASS][27] -> [INCOMPLETE][28]
> ([fdo#107713])
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb2/igt@perf_pmu@init-busy-vcs2.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb4/igt@perf_pmu@init-busy-vcs2.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_exec_balancer@smoke:
>     - shard-iclb:         [SKIP][29] ([fdo#110854]) -> [PASS][30]
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb6/igt@gem_exec_balancer@smoke.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb4/igt@gem_exec_balancer@smoke.html
> 
>   * igt@i915_selftest@live_hangcheck:
>     - shard-iclb:         [INCOMPLETE][31] ([fdo#107713] /
> [fdo#108569]) -> [PASS][32]
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb6/igt@i915_selftest@live_hangcheck.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb6/igt@i915_selftest@live_hangcheck.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          [FAIL][33] ([fdo#105363]) -> [PASS][34]
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible:
>     - shard-apl:          [DMESG-WARN][35] ([fdo#108566]) ->
> [PASS][36] +4 similar issues
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
>     - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +3
> similar issues
>    [37]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> 
>   * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
>     - shard-skl:          [FAIL][39] ([fdo#108145]) -> [PASS][40] +1
> similar issue
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
> 
>   * igt@kms_psr@cursor_plane_onoff:
>     - shard-iclb:         [INCOMPLETE][41] ([fdo#107713]) ->
> [PASS][42]
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb1/igt@kms_psr@cursor_plane_onoff.html
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb1/igt@kms_psr@cursor_plane_onoff.html
> 
>   * igt@kms_psr@psr2_primary_mmap_gtt:
>     - shard-iclb:         [SKIP][43] ([fdo#109441]) -> [PASS][44] +2
> similar issues
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-iclb4/igt@kms_psr@psr2_primary_mmap_gtt.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_tiled_swapping@non-threaded:
>     - shard-skl:          [FAIL][45] ([fdo#108686]) -> [SKIP][46]
> ([fdo#109271])
>    [45]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/shard-skl8/igt@gem_tiled_swapping@non-threaded.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/shard-skl5/igt@gem_tiled_swapping@non-threaded.html
> 
>   
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
>   [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
>   [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
>   [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
> 
> 
> Participating hosts (9 -> 9)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_6545 -> Patchwork_13739
> 
>   CI-20190529: 20190529
>   CI_DRM_6545: a6efe73f1e086c7935d56b08342f9e1c5565fcf3 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5109: e5fd509e16ec649436be31f38eaa5b85cb7f72f1 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_13739: 6c805dfa2b2aa200593b17947e683a2781992c7a @
> git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13739/