mbox series

[0/3] x86/dmi: Cleanup

Message ID 20190724174256.5295-1-andrew.cooper3@citrix.com (mailing list archive)
Headers show
Series x86/dmi: Cleanup | expand

Message

Andrew Cooper July 24, 2019, 5:42 p.m. UTC
This is all trivial cleanup spotted after having come collisions in the
XenServer patchqueue when rebasing over Rogers PCI SBDF changes in staging.

Andrew Cooper (3):
  x86: Drop CONFIG_ACPI_SLEEP
  x86/dmi: Drop trivial callback functions
  x86/dmi: Constify quirks data

 xen/arch/x86/acpi/boot.c            |  4 ----
 xen/arch/x86/dmi_scan.c             | 23 ++++++++++-------------
 xen/arch/x86/genapic/bigsmp.c       |  4 ++--
 xen/arch/x86/hvm/quirks.c           |  4 ++--
 xen/arch/x86/ioport_emulate.c       | 20 ++++----------------
 xen/arch/x86/shutdown.c             |  4 ++--
 xen/arch/x86/x86_64/mmconf-fam10h.c | 12 +++---------
 xen/include/asm-x86/acpi.h          |  4 ----
 xen/include/asm-x86/config.h        |  1 -
 xen/include/xen/dmi.h               |  4 ++--
 10 files changed, 25 insertions(+), 55 deletions(-)

Comments

Andrew Cooper July 24, 2019, 6:07 p.m. UTC | #1
On 24/07/2019 18:42, Andrew Cooper wrote:
> This is all trivial cleanup spotted after having come collisions in the
> XenServer patchqueue when rebasing over Rogers PCI SBDF changes in staging.

/sigh and further looking through dmi_scan.c has revealed that
dmi_save_ident() leaks all of the strings it gets, because
alloc_bootmem() is aliased to xmalloc_bytes() and never freed.

If someone has time to fix this then please do.  If not, I'll put it
into my todo list.

~Andrew