[0/4] fscrypt: logging improvements, and use ENOPKG
mbox series

Message ID 20190724195422.42495-1-ebiggers@kernel.org
Headers show
Series
  • fscrypt: logging improvements, and use ENOPKG
Related show

Message

Eric Biggers July 24, 2019, 7:54 p.m. UTC
Patches 1-3 make some small improvements to warning and error messages
in fs/crypto/, including logging all types of unsupported encryption
contexts rather than just ones where the encryption modes are invalid.

Patch 4 changes the error code for "missing crypto API support" from
ENOENT to ENOPKG, to avoid an ambiguity.  This is a logically separate
change, but it's in this series to avoid conflicts.

Eric Biggers (4):
  fscrypt: make fscrypt_msg() take inode instead of super_block
  fscrypt: improve warning messages for unsupported encryption contexts
  fscrypt: improve warnings for missing crypto API support
  fscrypt: use ENOPKG when crypto API support missing

 fs/crypto/crypto.c          | 13 ++++----
 fs/crypto/fname.c           |  8 ++---
 fs/crypto/fscrypt_private.h | 10 +++---
 fs/crypto/hooks.c           |  6 ++--
 fs/crypto/keyinfo.c         | 61 +++++++++++++++++++++++++------------
 5 files changed, 57 insertions(+), 41 deletions(-)

Comments

Eric Biggers Aug. 14, 2019, 10:31 p.m. UTC | #1
On Wed, Jul 24, 2019 at 12:54:18PM -0700, Eric Biggers wrote:
> Patches 1-3 make some small improvements to warning and error messages
> in fs/crypto/, including logging all types of unsupported encryption
> contexts rather than just ones where the encryption modes are invalid.
> 
> Patch 4 changes the error code for "missing crypto API support" from
> ENOENT to ENOPKG, to avoid an ambiguity.  This is a logically separate
> change, but it's in this series to avoid conflicts.
> 
> Eric Biggers (4):
>   fscrypt: make fscrypt_msg() take inode instead of super_block
>   fscrypt: improve warning messages for unsupported encryption contexts
>   fscrypt: improve warnings for missing crypto API support
>   fscrypt: use ENOPKG when crypto API support missing
> 
>  fs/crypto/crypto.c          | 13 ++++----
>  fs/crypto/fname.c           |  8 ++---
>  fs/crypto/fscrypt_private.h | 10 +++---
>  fs/crypto/hooks.c           |  6 ++--
>  fs/crypto/keyinfo.c         | 61 +++++++++++++++++++++++++------------
>  5 files changed, 57 insertions(+), 41 deletions(-)
> 
> -- 
> 2.22.0.657.g960e92d24f-goog
> 

All applied to fscrypt tree for 5.4.

- Eric