mbox series

[v3,0/8] uC fw path unification + misc clean-up

Message ID 20190725001813.4740-1-daniele.ceraolospurio@intel.com (mailing list archive)
Headers show
Series uC fw path unification + misc clean-up | expand

Message

Daniele Ceraolo Spurio July 25, 2019, 12:18 a.m. UTC 
I've now unified the no uC HW and no uC FW cases as well, as requested
by Michal. I've also added sanitization of the enable_guc parameter
when we don't have support for GuC/HuC because otherwise we end up paths
we shouldn't be in on a platform with no uC.

Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>

Daniele Ceraolo Spurio (8):
  drm/i915/uc: Unify uC platform check
  drm/i915: Fix handling of non-supported uC
  drm/i915/uc: Unify uC FW selection
  drm/i915/uc: Unify uc_fw status tracking
  drm/i915/uc: Move xfer rsa logic to common function
  drm/i915/huc: Copy huc rsa only once
  drm/i915/uc: Plumb the gt through fw_upload
  drm/i915/uc: Unify uC firmware upload

 drivers/gpu/drm/i915/gt/intel_reset.c         |   2 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   4 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     | 217 ++---------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |   2 +-
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        |  35 +-
 drivers/gpu/drm/i915/gt/uc/intel_huc.h        |   6 +-
 drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c     | 172 +--------
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |  49 +--
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 341 ++++++++++++++----
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h      |  87 ++---
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     |   4 +-
 drivers/gpu/drm/i915/i915_debugfs.c           |   6 +-
 drivers/gpu/drm/i915/i915_drv.h               |  15 +-
 drivers/gpu/drm/i915/i915_gpu_error.c         |   4 +-
 drivers/gpu/drm/i915/i915_irq.c               |   2 +-
 drivers/gpu/drm/i915/i915_pci.c               |   4 +-
 drivers/gpu/drm/i915/intel_device_info.h      |   2 +-
 drivers/gpu/drm/i915/intel_pm.c               |   4 +-
 drivers/gpu/drm/i915/intel_wopcm.c            |   4 +-
 19 files changed, 433 insertions(+), 527 deletions(-)

Comments

Chris Wilson July 25, 2019, 6:38 a.m. UTC | #1 
Quoting Patchwork (2019-07-25 01:57:28)
> == Series Details ==
> 
> Series: uC fw path unification + misc clean-up (rev3)
> URL   : https://patchwork.freedesktop.org/series/64039/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6545 -> Patchwork_13741
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_13741 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_13741, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13741/
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_13741:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_module_load@reload-with-fault-injection:
>     - fi-snb-2520m:       [PASS][1] -> [INCOMPLETE][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6545/fi-snb-2520m/igt@i915_module_load@reload-with-fault-injection.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13741/fi-snb-2520m/igt@i915_module_load@reload-with-fault-injection.html

That's been cropping up frequently over the last 24 hours, unrelated so
pushed. Thanks,
-Chris