mbox series

[v2,0/3] KVM: selftests: Enable ucall and dirty_log_test on s390x

Message ID 20190731133216.5620-1-thuth@redhat.com (mailing list archive)
Headers show
Series KVM: selftests: Enable ucall and dirty_log_test on s390x | expand

Message

Thomas Huth July 31, 2019, 1:32 p.m. UTC
Implement the ucall() interface on s390x to be able to use the
dirty_log_test KVM selftest on s390x, too.

v2:
 - Split up ucall.c into architecture specific files
 - Removed some #ifdef __s390x__  in the dirty_log patch

Thomas Huth (3):
  KVM: selftests: Split ucall.c into architecture specific files
  KVM: selftests: Implement ucall() for s390x
  KVM: selftests: Enable dirty_log_test on s390x

 tools/testing/selftests/kvm/Makefile          |   9 +-
 tools/testing/selftests/kvm/dirty_log_test.c  |  61 ++++++-
 .../testing/selftests/kvm/include/kvm_util.h  |   8 +-
 .../testing/selftests/kvm/lib/aarch64/ucall.c | 112 +++++++++++++
 tools/testing/selftests/kvm/lib/s390x/ucall.c |  56 +++++++
 tools/testing/selftests/kvm/lib/ucall.c       | 157 ------------------
 .../testing/selftests/kvm/lib/x86_64/ucall.c  |  56 +++++++
 .../selftests/kvm/s390x/sync_regs_test.c      |   6 +-
 8 files changed, 287 insertions(+), 178 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/lib/aarch64/ucall.c
 create mode 100644 tools/testing/selftests/kvm/lib/s390x/ucall.c
 delete mode 100644 tools/testing/selftests/kvm/lib/ucall.c
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/ucall.c

Comments

Thomas Huth July 31, 2019, 1:39 p.m. UTC | #1
On 31/07/2019 15.32, Thomas Huth wrote:
> Implement the ucall() interface on s390x to be able to use the
> dirty_log_test KVM selftest on s390x, too.
> 
> v2:
>  - Split up ucall.c into architecture specific files
>  - Removed some #ifdef __s390x__  in the dirty_log patch
> 
> Thomas Huth (3):
>   KVM: selftests: Split ucall.c into architecture specific files

I forgot to say: I only checked x86 and s390x ... Andrew, could you
please check that the dirty_log_test still builds and runs fine on
aarch64 after applying my patches? (Sorry, I tried to get a aarch64
machine here, but so far I failed...)

 Thanks,
  Thomas
Andrew Jones July 31, 2019, 2:51 p.m. UTC | #2
On Wed, Jul 31, 2019 at 03:32:13PM +0200, Thomas Huth wrote:
> Implement the ucall() interface on s390x to be able to use the
> dirty_log_test KVM selftest on s390x, too.
> 
> v2:
>  - Split up ucall.c into architecture specific files
>  - Removed some #ifdef __s390x__  in the dirty_log patch
> 
> Thomas Huth (3):
>   KVM: selftests: Split ucall.c into architecture specific files
>   KVM: selftests: Implement ucall() for s390x
>   KVM: selftests: Enable dirty_log_test on s390x
> 
>  tools/testing/selftests/kvm/Makefile          |   9 +-
>  tools/testing/selftests/kvm/dirty_log_test.c  |  61 ++++++-
>  .../testing/selftests/kvm/include/kvm_util.h  |   8 +-
>  .../testing/selftests/kvm/lib/aarch64/ucall.c | 112 +++++++++++++
>  tools/testing/selftests/kvm/lib/s390x/ucall.c |  56 +++++++
>  tools/testing/selftests/kvm/lib/ucall.c       | 157 ------------------
>  .../testing/selftests/kvm/lib/x86_64/ucall.c  |  56 +++++++
>  .../selftests/kvm/s390x/sync_regs_test.c      |   6 +-
>  8 files changed, 287 insertions(+), 178 deletions(-)
>  create mode 100644 tools/testing/selftests/kvm/lib/aarch64/ucall.c
>  create mode 100644 tools/testing/selftests/kvm/lib/s390x/ucall.c
>  delete mode 100644 tools/testing/selftests/kvm/lib/ucall.c
>  create mode 100644 tools/testing/selftests/kvm/lib/x86_64/ucall.c
> 
> -- 
> 2.21.0
>

With the include change to fix compilation on aarch64, for the series

Reviewed-by: Andrew Jones <drjones@redhat.com>