[0/3] clk: renesas: Set GENPD_FLAG_ALWAYS_ON for clock domain
mbox series

Message ID 20190816125225.16061-1-geert+renesas@glider.be
Headers show
Series
  • clk: renesas: Set GENPD_FLAG_ALWAYS_ON for clock domain
Related show

Message

Geert Uytterhoeven Aug. 16, 2019, 12:52 p.m. UTC
Hi Mike, Stephen,

The Renesas Clock Domain drivers do not implement the
generic_pm_domain.power_{on,off}() callbacks, as the domains themselves
cannot be powered down.  Hence the domains should be marked as always-on
by setting the GENPD_FLAG_ALWAYS_ON flag.

This patch series that issue for R-Car M1A, RZ/A1, RZ/A2, and
RZ/N1 SoCs.
SH/R-Mobile SoCs are fixed in "[PATCH] soc: renesas: rmobile-sysc: Set
GENPD_FLAG_ALWAYS_ON for always-on domain"
(https://lore.kernel.org/linux-renesas-soc/20190816124106.15383-1-geert+renesas@glider.be/T/#u).
R-Car H1, Gen2, and Gen3 SoCs do not need a fix, as these SoCS use the
R-Car SYSC driver for Clock Domain creation, which already sets the
flag.

To be queued in clk-renesas for v5.4.

Thanks!

Geert Uytterhoeven (3):
  clk: renesas: mstp: Set GENPD_FLAG_ALWAYS_ON for clock domain
  clk: renesas: r9a06g032: Set GENPD_FLAG_ALWAYS_ON for clock domain
  clk: renesas: cpg-mssr: Set GENPD_FLAG_ALWAYS_ON for clock domain

 drivers/clk/renesas/clk-mstp.c         | 3 ++-
 drivers/clk/renesas/r9a06g032-clocks.c | 3 ++-
 drivers/clk/renesas/renesas-cpg-mssr.c | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

Comments

Ulf Hansson Aug. 22, 2019, 2:08 p.m. UTC | #1
On Fri, 16 Aug 2019 at 14:52, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         Hi Mike, Stephen,
>
> The Renesas Clock Domain drivers do not implement the
> generic_pm_domain.power_{on,off}() callbacks, as the domains themselves
> cannot be powered down.  Hence the domains should be marked as always-on
> by setting the GENPD_FLAG_ALWAYS_ON flag.
>
> This patch series that issue for R-Car M1A, RZ/A1, RZ/A2, and
> RZ/N1 SoCs.
> SH/R-Mobile SoCs are fixed in "[PATCH] soc: renesas: rmobile-sysc: Set
> GENPD_FLAG_ALWAYS_ON for always-on domain"
> (https://lore.kernel.org/linux-renesas-soc/20190816124106.15383-1-geert+renesas@glider.be/T/#u).
> R-Car H1, Gen2, and Gen3 SoCs do not need a fix, as these SoCS use the
> R-Car SYSC driver for Clock Domain creation, which already sets the
> flag.
>
> To be queued in clk-renesas for v5.4.
>
> Thanks!
>
> Geert Uytterhoeven (3):
>   clk: renesas: mstp: Set GENPD_FLAG_ALWAYS_ON for clock domain
>   clk: renesas: r9a06g032: Set GENPD_FLAG_ALWAYS_ON for clock domain
>   clk: renesas: cpg-mssr: Set GENPD_FLAG_ALWAYS_ON for clock domain
>
>  drivers/clk/renesas/clk-mstp.c         | 3 ++-
>  drivers/clk/renesas/r9a06g032-clocks.c | 3 ++-
>  drivers/clk/renesas/renesas-cpg-mssr.c | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
>

Feel free to add:

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe
Geert Uytterhoeven Aug. 23, 2019, 9:08 a.m. UTC | #2
On Thu, Aug 22, 2019 at 4:09 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On Fri, 16 Aug 2019 at 14:52, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > The Renesas Clock Domain drivers do not implement the
> > generic_pm_domain.power_{on,off}() callbacks, as the domains themselves
> > cannot be powered down.  Hence the domains should be marked as always-on
> > by setting the GENPD_FLAG_ALWAYS_ON flag.
> >
> > This patch series that issue for R-Car M1A, RZ/A1, RZ/A2, and
> > RZ/N1 SoCs.
> > SH/R-Mobile SoCs are fixed in "[PATCH] soc: renesas: rmobile-sysc: Set
> > GENPD_FLAG_ALWAYS_ON for always-on domain"
> > (https://lore.kernel.org/linux-renesas-soc/20190816124106.15383-1-geert+renesas@glider.be/T/#u).
> > R-Car H1, Gen2, and Gen3 SoCs do not need a fix, as these SoCS use the
> > R-Car SYSC driver for Clock Domain creation, which already sets the
> > flag.
> >
> > To be queued in clk-renesas for v5.4.
> >
> > Thanks!
> >
> > Geert Uytterhoeven (3):
> >   clk: renesas: mstp: Set GENPD_FLAG_ALWAYS_ON for clock domain
> >   clk: renesas: r9a06g032: Set GENPD_FLAG_ALWAYS_ON for clock domain
> >   clk: renesas: cpg-mssr: Set GENPD_FLAG_ALWAYS_ON for clock domain
> >
> >  drivers/clk/renesas/clk-mstp.c         | 3 ++-
> >  drivers/clk/renesas/r9a06g032-clocks.c | 3 ++-
> >  drivers/clk/renesas/renesas-cpg-mssr.c | 3 ++-
> >  3 files changed, 6 insertions(+), 3 deletions(-)
> >
>
> Feel free to add:
>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Thanks, queuing in clk-renesas-for-v5.4, with enhanced commit description:

    ... to prevent the core PM Domain code from considering it for power-off,
    and doing unnessary processing.

for all three of them, and

    This also gets rid of a boot warning when the Clock Domain contains an
    IRQ-safe device, e.g. on RZ/A1:

for the first patch.

Gr{oetje,eeting}s,

                        Geert