[v3,0/7] Fix the reported SGX selftest makefile issues
mbox series

Message ID 20190819132830.9056-1-jarkko.sakkinen@linux.intel.com
Headers show
Series
  • Fix the reported SGX selftest makefile issues
Related show

Message

Jarkko Sakkinen Aug. 19, 2019, 1:28 p.m. UTC
Cedric Xing reported various issues in the selftest makefiles, which are
hopefully taken care by these patches.

As the last patch this patch set contains a patch that implements the
subdirectory traversal the for the x86 selftest directory tree. This
patch is meant to be a separate patch in the main SGX patch set so that
the bindings can be reviewed separately.

v3: 1,$s/SUB_DIRS/SUBDIRS/g
v2: Added patch to implement the traversal to the subdirectories
    selftest.

Jarkko Sakkinen (7):
  selftests/x86/sgx: Fix objcopy call in the Makefile
  selftests/x86/sgx: Do not generate object files
  selftests/x86/sgx: Add -I$(OUTPUT) when compiling encl_piggy.S
  selftests/x86/sgx: Fix EXTRA_CLEAN
  selftests/x86/sgx: Fix target in the Makefile
  selftests/x86: Revert SGX changes
  selftests/x86: Recurse into subdirectories

 tools/testing/selftests/x86/Makefile     | 54 +++++++++++++++++++-----
 tools/testing/selftests/x86/sgx/Makefile | 33 ++++++++-------
 tools/testing/selftests/x86/sgx/encl.lds |  1 +
 3 files changed, 63 insertions(+), 25 deletions(-)

Comments

Sean Christopherson Aug. 22, 2019, 3:31 a.m. UTC | #1
On Mon, Aug 19, 2019 at 04:28:23PM +0300, Jarkko Sakkinen wrote:
> Cedric Xing reported various issues in the selftest makefiles, which are
> hopefully taken care by these patches.
> 
> As the last patch this patch set contains a patch that implements the
> subdirectory traversal the for the x86 selftest directory tree. This
> patch is meant to be a separate patch in the main SGX patch set so that
> the bindings can be reviewed separately.

Doesn't have to be this series, but the build artifacts should be added
to .gitignore.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        sgx/encl.ss
        sgx/sgxsign
        sgx/test_sgx

> 
> v3: 1,$s/SUB_DIRS/SUBDIRS/g
> v2: Added patch to implement the traversal to the subdirectories
>     selftest.
> 
> Jarkko Sakkinen (7):
>   selftests/x86/sgx: Fix objcopy call in the Makefile
>   selftests/x86/sgx: Do not generate object files
>   selftests/x86/sgx: Add -I$(OUTPUT) when compiling encl_piggy.S
>   selftests/x86/sgx: Fix EXTRA_CLEAN
>   selftests/x86/sgx: Fix target in the Makefile
>   selftests/x86: Revert SGX changes
>   selftests/x86: Recurse into subdirectories
> 
>  tools/testing/selftests/x86/Makefile     | 54 +++++++++++++++++++-----
>  tools/testing/selftests/x86/sgx/Makefile | 33 ++++++++-------
>  tools/testing/selftests/x86/sgx/encl.lds |  1 +
>  3 files changed, 63 insertions(+), 25 deletions(-)
> 
> -- 
> 2.20.1
>
Jarkko Sakkinen Aug. 22, 2019, 2:58 p.m. UTC | #2
On Wed, 2019-08-21 at 20:31 -0700, Sean Christopherson wrote:
> On Mon, Aug 19, 2019 at 04:28:23PM +0300, Jarkko Sakkinen wrote:
> > Cedric Xing reported various issues in the selftest makefiles, which are
> > hopefully taken care by these patches.
> > 
> > As the last patch this patch set contains a patch that implements the
> > subdirectory traversal the for the x86 selftest directory tree. This
> > patch is meant to be a separate patch in the main SGX patch set so that
> > the bindings can be reviewed separately.
> 
> Doesn't have to be this series, but the build artifacts should be added
> to .gitignore.
> 
> Untracked files:
>   (use "git add <file>..." to include in what will be committed)
> 
>         sgx/encl.ss
>         sgx/sgxsign
>         sgx/test_sgx

Oh, good catch. Lets do it as a separate patch after I've squashed
everything.

/Jarkko