[0/9] Refactor to expand subslice mask (rev 2)
mbox series

Message ID 20190819211849.34085-1-stuart.summers@intel.com
Headers show
Series
  • Refactor to expand subslice mask (rev 2)
Related show

Message

Summers, Stuart Aug. 19, 2019, 9:18 p.m. UTC
Currently, the subslice_mask runtime parameter is stored as an
array of subslices per slice. Expand the subslice mask array to
better match what is presented to userspace through the
I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is
then calculated:
  slice * subslice stride + subslice index / 8

Note this is the second iteration of an original patch to implement
the same. There are a couple of minor code changes based on changes
since the first series was posted. Additionally, the original patch
has been split into several smaller patches with more isolated
changes based on review feedback in that first series.

Link to the original series:
https://patchwork.freedesktop.org/series/59742/

v2: Fix 32-bit build
v3: Fix typo in haswell sseu info routine and fix SSEU workaround
    print
v4: Merge patch to HSW in previous revision with patch to
    set subslice_mask for each platform and address feedback
    from Chris
v5: No changes in code. Resending due to unrelated failures - confirmed
    no failures with trybot.

Stuart Summers (9):
  drm/i915: Use variable for debugfs device status
  drm/i915: Add function to set SSEU info per platform
  drm/i915: Add subslice stride runtime parameter
  drm/i915: Add EU stride runtime parameter
  drm/i915: Add function to set subslices
  drm/i915: Add function to determine if a slice has a subslice
  drm/i915: Refactor instdone loops on new subslice functions
  drm/i915: Add new function to copy subslices for a slice
  drm/i915: Expand subslice mask

 drivers/gpu/drm/i915/gt/intel_engine_cs.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  31 +++--
 drivers/gpu/drm/i915/gt/intel_hangcheck.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_sseu.c         |  48 +++++++-
 drivers/gpu/drm/i915/gt/intel_sseu.h         |  24 +++-
 drivers/gpu/drm/i915/gt/intel_workarounds.c  |   3 +-
 drivers/gpu/drm/i915/i915_debugfs.c          |  49 +++++---
 drivers/gpu/drm/i915/i915_gpu_error.c        |   5 +-
 drivers/gpu/drm/i915/i915_query.c            |  10 +-
 drivers/gpu/drm/i915/intel_device_info.c     | 122 +++++++++----------
 10 files changed, 185 insertions(+), 113 deletions(-)

Comments

Summers, Stuart Aug. 19, 2019, 9:44 p.m. UTC | #1
On Mon, 2019-08-19 at 14:18 -0700, Stuart Summers wrote:
> Currently, the subslice_mask runtime parameter is stored as an
> array of subslices per slice. Expand the subslice mask array to
> better match what is presented to userspace through the
> I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is
> then calculated:
>   slice * subslice stride + subslice index / 8
> 
> Note this is the second iteration of an original patch to implement
> the same. There are a couple of minor code changes based on changes
> since the first series was posted. Additionally, the original patch
> has been split into several smaller patches with more isolated
> changes based on review feedback in that first series.
> 
> Link to the original series:
> https://patchwork.freedesktop.org/series/59742/
> 
> v2: Fix 32-bit build
> v3: Fix typo in haswell sseu info routine and fix SSEU workaround
>     print
> v4: Merge patch to HSW in previous revision with patch to
>     set subslice_mask for each platform and address feedback
>     from Chris
> v5: No changes in code. Resending due to unrelated failures -
> confirmed
>     no failures with trybot.

Sorry for the thrash here. There is one more change required in this
series. I'll post an update shortly.

Thanks,
Stuart

> 
> Stuart Summers (9):
>   drm/i915: Use variable for debugfs device status
>   drm/i915: Add function to set SSEU info per platform
>   drm/i915: Add subslice stride runtime parameter
>   drm/i915: Add EU stride runtime parameter
>   drm/i915: Add function to set subslices
>   drm/i915: Add function to determine if a slice has a subslice
>   drm/i915: Refactor instdone loops on new subslice functions
>   drm/i915: Add new function to copy subslices for a slice
>   drm/i915: Expand subslice mask
> 
>  drivers/gpu/drm/i915/gt/intel_engine_cs.c    |   3 +-
>  drivers/gpu/drm/i915/gt/intel_engine_types.h |  31 +++--
>  drivers/gpu/drm/i915/gt/intel_hangcheck.c    |   3 +-
>  drivers/gpu/drm/i915/gt/intel_sseu.c         |  48 +++++++-
>  drivers/gpu/drm/i915/gt/intel_sseu.h         |  24 +++-
>  drivers/gpu/drm/i915/gt/intel_workarounds.c  |   3 +-
>  drivers/gpu/drm/i915/i915_debugfs.c          |  49 +++++---
>  drivers/gpu/drm/i915/i915_gpu_error.c        |   5 +-
>  drivers/gpu/drm/i915/i915_query.c            |  10 +-
>  drivers/gpu/drm/i915/intel_device_info.c     | 122 +++++++++------
> ----
>  10 files changed, 185 insertions(+), 113 deletions(-)
>