| Message ID | 20190821185821.12690-1-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire: debugfs support for 5.4 | expand |
On 21-08-19, 13:58, Pierre-Louis Bossart wrote: > This patchset enables debugfs support and corrects all the feedback > provided on an earlier RFC ('soundwire: updates for 5.4') > > There is one remaining hard-coded value in intel.c that will need to > be fixed in a follow-up patchset not specific to debugfs: we need to > remove hard-coded Intel-specific configurations from cadence_master.c > (PDI offsets, etc). Applied all (i did hand edit of patch 4 to resolve dependency), thanks
On 8/23/19 1:34 AM, Vinod Koul wrote: > On 21-08-19, 13:58, Pierre-Louis Bossart wrote: >> This patchset enables debugfs support and corrects all the feedback >> provided on an earlier RFC ('soundwire: updates for 5.4') >> >> There is one remaining hard-coded value in intel.c that will need to >> be fixed in a follow-up patchset not specific to debugfs: we need to >> remove hard-coded Intel-specific configurations from cadence_master.c >> (PDI offsets, etc). > > Applied all (i did hand edit of patch 4 to resolve dependency), thanks Thanks for the edit, appreciate not having to resend a series.
This patchset enables debugfs support and corrects all the feedback provided on an earlier RFC ('soundwire: updates for 5.4') There is one remaining hard-coded value in intel.c that will need to be fixed in a follow-up patchset not specific to debugfs: we need to remove hard-coded Intel-specific configurations from cadence_master.c (PDI offsets, etc). Changes since v2: No code change, just rebase to soundwire/next Added GKH and Sanyog's tags Also added patch4 submitted earlier in another series which depends on debugfs Changes since v1 (Feedback from GKH) Handle debugfs in a more self-contained way (no dentry as return or parameter) Used CONFIG_DEBUG_FS in structures and code to make it easier to remove if need be. No functional change for register dumps. Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): removed error checks used DEFINE_SHOW_ATTRIBUTE and seq_file fixed copyright dates fixed SPDX license info to use GPL2.0 only fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected used static inlines for fallback compilation removed intermediate variables removed hard-coded constants in loops (used registers offsets and hardware capabilities) squashed patch 3 Pierre-Louis Bossart (4): soundwire: add debugfs support soundwire: cadence_master: add debugfs register dump soundwire: intel: add debugfs register dump soundwire: intel: handle disabled links drivers/soundwire/Makefile | 4 + drivers/soundwire/bus.c | 6 ++ drivers/soundwire/bus.h | 16 +++ drivers/soundwire/bus_type.c | 3 + drivers/soundwire/cadence_master.c | 107 ++++++++++++++++++++ drivers/soundwire/cadence_master.h | 4 + drivers/soundwire/debugfs.c | 151 +++++++++++++++++++++++++++++ drivers/soundwire/intel.c | 145 ++++++++++++++++++++++++++- drivers/soundwire/slave.c | 1 + include/linux/soundwire/sdw.h | 10 ++ 10 files changed, 444 insertions(+), 3 deletions(-) create mode 100644 drivers/soundwire/debugfs.c base-commit: 183c7687802e4132eb782808a8bf80689a9219c1