[v8,00/10] drm/i915: adding state checker for gamma lut value
mbox series

Message ID 1566800772-18412-1-git-send-email-swati2.sharma@intel.com
Headers show
Series
  • drm/i915: adding state checker for gamma lut value
Related show

Message

Swati Sharma Aug. 26, 2019, 6:26 a.m. UTC
In this patch series, added state checker to validate gamma (8BIT and 10BIT).
This reads hardware state, and compares the originally requested state(s/w) to the
state read from the hardware.
This is done for legacy, i965, ilk, glk and their variant platforms. 

Intentionally, excluded bdw and ivb since they have spilt gamma mode; for 
which degamma read outs are required (which I think shouldn't be included in this
patch series). Will include after degamma state checker is completed.

v1: -Implementation done for legacy platforms
     (removed all the placeholders) (Jani)
v2: -Restructured code and created platform specific patch series for 
     gamma validation
v3: -Rebase
v4: -Minor changes-function name changes mainly
v5: -Added degamma validation (Ville)
v6: -Removed degamma changes, debugging was becoming difficult
    -Added function to assign bit_precision for gamma/degamma
     lut values /platform
    -Added debug info into intel_dump_pipe_config() (Jani)
v7: -Added platform specific functions to compute gamma bit precision
     on the basis of GAMMA_MODE (Ville)
    -Corrected checkpatch warnings
v8: -Restructured code
    -Removed bdw and ivb platform state checker

Swati Sharma (10):
  drm/i915/display: Add func to get gamma bit precision
  drm/i915/display: Add debug log for color parameters
  drm/i915/display: Add func to compare hw/sw gamma lut
  drm/i915/display: Add macro to compare gamma hw/sw lut
  drm/i915/display: Extract i9xx_read_luts()
  drm/i91/display: Extract i965_read_luts()
  drm/i915/display: Extract chv_read_luts()
  drm/i915/display: Extract ilk_read_luts()
  drm/i915/display: Extract glk_read_luts()
  FOR_TESTING_ONLY: Print rgb values of hw and sw blobs

 drivers/gpu/drm/i915/display/intel_color.c   | 370 ++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_color.h   |   7 +
 drivers/gpu/drm/i915/display/intel_display.c |  34 +++
 drivers/gpu/drm/i915/i915_reg.h              |  15 ++
 4 files changed, 423 insertions(+), 3 deletions(-)

Comments

Shankar, Uma Aug. 28, 2019, 1:11 p.m. UTC | #1
>-----Original Message-----
>From: Sharma, Swati2
>Sent: Monday, August 26, 2019 11:56 AM
>To: intel-gfx@lists.freedesktop.org
>Cc: Nikula, Jani <jani.nikula@intel.com>; Sharma, Shashank
><shashank.sharma@intel.com>; Manna, Animesh <animesh.manna@intel.com>;
>Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; daniel.vetter@ffwll.ch;
>ville.syrjala@linux.intel.com; Shankar, Uma <uma.shankar@intel.com>; Sharma,
>Swati2 <swati2.sharma@intel.com>
>Subject: [v8][PATCH 00/10] drm/i915: adding state checker for gamma lut value

The series name is changed "value" instead of "values". This makes it a new series
for patchwork. Please fix that in the next version and lets maintain the name whatever
has been there from the beginning.

>In this patch series, added state checker to validate gamma (8BIT and 10BIT).
>This reads hardware state, and compares the originally requested state(s/w) to the
>state read from the hardware.
>This is done for legacy, i965, ilk, glk and their variant platforms.
>
>Intentionally, excluded bdw and ivb since they have spilt gamma mode; for which
>degamma read outs are required (which I think shouldn't be included in this patch
>series). Will include after degamma state checker is completed.
>
>v1: -Implementation done for legacy platforms
>     (removed all the placeholders) (Jani)
>v2: -Restructured code and created platform specific patch series for
>     gamma validation
>v3: -Rebase
>v4: -Minor changes-function name changes mainly
>v5: -Added degamma validation (Ville)
>v6: -Removed degamma changes, debugging was becoming difficult
>    -Added function to assign bit_precision for gamma/degamma
>     lut values /platform
>    -Added debug info into intel_dump_pipe_config() (Jani)
>v7: -Added platform specific functions to compute gamma bit precision
>     on the basis of GAMMA_MODE (Ville)
>    -Corrected checkpatch warnings
>v8: -Restructured code
>    -Removed bdw and ivb platform state checker
>
>Swati Sharma (10):
>  drm/i915/display: Add func to get gamma bit precision
>  drm/i915/display: Add debug log for color parameters
>  drm/i915/display: Add func to compare hw/sw gamma lut
>  drm/i915/display: Add macro to compare gamma hw/sw lut
>  drm/i915/display: Extract i9xx_read_luts()
>  drm/i91/display: Extract i965_read_luts()
>  drm/i915/display: Extract chv_read_luts()
>  drm/i915/display: Extract ilk_read_luts()
>  drm/i915/display: Extract glk_read_luts()
>  FOR_TESTING_ONLY: Print rgb values of hw and sw blobs
>
> drivers/gpu/drm/i915/display/intel_color.c   | 370 ++++++++++++++++++++++++++-
> drivers/gpu/drm/i915/display/intel_color.h   |   7 +
> drivers/gpu/drm/i915/display/intel_display.c |  34 +++
> drivers/gpu/drm/i915/i915_reg.h              |  15 ++
> 4 files changed, 423 insertions(+), 3 deletions(-)
>
>--
>1.9.1