[v10,0/8] drm/i915: adding state checker for gamma lut values
mbox series

Message ID 1567538578-4489-1-git-send-email-swati2.sharma@intel.com
Headers show
Series
  • drm/i915: adding state checker for gamma lut values
Related show

Message

Swati Sharma Sept. 3, 2019, 7:22 p.m. UTC
In this patch series, added state checker to validate gamma
(8BIT and 10BIT).This reads hardware state, and compares the originally
requested state(s/w) to the state read from the hardware.
This is done for legacy, ilk, glk and their variant platforms. Rest of
the platforms will be enabled on top of this later.

Intentionally, excluded bdw and ivb since they have spilt gamma mode;
for which degamma read outs are required (which I think shouldn't be
included in this patch series). Will include after degamma state checker
is completed.

v1:  -Implementation done for legacy platforms
      (removed all the placeholders) (Jani)
v2:  -Restructured code and created platform specific patch series for 
      gamma validation
v3:  -Rebase
v4:  -Minor changes-function name changes mainly
v5:  -Added degamma validation (Ville)
v6:  -Removed degamma changes, debugging was becoming difficult
     -Added function to assign bit_precision for gamma/degamma
      lut values /platform
     -Added debug info into intel_dump_pipe_config() (Jani)
v7:  -Added platform specific functions to compute gamma bit precision
      on the basis of GAMMA_MODE (Ville)
     -Corrected checkpatch warnings
v8:  -Restructured code
     -Removed bdw and ivb platform state checker
v9:  -Obliged 80 character word limit [Uma]
     -Added state checker for icl
     -Added bit precision func for icl
v10: -Dropped multi-seg gamma mode [Jani]
     -Enabled basic infrastructure only [Jani]
     -Minor fixes [Jani]

Swati Sharma (8):
  drm/i915/display: Add func to get gamma bit precision
  drm/i915/display: Add debug log for color parameters
  drm/i915/display: Add func to compare hw/sw gamma lut
  drm/i915/display: Add macro to compare gamma hw/sw lut
  drm/i915/display: Extract i9xx_read_luts()
  drm/i915/display: Extract ilk_read_luts()
  drm/i915/display: Extract glk_read_luts()
  FOR_TESTING_ONLY: Print rgb values of hw and sw blobs

 drivers/gpu/drm/i915/display/intel_color.c   | 284 ++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_color.h   |   7 +
 drivers/gpu/drm/i915/display/intel_display.c |  34 ++++
 drivers/gpu/drm/i915/i915_reg.h              |   9 +
 4 files changed, 331 insertions(+), 3 deletions(-)

Comments

Jani Nikula Sept. 4, 2019, 9:30 a.m. UTC | #1
On Wed, 04 Sep 2019, Swati Sharma <swati2.sharma@intel.com> wrote:
> In this patch series, added state checker to validate gamma
> (8BIT and 10BIT).This reads hardware state, and compares the originally
> requested state(s/w) to the state read from the hardware.
> This is done for legacy, ilk, glk and their variant platforms. Rest of
> the platforms will be enabled on top of this later.
>
> Intentionally, excluded bdw and ivb since they have spilt gamma mode;
> for which degamma read outs are required (which I think shouldn't be
> included in this patch series). Will include after degamma state checker
> is completed.

Pushed the series, thanks for the patches and review!

Please proceed with the next steps! It should be easier now that you can
focus on enabling the checks for one feature or platform, and if needed,
one patch, at a time. :)

BR,
Jani.
Swati Sharma Sept. 4, 2019, 9:45 a.m. UTC | #2
Yay! Thanks Jani. 

Thanks and Regards,
Swati

-----Original Message-----
From: Jani Nikula <jani.nikula@intel.com> 
Sent: Wednesday, September 4, 2019 3:01 PM
To: Sharma, Swati2 <swati2.sharma@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Roper, Matthew D <matthew.d.roper@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Sharma, Shashank <shashank.sharma@intel.com>; Manna, Animesh <animesh.manna@intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; daniel.vetter@ffwll.ch; ville.syrjala@linux.intel.com; Shankar, Uma <uma.shankar@intel.com>; Sharma, Swati2 <swati2.sharma@intel.com>
Subject: Re: [v10][PATCH 0/8] drm/i915: adding state checker for gamma lut values

On Wed, 04 Sep 2019, Swati Sharma <swati2.sharma@intel.com> wrote:
> In this patch series, added state checker to validate gamma (8BIT and 
> 10BIT).This reads hardware state, and compares the originally 
> requested state(s/w) to the state read from the hardware.
> This is done for legacy, ilk, glk and their variant platforms. Rest of 
> the platforms will be enabled on top of this later.
>
> Intentionally, excluded bdw and ivb since they have spilt gamma mode; 
> for which degamma read outs are required (which I think shouldn't be 
> included in this patch series). Will include after degamma state 
> checker is completed.

Pushed the series, thanks for the patches and review!

Please proceed with the next steps! It should be easier now that you can focus on enabling the checks for one feature or platform, and if needed, one patch, at a time. :)

BR,
Jani.


--
Jani Nikula, Intel Open Source Graphics Center