mbox series

[0/2] a few commit-graph improvements

Message ID 20190907045848.GA24515@sigill.intra.peff.net (mailing list archive)
Headers show
Series a few commit-graph improvements | expand

Message

Jeff King Sept. 7, 2019, 4:58 a.m. UTC 
We've been playing with commit graphs at GitHub and found a few bits of
low-hanging fruit (one liners -- it doesn't get any lower than that).

The first one is actually a resurrection of a patch from March:

  https://public-inbox.org/git/20190322102817.19708-1-szeder.dev@gmail.com/

where the progress bar sometimes prints nonsense. There's some
discussion in that thread about how we could sometimes show a real
percentage instead of a counting-up progress meter. But given the number
of corner cases discussed, and the fact that nothing has happened for 6
months, I think we should first make sure we're always doing the
_correct_ thing, and then people can build a nicer meter on top if they
want to.

The second is a fix for a small memory "leak", but it makes a big
difference.

  [1/2]: commit-graph: don't show progress percentages while expanding reachable commits
  [2/2]: commit-graph: turn off save_commit_buffer

 builtin/commit-graph.c | 2 ++
 commit-graph.c         | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-Peff