[0/4] Few loose end intel_gt cleanups
mbox series

Message ID 20190910143823.10686-1-tvrtko.ursulin@linux.intel.com
Headers show
Series
  • Few loose end intel_gt cleanups
Related show

Message

Tvrtko Ursulin Sept. 10, 2019, 2:38 p.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

A few patches left hanging since late July. First one old in spirit but adjusted
and renamed and the rest update for latest drm-tip.

Happy to receive thoughts on whether this cleanup makes sense.

Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>

Tvrtko Ursulin (4):
  drm/i915: Move GT init to intel_gt.c
  drm/i915: Make wait_for_timelines take struct intel_gt
  drm/i915: Avoid round-trip via i915 in intel_gt_park
  drm/i915: Make pm_notify take intel_gt

 drivers/gpu/drm/i915/gem/i915_gem_pm.c    |   2 +-
 drivers/gpu/drm/i915/gt/intel_gt.c        |  92 ++++++++++++++++++-
 drivers/gpu/drm/i915/gt/intel_gt.h        |   3 +-
 drivers/gpu/drm/i915/gt/intel_gt_pm.c     |  14 +--
 drivers/gpu/drm/i915/gt/intel_reset.c     |   2 +-
 drivers/gpu/drm/i915/i915_drv.c           |   2 +-
 drivers/gpu/drm/i915/i915_drv.h           |   1 -
 drivers/gpu/drm/i915/i915_gem.c           | 102 ++--------------------
 drivers/gpu/drm/i915/selftests/mock_gtt.c |   2 +-
 9 files changed, 111 insertions(+), 109 deletions(-)

Comments

Tvrtko Ursulin Sept. 11, 2019, 7:14 a.m. UTC | #1
On 10/09/2019 16:17, Patchwork wrote:
> == Series Details ==
> 
> Series: Few loose end intel_gt cleanups
> URL   : https://patchwork.freedesktop.org/series/66490/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6861 -> Patchwork_14342
> ====================================================
> 
> Summary
> -------
> 
>    **SUCCESS**
> 
>    No regressions found.
> 
>    External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/
> 
> Possible new issues
> -------------------
> 
>    Here are the unknown changes that may have been introduced in Patchwork_14342:
> 
> ### IGT changes ###
> 
> #### Suppressed ####
> 
>    The following results come from untrusted machines, tests, or statuses.
>    They do not affect the overall result.
> 
>    * igt@gem_sync@basic-each:
>      - {fi-tgl-u}:         NOTRUN -> [INCOMPLETE][1]
>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-tgl-u/igt@gem_sync@basic-each.html
> 
>    
> Known issues
> ------------
> 
>    Here are the changes found in Patchwork_14342 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>    * igt@gem_basic@create-close:
>      - fi-icl-u3:          [PASS][2] -> [DMESG-WARN][3] ([fdo#107724]) +1 similar issue
>     [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u3/igt@gem_basic@create-close.html
>     [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u3/igt@gem_basic@create-close.html
> 
>    
> #### Possible fixes ####
> 
>    * igt@gem_ctx_switch@legacy-render:
>      - {fi-icl-guc}:       [INCOMPLETE][4] ([fdo#107713] / [fdo#111381]) -> [PASS][5]
>     [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-guc/igt@gem_ctx_switch@legacy-render.html
>     [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-guc/igt@gem_ctx_switch@legacy-render.html
>      - fi-icl-u2:          [INCOMPLETE][6] ([fdo#107713] / [fdo#111381]) -> [PASS][7]
>     [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
>     [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
> 
>    * igt@gem_exec_gttfill@basic:
>      - {fi-tgl-u}:         [INCOMPLETE][8] ([fdo#111593]) -> [PASS][9]
>     [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-tgl-u/igt@gem_exec_gttfill@basic.html
>     [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-tgl-u/igt@gem_exec_gttfill@basic.html
> 
>    * igt@gem_render_tiled_blits@basic:
>      - fi-icl-u3:          [DMESG-WARN][10] ([fdo#107724]) -> [PASS][11]
>     [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-icl-u3/igt@gem_render_tiled_blits@basic.html
>     [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-icl-u3/igt@gem_render_tiled_blits@basic.html
> 
>    * igt@i915_selftest@live_execlists:
>      - fi-skl-gvtdvm:      [DMESG-FAIL][12] ([fdo#111108]) -> [PASS][13]
>     [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
>     [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
> 
>    
> #### Warnings ####
> 
>    * igt@kms_chamelium@hdmi-hpd-fast:
>      - fi-kbl-7500u:       [FAIL][14] ([fdo#111096]) -> [FAIL][15] ([fdo#111407])
>     [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6861/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>     [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14342/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> 
>    
>    {name}: This element is suppressed. This means it is ignored when computing
>            the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>    [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>    [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>    [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
>    [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
>    [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
>    [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
>    [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
> 
> 
> Participating hosts (54 -> 46)
> ------------------------------
> 
>    Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-byt-clapper fi-bdw-samus
> 
> 
> Build changes
> -------------
> 
>    * CI: CI-20190529 -> None
>    * Linux: CI_DRM_6861 -> Patchwork_14342
> 
>    CI-20190529: 20190529
>    CI_DRM_6861: 32c81a3173640f165510de65b8e4137aa049b33f @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_14342: ec71271e3802895ae608065d4914d63157adae2c @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> ec71271e3802 drm/i915: Make pm_notify take intel_gt
> f3e26c80db02 drm/i915: Avoid round-trip via i915 in intel_gt_park
> 98290456e271 drm/i915: Make wait_for_timelines take struct intel_gt
> 4144570a45a2 drm/i915: Move GT init to intel_gt.c

I've pushed these four, thanks for the review. Now lets see if there are 
some other easy pickings..

Regards,

Tvrtko