mbox series

[0/2] completion: teach rebase and archive to use __gitcomp_builtin

Message ID cover.1568317093.git.liu.denton@gmail.com (mailing list archive)
Headers show
Series completion: teach rebase and archive to use __gitcomp_builtin | expand

Message

Denton Liu Sept. 12, 2019, 7:43 p.m. UTC 
Currently, the completion function for rebase and archive don't take
advantage of __gitcomp_builtin(). Teach them to use it so that future
changes to options will automatically be included by the completion
script with no extra work.

I discovered rebase wasn't using it and fixed that and I started looking
for other low-hanging fruit to fix. I deliberately left stuff like diff
and log alone since that's a whole Pandora's box that I don't really
want to open right now.


Denton Liu (2):
  completion: teach rebase to use __gitcomp_builtin
  completion: teach archive to use __gitcomp_builtin

 contrib/completion/git-completion.bash | 27 ++++++++------------------
 1 file changed, 8 insertions(+), 19 deletions(-)

Comments

Junio C Hamano Sept. 12, 2019, 8:44 p.m. UTC | #1 
Denton Liu <liu.denton@gmail.com> writes:

> Currently, the completion function for rebase and archive don't take
> advantage of __gitcomp_builtin(). Teach them to use it so that future
> changes to options will automatically be included by the completion
> script with no extra work.

Nice ;-)