[0/6] Non-urgent fixes and improvments for omap3-rom-rng

Message

Tony Lindgren Sept. 13, 2019, 10:09 p.m. UTC

Hi all,

Here are fixes and improvments for omap3-rom-rng that's been broken for
a while.

The first four patches get it working, and then the last two patches add
support for runtime PM.

Regards,

Tony


Tony Lindgren (6):
  ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device
  hwrng: omap3-rom - Fix missing clock by probing with device tree
  hwrng: omap3-rom - Call clk_prepare() on init and exit only
  hwrng: omap3-rom - Initialize default quality to get data
  hwrng: omap3-rom - Update to use standard driver data
  hwrng: omap3-rom - Use runtime PM instead of custom functions

 .../devicetree/bindings/rng/omap3_rom_rng.txt |  27 +++
 arch/arm/boot/dts/omap3-n900.dts              |   6 +
 arch/arm/mach-omap2/pdata-quirks.c            |  14 +-
 drivers/char/hw_random/omap3-rom-rng.c        | 186 ++++++++++++------
 4 files changed, 162 insertions(+), 71 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rng/omap3_rom_rng.txt

Comments

Sebastian Reichel Sept. 14, 2019, 1:05 p.m. UTC | #1

Hi,

On Fri, Sep 13, 2019 at 03:09:16PM -0700, Tony Lindgren wrote:
> Here are fixes and improvments for omap3-rom-rng that's been broken for
> a while.
> 
> The first four patches get it working, and then the last two patches add
> support for runtime PM.

Nice cleanups, the series is

Reviewed-by: Sebastian Reichel <[e-mail]>

Assuming you use clk_prepare_enable() in the runtime PM handler, I
suggest to add another patch and go all the way to managed resources:
devm_add_action() can be used for disabling runtime PM and
devm_hwrng_register() can be used to register the hwrng device.

-- Sebastian

Tony Lindgren Sept. 14, 2019, 5:59 p.m. UTC | #2

* Sebastian Reichel <[e-mail]> [190914 13:06]:
> Hi,
> 
> On Fri, Sep 13, 2019 at 03:09:16PM -0700, Tony Lindgren wrote:
> > Here are fixes and improvments for omap3-rom-rng that's been broken for
> > a while.
> > 
> > The first four patches get it working, and then the last two patches add
> > support for runtime PM.
> 
> Nice cleanups, the series is
> 
> Reviewed-by: Sebastian Reichel <[e-mail]>
> 
> Assuming you use clk_prepare_enable() in the runtime PM handler, I
> suggest to add another patch and go all the way to managed resources:
> devm_add_action() can be used for disabling runtime PM and
> devm_hwrng_register() can be used to register the hwrng device.

Sure good idea. I'll post a patch for that when I post v2 of
this set.

Regards,

Tony