mbox series

[0/3] clone --filter=sparse:oid bugs

Message ID 20190915010942.GA19787@sigill.intra.peff.net (mailing list archive)
Headers show
Series clone --filter=sparse:oid bugs | expand

Message

Jeff King Sept. 15, 2019, 1:09 a.m. UTC 
On Mon, Sep 09, 2019 at 01:08:24PM -0400, Jeff King wrote:

> I'll work up what I sent earlier into a real patch, and include some of
> this discussion.

Here it is. I pulled Jon's tests out into their own patch (mostly
because it makes it easier to give credit). Then patch 2 is my fix, and
patch 3 is the message fixups he had done.

This replaces what's queued in js/partial-clone-sparse-blob.

  [1/3]: t5616: test cloning/fetching with sparse:oid=<oid> filter
  [2/3]: list-objects-filter: delay parsing of sparse oid
  [3/3]: list-objects-filter: give a more specific error sparse parsing error

 builtin/rev-list.c            |  4 ----
 list-objects-filter-options.c | 14 ++------------
 list-objects-filter-options.h |  2 +-
 list-objects-filter.c         | 14 +++++++++++---
 t/t5616-partial-clone.sh      | 36 +++++++++++++++++++++++++++++++++++
 5 files changed, 50 insertions(+), 20 deletions(-)

Comments

Jeff Hostetler Sept. 16, 2019, 2:31 p.m. UTC | #1 
On 9/14/2019 9:09 PM, Jeff King wrote:
> On Mon, Sep 09, 2019 at 01:08:24PM -0400, Jeff King wrote:
> 
>> I'll work up what I sent earlier into a real patch, and include some of
>> this discussion.
> 
> Here it is. I pulled Jon's tests out into their own patch (mostly
> because it makes it easier to give credit). Then patch 2 is my fix, and
> patch 3 is the message fixups he had done.
> 
> This replaces what's queued in js/partial-clone-sparse-blob.
> 
>    [1/3]: t5616: test cloning/fetching with sparse:oid=<oid> filter
>    [2/3]: list-objects-filter: delay parsing of sparse oid
>    [3/3]: list-objects-filter: give a more specific error sparse parsing error
> 
>   builtin/rev-list.c            |  4 ----
>   list-objects-filter-options.c | 14 ++------------
>   list-objects-filter-options.h |  2 +-
>   list-objects-filter.c         | 14 +++++++++++---
>   t/t5616-partial-clone.sh      | 36 +++++++++++++++++++++++++++++++++++
>   5 files changed, 50 insertions(+), 20 deletions(-)
> 

This series looks good to me.

Thanks!
Jeff