[xf86-video-intel,00/21] Compiler warn elimination
mbox series

Message ID 20190919163113.17402-1-ville.syrjala@linux.intel.com
Headers show
Series
  • Compiler warn elimination
Related show

Message

Ville Syrjälä Sept. 19, 2019, 4:30 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Random smattering of patches to eliminate compiler warnings.
Some I just suppressed out of lazyness, others I tried to
silence by adjusting the code a bit.

Afterwards the build is clean on my gcc 8.3, though with
a bunch of stuff still suppressed I'm not 100% sure that's
a good thing.

git://github.com/vsyrjala/xf86-video-intel.git compiler_warns_3

Ville Syrjälä (21):
  sna: Use -Wno-clobbered
  sna: Shut up more compiler warns
  sna: undef FontSetPrivate() before redefining it
  sna: Replace fall through comments with standard form
  sna: Annotate more fall throughs
  sna: Add sna_br13_color_depth()
  sna/fb: Eliminate implicit fallthrough
  uxa: Use named initializers
  Avoid missing initializer warning
  sna: Use named initializers
  sna: Increase the size of the path name buffer a bit
  sna: Use memcmp() to avoid strict aliasing warns
  sna: Avoid strict aliasing violations with glyphinfo
  sna/fb: Use memcpy() to avoid strict aliasing violations
  xvmc: Eliminate strict aliasing violations
  sna/fb: Initialize xoff/yoff
  sna: Use -Wno-maybe-uninitialized
  sna: Get rid of -Wno-shift-negative-value
  uxa: Get rid of -Wno-shift-negative-value
  tools: Get rid of -Wno-sign-compare
  sna: Fix compiler warnings due to DrawablePtr vs. PixmapPtr

 src/intel_device.c              |  2 +-
 src/intel_module.c              |  3 +-
 src/legacy/i810/xvmc/I810XvMC.c | 48 ++++++++++++++--------------
 src/meson.build                 |  1 -
 src/sna/blt.c                   |  2 ++
 src/sna/fb/fb.h                 |  6 ++--
 src/sna/fb/fbpict.c             |  6 +++-
 src/sna/fb/fbspan.c             |  6 ++--
 src/sna/gen2_render.c           | 21 ++++++++++---
 src/sna/gen3_render.c           | 24 ++++++++++----
 src/sna/gen4_render.c           |  6 ++--
 src/sna/gen5_render.c           |  6 ++--
 src/sna/gen6_render.c           |  6 ++--
 src/sna/gen7_render.c           |  6 ++--
 src/sna/gen8_render.c           |  6 ++--
 src/sna/gen9_render.c           |  6 ++--
 src/sna/kgem.c                  | 10 ++----
 src/sna/meson.build             |  7 +++--
 src/sna/sna.h                   | 19 +++++++++++
 src/sna/sna_accel.c             | 24 +++++++++++++-
 src/sna/sna_blt.c               | 56 +++++++--------------------------
 src/sna/sna_composite.c         |  2 +-
 src/sna/sna_damage.h            |  1 +
 src/sna/sna_display.c           | 15 ++++-----
 src/sna/sna_display_fake.c      |  2 +-
 src/sna/sna_dri2.c              |  6 ++--
 src/sna/sna_driver.c            |  1 +
 src/sna/sna_glyphs.c            |  7 +++--
 src/sna/sna_io.c                | 30 ++++++------------
 src/sna/sna_render.c            |  4 +--
 src/sna/sna_render.h            |  2 +-
 src/sna/sna_trapezoids_mono.c   |  2 +-
 src/sna/sna_video_overlay.c     |  6 +++-
 src/sna/sna_video_sprite.c      |  8 ++++-
 src/sna/sna_video_textured.c    |  5 ++-
 src/uxa/i965_render.c           |  2 +-
 src/uxa/i965_video.c            |  2 +-
 src/uxa/intel_display.c         |  2 +-
 src/uxa/intel_dri.c             |  1 +
 src/uxa/meson.build             |  1 -
 tools/backlight_helper.c        |  2 +-
 tools/meson.build               |  2 --
 tools/virtual.c                 | 18 +++++------
 43 files changed, 221 insertions(+), 171 deletions(-)

Comments

Chris Wilson Sept. 27, 2019, 7:41 p.m. UTC | #1
Quoting Ville Syrjala (2019-09-19 17:30:52)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Random smattering of patches to eliminate compiler warnings.
> Some I just suppressed out of lazyness, others I tried to
> silence by adjusting the code a bit.

Some of the aliasing pointer avoidance looked silly, but silly compiler
is silly.
 
> Afterwards the build is clean on my gcc 8.3, though with
> a bunch of stuff still suppressed I'm not 100% sure that's
> a good thing.

Definitely quieter which is much less offputting.
Thanks,
-Chris