[v3,0/5] Handle the case when KernelShark is started as Root
mbox series

Message ID 20190920102852.22769-1-y.karadz@gmail.com
Headers show
  • Handle the case when KernelShark is started as Root
Related show


Yordan Karadzhov (VMware) Sept. 20, 2019, 10:28 a.m. UTC
A patch set implementing the improvements suggested here:


Plus a minor improvements of the error messages printed when something
goes wrong withe the "Record" dialog.  

v2 changes:
  - Correcting typos in patch 1/5
  - Fixing a bug in patch 2/5. trace-cmd now gets correctly formatted list
  of command line arguments.
  - Patches 4/5 and 5/5 are new.

v3 changes:
  - Polishing the text of the warning/error messages in patches 1/5 and
  5/5. The modifications have been suggested by Steven.

Yordan Karadzhov (VMware) (5):
  kernel-shark: Show warning message when running as Root
  kernel-shark: Don't use pkexec when running as Root
  kernel-shark: Use standart error message in KsMainWindow::_record()
  kernel-shark: Optimize the error messages when "Record" fails to start
  kernel-shark: Better formatting of the error messages from "Record"

 kernel-shark/src/KsMainWindow.cpp | 90 +++++++++++++++++++++++--------
 kernel-shark/src/KsMainWindow.hpp |  4 ++
 2 files changed, 71 insertions(+), 23 deletions(-)