mbox series

[v3,0/7] clk: meson: axg-audio: add sm1 support

Message ID 20191002091529.17112-1-jbrunet@baylibre.com (mailing list archive)
Headers show
Series clk: meson: axg-audio: add sm1 support | expand

Message

Jerome Brunet Oct. 2, 2019, 9:15 a.m. UTC
The purpose of this patchset is to add the sm1 support to the amlogic audio
clock controller. The line count is lot higher than what I hoped for. Even
if extremely similar, there is a shift in the register address on the sm1
which makes a bit of a mess.

I could have patched the address on the fly if running on sm1 but the end
result did not save much lines and would have been a pain to maintain and
scale in the future

Instead I choose to re-arrange the driver to share the macros and declare
separate clocks for the clock which have changed.

Changes since v2 [1]:
 - Add missing gate ops for
  * sm1_clk81_en
  * sm1_sysclk_a_en
  * sm1_sysclk_b_en

Changes since v1 [0]:
 - Fix newline in the last patch

[0]: https://lkml.kernel.org/r/20190924153356.24103-1-jbrunet@baylibre.com
[1]: https://lkml.kernel.org/r/20191001115511.17357-1-jbrunet@baylibre.com>

Jerome Brunet (7):
  dt-bindings: clk: axg-audio: add sm1 bindings
  dt-bindings: clock: meson: add sm1 resets to the axg-audio controller
  clk: meson: axg-audio: remove useless defines
  clk: meson: axg-audio: fix regmap last register
  clk: meson: axg-audio: prepare sm1 addition
  clk: meson: axg-audio: provide clk top signal name
  clk: meson: axg_audio: add sm1 support

 .../bindings/clock/amlogic,axg-audio-clkc.txt |    3 +-
 drivers/clk/meson/axg-audio.c                 | 2021 +++++++++++------
 drivers/clk/meson/axg-audio.h                 |   21 +-
 include/dt-bindings/clock/axg-audio-clkc.h    |   10 +
 .../reset/amlogic,meson-g12a-audio-reset.h    |   15 +
 5 files changed, 1373 insertions(+), 697 deletions(-)

Comments

Jerome Brunet Oct. 8, 2019, 7:35 a.m. UTC | #1
On Wed 02 Oct 2019 at 11:15, Jerome Brunet <jbrunet@baylibre.com> wrote:

> The purpose of this patchset is to add the sm1 support to the amlogic audio
> clock controller. The line count is lot higher than what I hoped for. Even
> if extremely similar, there is a shift in the register address on the sm1
> which makes a bit of a mess.
>
> I could have patched the address on the fly if running on sm1 but the end
> result did not save much lines and would have been a pain to maintain and
> scale in the future
>
> Instead I choose to re-arrange the driver to share the macros and declare
> separate clocks for the clock which have changed.
>
> Changes since v2 [1]:
>  - Add missing gate ops for
>   * sm1_clk81_en
>   * sm1_sysclk_a_en
>   * sm1_sysclk_b_en
>
> Changes since v1 [0]:
>  - Fix newline in the last patch
>
> [0]: https://lkml.kernel.org/r/20190924153356.24103-1-jbrunet@baylibre.com
> [1]: https://lkml.kernel.org/r/20191001115511.17357-1-jbrunet@baylibre.com>
>
> Jerome Brunet (7):
>   dt-bindings: clk: axg-audio: add sm1 bindings
>   dt-bindings: clock: meson: add sm1 resets to the axg-audio controller
>   clk: meson: axg-audio: remove useless defines
>   clk: meson: axg-audio: fix regmap last register
>   clk: meson: axg-audio: prepare sm1 addition
>   clk: meson: axg-audio: provide clk top signal name
>   clk: meson: axg_audio: add sm1 support
>
>  .../bindings/clock/amlogic,axg-audio-clkc.txt |    3 +-
>  drivers/clk/meson/axg-audio.c                 | 2021 +++++++++++------
>  drivers/clk/meson/axg-audio.h                 |   21 +-
>  include/dt-bindings/clock/axg-audio-clkc.h    |   10 +
>  .../reset/amlogic,meson-g12a-audio-reset.h    |   15 +
>  5 files changed, 1373 insertions(+), 697 deletions(-)

Applied