[PATCHv2,0/4] Convert all btwilink users to hci_ll and drop btwilink
mbox series

Message ID 20191003134147.9458-1-sre@kernel.org
Headers show
Series
  • Convert all btwilink users to hci_ll and drop btwilink
Related show

Message

Sebastian Reichel Oct. 3, 2019, 1:41 p.m. UTC
Hi,

This moves the remaining users of btwilink to the "new" serdev based hci_ll
driver and drops the btwilink driver afterwards. The patches were only compile
tested by me, but Enric tested the IGEP platform and Adam will test the LogicPD
platform.

I kept the TI_ST driver for now, since I plan to send a second patchset for the
FM radio driver. Once the FM driver has been converted to also use hci_ll, we
can remove TI_ST completly.

My suggestion is for the patch handling is, that everything simply goes through
Tony's tree.

Changes since PATCHv1 [0]
 * rebase to 5.4-rc1
 * move FM radio patches into separate patchset

[0] https://lore.kernel.org/lkml/20181221011752.25627-1-sre@kernel.org/

-- Sebastian

Sebastian Reichel (4):
  ARM: dts: LogicPD Torpedo: Add WiLink UART node
  ARM: dts: IGEP: Add WiLink UART node
  ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support
  Bluetooth: btwilink: drop superseded driver

 .../boot/dts/logicpd-torpedo-37xx-devkit.dts  |   8 +
 arch/arm/boot/dts/omap3-igep0020-rev-f.dts    |   8 +
 arch/arm/boot/dts/omap3-igep0030-rev-g.dts    |   8 +
 arch/arm/mach-omap2/pdata-quirks.c            |  52 ---
 drivers/bluetooth/Kconfig                     |  11 -
 drivers/bluetooth/Makefile                    |   1 -
 drivers/bluetooth/btwilink.c                  | 337 ------------------
 7 files changed, 24 insertions(+), 401 deletions(-)
 delete mode 100644 drivers/bluetooth/btwilink.c

Comments

Tony Lindgren Oct. 8, 2019, 2:31 p.m. UTC | #1
* Sebastian Reichel <sre@kernel.org> [191003 06:42]:
> Hi,
> 
> This moves the remaining users of btwilink to the "new" serdev based hci_ll
> driver and drops the btwilink driver afterwards. The patches were only compile
> tested by me, but Enric tested the IGEP platform and Adam will test the LogicPD
> platform.
> 
> I kept the TI_ST driver for now, since I plan to send a second patchset for the
> FM radio driver. Once the FM driver has been converted to also use hci_ll, we
> can remove TI_ST completly.
> 
> My suggestion is for the patch handling is, that everything simply goes through
> Tony's tree.

Sounds good to me, good to see kim gone with patch 3/4 :)

Marcel, care to ack the old driver removal patch?

Regards,

Tony

> Changes since PATCHv1 [0]
>  * rebase to 5.4-rc1
>  * move FM radio patches into separate patchset
> 
> [0] https://lore.kernel.org/lkml/20181221011752.25627-1-sre@kernel.org/
> 
> -- Sebastian
> 
> Sebastian Reichel (4):
>   ARM: dts: LogicPD Torpedo: Add WiLink UART node
>   ARM: dts: IGEP: Add WiLink UART node
>   ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support
>   Bluetooth: btwilink: drop superseded driver
> 
>  .../boot/dts/logicpd-torpedo-37xx-devkit.dts  |   8 +
>  arch/arm/boot/dts/omap3-igep0020-rev-f.dts    |   8 +
>  arch/arm/boot/dts/omap3-igep0030-rev-g.dts    |   8 +
>  arch/arm/mach-omap2/pdata-quirks.c            |  52 ---
>  drivers/bluetooth/Kconfig                     |  11 -
>  drivers/bluetooth/Makefile                    |   1 -
>  drivers/bluetooth/btwilink.c                  | 337 ------------------
>  7 files changed, 24 insertions(+), 401 deletions(-)
>  delete mode 100644 drivers/bluetooth/btwilink.c
> 
> -- 
> 2.23.0
>
Sebastian Reichel Oct. 20, 2019, 8:33 p.m. UTC | #2
Hi Tony,

On Tue, Oct 08, 2019 at 07:31:16AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sre@kernel.org> [191003 06:42]:
> > This moves the remaining users of btwilink to the "new" serdev based hci_ll
> > driver and drops the btwilink driver afterwards. The patches were only compile
> > tested by me, but Enric tested the IGEP platform and Adam will test the LogicPD
> > platform.
> > 
> > I kept the TI_ST driver for now, since I plan to send a second patchset for the
> > FM radio driver. Once the FM driver has been converted to also use hci_ll, we
> > can remove TI_ST completly.
> > 
> > My suggestion is for the patch handling is, that everything simply goes through
> > Tony's tree.
> 
> Sounds good to me, good to see kim gone with patch 3/4 :)
> 
> Marcel, care to ack the old driver removal patch?

Looks like Marcel missed the extra messages and merged the 4th
patch, so I guess you can just merge patches 1-3. Technically that
might lead to temporarily missing BT support on those two devices
when the BT tree is merged before ARM tree during the merge window.
Not a big issue I guess.

-- Sebastian
Tony Lindgren Oct. 22, 2019, 4:01 p.m. UTC | #3
* Sebastian Reichel <sre@kernel.org> [191020 20:34]:
> Hi Tony,
> 
> On Tue, Oct 08, 2019 at 07:31:16AM -0700, Tony Lindgren wrote:
> > * Sebastian Reichel <sre@kernel.org> [191003 06:42]:
> > > This moves the remaining users of btwilink to the "new" serdev based hci_ll
> > > driver and drops the btwilink driver afterwards. The patches were only compile
> > > tested by me, but Enric tested the IGEP platform and Adam will test the LogicPD
> > > platform.
> > > 
> > > I kept the TI_ST driver for now, since I plan to send a second patchset for the
> > > FM radio driver. Once the FM driver has been converted to also use hci_ll, we
> > > can remove TI_ST completly.
> > > 
> > > My suggestion is for the patch handling is, that everything simply goes through
> > > Tony's tree.
> > 
> > Sounds good to me, good to see kim gone with patch 3/4 :)
> > 
> > Marcel, care to ack the old driver removal patch?
> 
> Looks like Marcel missed the extra messages and merged the 4th
> patch, so I guess you can just merge patches 1-3. Technically that
> might lead to temporarily missing BT support on those two devices
> when the BT tree is merged before ARM tree during the merge window.
> Not a big issue I guess.

Sure no problem. Applying dts changes into omap-for-v5.5/dt
and the pdata quirk removal to omap-for-v5.5/soc.

I guess ti_wilink_st.h will need some follow-up patch to
remove unused platform data, but best to wait on that.

Regards,

Tony
Sebastian Reichel Oct. 23, 2019, 12:06 p.m. UTC | #4
Hi,

On Tue, Oct 22, 2019 at 09:01:11AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sre@kernel.org> [191020 20:34]:
> > On Tue, Oct 08, 2019 at 07:31:16AM -0700, Tony Lindgren wrote:
> > > * Sebastian Reichel <sre@kernel.org> [191003 06:42]:
> > > > This moves the remaining users of btwilink to the "new" serdev based hci_ll
> > > > driver and drops the btwilink driver afterwards. The patches were only compile
> > > > tested by me, but Enric tested the IGEP platform and Adam will test the LogicPD
> > > > platform.
> > > > 
> > > > I kept the TI_ST driver for now, since I plan to send a second patchset for the
> > > > FM radio driver. Once the FM driver has been converted to also use hci_ll, we
> > > > can remove TI_ST completly.
> > > > 
> > > > My suggestion is for the patch handling is, that everything simply goes through
> > > > Tony's tree.
> > > 
> > > Sounds good to me, good to see kim gone with patch 3/4 :)
> > > 
> > > Marcel, care to ack the old driver removal patch?
> > 
> > Looks like Marcel missed the extra messages and merged the 4th
> > patch, so I guess you can just merge patches 1-3. Technically that
> > might lead to temporarily missing BT support on those two devices
> > when the BT tree is merged before ARM tree during the merge window.
> > Not a big issue I guess.
> 
> Sure no problem. Applying dts changes into omap-for-v5.5/dt
> and the pdata quirk removal to omap-for-v5.5/soc.

Thanks.

> I guess ti_wilink_st.h will need some follow-up patch to
> remove unused platform data, but best to wait on that.

The header will receive a cleanup in the patchset moving the FM
driver from TI_ST to serdev based bluetooth driver. After that
patchset most of the ti_wilink_st.h content can be removed.

-- Sebastian