[v7,0/7] Add support of New Amlogic temperature sensor for G12 SoCs
mbox series

Message ID 20191004090114.30694-1-glaroque@baylibre.com
Headers show
Series
  • Add support of New Amlogic temperature sensor for G12 SoCs
Related show

Message

Guillaume La Roque Oct. 4, 2019, 9:01 a.m. UTC
This patchs series add support of New Amlogic temperature sensor and minimal
thermal zone for SEI510 and ODROID-N2 boards.

First implementation was doing on IIO[1] but after comments i move on thermal framework.
Formulas and calibration values come from amlogic.

Changes since v6:
 - add missing critical trip point.

Changes since v5:
  - fix patch 5 and 6 send twice

Changes since v4:
  - Move thermal-zone in soc dtsi file
  - Remove critical trip point and add passive one
  - fix commit message
  - use devm_platform_ioremap_resource instead of platform_get_resource

Changes since v3:
  - Add cooling map and trip point for hot type
  - move compatible on g12a instead of g12 to be aligned with others
  - add all reviewer, sorry for this mistake

Changes since v2:
  - fix yaml documention
  - remove unneeded status variable for temperature-sensor node
  - rework driver after Martin review
  - add some information in commit message

Changes since v1:
  - fix enum vs const in documentation
  - fix error with thermal-sensor-cells value set to 1 instead of 0
  - add some dependencies needed to add cooling-maps

Dependencies :
- patch 3,4 & 5: depends on Neil's patch and series :
              - missing dwc2 phy-names[2]
              - patchsets to add DVFS on G12a[3] which have deps on [4] and [5]

[1] https://lore.kernel.org/linux-amlogic/20190604144714.2009-1-glaroque@baylibre.com/
[2] https://lore.kernel.org/linux-amlogic/20190625123647.26117-1-narmstrong@baylibre.com/
[3] https://lore.kernel.org/linux-amlogic/20190729132622.7566-1-narmstrong@baylibre.com/
[4] https://lore.kernel.org/linux-amlogic/20190731084019.8451-5-narmstrong@baylibre.com/
[5] https://lore.kernel.org/linux-amlogic/20190729132622.7566-3-narmstrong@baylibre.com/

Guillaume La Roque (7):
  dt-bindings: thermal: Add DT bindings documentation for Amlogic
    Thermal
  thermal: amlogic: Add thermal driver to support G12 SoCs
  arm64: dts: amlogic: g12: add temperature sensor
  arm64: dts: meson: g12: Add minimal thermal zone
  arm64: dts: amlogic: g12a: add cooling properties
  arm64: dts: amlogic: g12b: add cooling properties
  MAINTAINERS: add entry for Amlogic Thermal driver

 .../bindings/thermal/amlogic,thermal.yaml     |  54 +++
 MAINTAINERS                                   |   9 +
 .../boot/dts/amlogic/meson-g12-common.dtsi    |  77 ++++
 arch/arm64/boot/dts/amlogic/meson-g12a.dtsi   |  24 ++
 arch/arm64/boot/dts/amlogic/meson-g12b.dtsi   |  29 ++
 drivers/thermal/Kconfig                       |  11 +
 drivers/thermal/Makefile                      |   1 +
 drivers/thermal/amlogic_thermal.c             | 333 ++++++++++++++++++
 8 files changed, 538 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
 create mode 100644 drivers/thermal/amlogic_thermal.c

Comments

Kevin Hilman Oct. 16, 2019, 4:39 p.m. UTC | #1
Eduardo,

Guillaume La Roque <glaroque@baylibre.com> writes:

> This patchs series add support of New Amlogic temperature sensor and minimal
> thermal zone for SEI510 and ODROID-N2 boards.

[...]

> Guillaume La Roque (7):
>   dt-bindings: thermal: Add DT bindings documentation for Amlogic
>     Thermal
>   thermal: amlogic: Add thermal driver to support G12 SoCs
>   arm64: dts: amlogic: g12: add temperature sensor
>   arm64: dts: meson: g12: Add minimal thermal zone
>   arm64: dts: amlogic: g12a: add cooling properties
>   arm64: dts: amlogic: g12b: add cooling properties
>   MAINTAINERS: add entry for Amlogic Thermal driver

This has now been thorougly reviewed/tested.

I've queued all the "arm64: dts:" patches via my amlogic tree for v5.5.
Can you please queue up the driver, bindings and MAINTAINERS patch?

Thanks,

Kevin
Daniel Lezcano Oct. 16, 2019, 4:45 p.m. UTC | #2
Hi Kevin,

On 16/10/2019 18:39, Kevin Hilman wrote:
> Eduardo,
> 
> Guillaume La Roque <glaroque@baylibre.com> writes:
> 
>> This patchs series add support of New Amlogic temperature sensor and minimal
>> thermal zone for SEI510 and ODROID-N2 boards.
> 
> [...]
> 
>> Guillaume La Roque (7):
>>   dt-bindings: thermal: Add DT bindings documentation for Amlogic
>>     Thermal
>>   thermal: amlogic: Add thermal driver to support G12 SoCs
>>   arm64: dts: amlogic: g12: add temperature sensor
>>   arm64: dts: meson: g12: Add minimal thermal zone
>>   arm64: dts: amlogic: g12a: add cooling properties
>>   arm64: dts: amlogic: g12b: add cooling properties
>>   MAINTAINERS: add entry for Amlogic Thermal driver
> 
> This has now been thorougly reviewed/tested.
> 
> I've queued all the "arm64: dts:" patches via my amlogic tree for v5.5.
> Can you please queue up the driver, bindings and MAINTAINERS patch?

1, 2, 7 right?
Kevin Hilman Oct. 17, 2019, 3:43 p.m. UTC | #3
Hi Daniel,

Daniel Lezcano <daniel.lezcano@linaro.org> writes:

> On 16/10/2019 18:39, Kevin Hilman wrote:
>> Eduardo,
>> 
>> Guillaume La Roque <glaroque@baylibre.com> writes:
>> 
>>> This patchs series add support of New Amlogic temperature sensor and minimal
>>> thermal zone for SEI510 and ODROID-N2 boards.
>> 
>> [...]
>> 
>>> Guillaume La Roque (7):
>>>   dt-bindings: thermal: Add DT bindings documentation for Amlogic
>>>     Thermal
>>>   thermal: amlogic: Add thermal driver to support G12 SoCs
>>>   arm64: dts: amlogic: g12: add temperature sensor
>>>   arm64: dts: meson: g12: Add minimal thermal zone
>>>   arm64: dts: amlogic: g12a: add cooling properties
>>>   arm64: dts: amlogic: g12b: add cooling properties
>>>   MAINTAINERS: add entry for Amlogic Thermal driver
>> 
>> This has now been thorougly reviewed/tested.
>> 
>> I've queued all the "arm64: dts:" patches via my amlogic tree for v5.5.
>> Can you please queue up the driver, bindings and MAINTAINERS patch?
>
> 1, 2, 7 right?

Correct.

Thanks,

Kevin